blob: 54027816144939da5d0b266d4822973b84f91e82 [file] [log] [blame]
Thomas Gleixnerd2912cb2019-06-04 10:11:33 +02001// SPDX-License-Identifier: GPL-2.0-only
Ben Hutchings8ceee662008-04-27 12:55:59 +01002/****************************************************************************
Ben Hutchingsf7a6d2c2013-08-29 23:32:48 +01003 * Driver for Solarflare network controllers and boards
Ben Hutchings0a6f40c2011-02-25 00:01:34 +00004 * Copyright 2006-2011 Solarflare Communications Inc.
Ben Hutchings8ceee662008-04-27 12:55:59 +01005 */
6/*
7 * Useful functions for working with MDIO clause 45 PHYs
8 */
9#include <linux/types.h>
10#include <linux/ethtool.h>
11#include <linux/delay.h>
12#include "net_driver.h"
13#include "mdio_10g.h"
Steve Hodgson8b9dc8d2009-01-29 17:49:09 +000014#include "workarounds.h"
Ben Hutchings8ceee662008-04-27 12:55:59 +010015
Edward Cree5a6681e2016-11-28 18:55:34 +000016unsigned ef4_mdio_id_oui(u32 id)
Ben Hutchings3f39a5e2009-02-27 13:07:15 +000017{
18 unsigned oui = 0;
19 int i;
20
21 /* The bits of the OUI are designated a..x, with a=0 and b variable.
22 * In the id register c is the MSB but the OUI is conventionally
23 * written as bytes h..a, p..i, x..q. Reorder the bits accordingly. */
24 for (i = 0; i < 22; ++i)
25 if (id & (1 << (i + 10)))
26 oui |= 1 << (i ^ 7);
27
28 return oui;
29}
30
Edward Cree5a6681e2016-11-28 18:55:34 +000031int ef4_mdio_reset_mmd(struct ef4_nic *port, int mmd,
Ben Hutchings8ceee662008-04-27 12:55:59 +010032 int spins, int spintime)
33{
34 u32 ctrl;
Ben Hutchings8ceee662008-04-27 12:55:59 +010035
36 /* Catch callers passing values in the wrong units (or just silly) */
Edward Cree5a6681e2016-11-28 18:55:34 +000037 EF4_BUG_ON_PARANOID(spins * spintime >= 5000);
Ben Hutchings8ceee662008-04-27 12:55:59 +010038
Edward Cree5a6681e2016-11-28 18:55:34 +000039 ef4_mdio_write(port, mmd, MDIO_CTRL1, MDIO_CTRL1_RESET);
Ben Hutchings8ceee662008-04-27 12:55:59 +010040 /* Wait for the reset bit to clear. */
41 do {
42 msleep(spintime);
Edward Cree5a6681e2016-11-28 18:55:34 +000043 ctrl = ef4_mdio_read(port, mmd, MDIO_CTRL1);
Ben Hutchings8ceee662008-04-27 12:55:59 +010044 spins--;
45
Ben Hutchings68e7f452009-04-29 08:05:08 +000046 } while (spins && (ctrl & MDIO_CTRL1_RESET));
Ben Hutchings8ceee662008-04-27 12:55:59 +010047
48 return spins ? spins : -ETIMEDOUT;
49}
50
Edward Cree5a6681e2016-11-28 18:55:34 +000051static int ef4_mdio_check_mmd(struct ef4_nic *efx, int mmd)
Ben Hutchings8ceee662008-04-27 12:55:59 +010052{
53 int status;
Ben Hutchings8ceee662008-04-27 12:55:59 +010054
Ben Hutchings04cc8ca2008-12-12 21:50:46 -080055 if (mmd != MDIO_MMD_AN) {
56 /* Read MMD STATUS2 to check it is responding. */
Edward Cree5a6681e2016-11-28 18:55:34 +000057 status = ef4_mdio_read(efx, mmd, MDIO_STAT2);
Ben Hutchings68e7f452009-04-29 08:05:08 +000058 if ((status & MDIO_STAT2_DEVPRST) != MDIO_STAT2_DEVPRST_VAL) {
Ben Hutchings62776d02010-06-23 11:30:07 +000059 netif_err(efx, hw, efx->net_dev,
60 "PHY MMD %d not responding.\n", mmd);
Ben Hutchings04cc8ca2008-12-12 21:50:46 -080061 return -EIO;
62 }
Ben Hutchings8ceee662008-04-27 12:55:59 +010063 }
64
Ben Hutchings8ceee662008-04-27 12:55:59 +010065 return 0;
66}
67
68/* This ought to be ridiculous overkill. We expect it to fail rarely */
69#define MDIO45_RESET_TIME 1000 /* ms */
70#define MDIO45_RESET_ITERS 100
71
Edward Cree5a6681e2016-11-28 18:55:34 +000072int ef4_mdio_wait_reset_mmds(struct ef4_nic *efx, unsigned int mmd_mask)
Ben Hutchings8ceee662008-04-27 12:55:59 +010073{
74 const int spintime = MDIO45_RESET_TIME / MDIO45_RESET_ITERS;
75 int tries = MDIO45_RESET_ITERS;
76 int rc = 0;
77 int in_reset;
78
79 while (tries) {
80 int mask = mmd_mask;
81 int mmd = 0;
82 int stat;
83 in_reset = 0;
84 while (mask) {
85 if (mask & 1) {
Edward Cree5a6681e2016-11-28 18:55:34 +000086 stat = ef4_mdio_read(efx, mmd, MDIO_CTRL1);
Ben Hutchings8ceee662008-04-27 12:55:59 +010087 if (stat < 0) {
Ben Hutchings62776d02010-06-23 11:30:07 +000088 netif_err(efx, hw, efx->net_dev,
89 "failed to read status of"
90 " MMD %d\n", mmd);
Ben Hutchings8ceee662008-04-27 12:55:59 +010091 return -EIO;
92 }
Ben Hutchings68e7f452009-04-29 08:05:08 +000093 if (stat & MDIO_CTRL1_RESET)
Ben Hutchings8ceee662008-04-27 12:55:59 +010094 in_reset |= (1 << mmd);
95 }
96 mask = mask >> 1;
97 mmd++;
98 }
99 if (!in_reset)
100 break;
101 tries--;
102 msleep(spintime);
103 }
104 if (in_reset != 0) {
Ben Hutchings62776d02010-06-23 11:30:07 +0000105 netif_err(efx, hw, efx->net_dev,
106 "not all MMDs came out of reset in time."
107 " MMDs still in reset: %x\n", in_reset);
Ben Hutchings8ceee662008-04-27 12:55:59 +0100108 rc = -ETIMEDOUT;
109 }
110 return rc;
111}
112
Edward Cree5a6681e2016-11-28 18:55:34 +0000113int ef4_mdio_check_mmds(struct ef4_nic *efx, unsigned int mmd_mask)
Ben Hutchings8ceee662008-04-27 12:55:59 +0100114{
Ben Hutchings68e7f452009-04-29 08:05:08 +0000115 int mmd = 0, probe_mmd, devs1, devs2;
Ben Hutchings27dd2ca2008-12-12 21:44:14 -0800116 u32 devices;
Ben Hutchings8ceee662008-04-27 12:55:59 +0100117
118 /* Historically we have probed the PHYXS to find out what devices are
119 * present,but that doesn't work so well if the PHYXS isn't expected
120 * to exist, if so just find the first item in the list supplied. */
Ben Hutchings68e7f452009-04-29 08:05:08 +0000121 probe_mmd = (mmd_mask & MDIO_DEVS_PHYXS) ? MDIO_MMD_PHYXS :
Ben Hutchings8ceee662008-04-27 12:55:59 +0100122 __ffs(mmd_mask);
Ben Hutchings8ceee662008-04-27 12:55:59 +0100123
124 /* Check all the expected MMDs are present */
Edward Cree5a6681e2016-11-28 18:55:34 +0000125 devs1 = ef4_mdio_read(efx, probe_mmd, MDIO_DEVS1);
126 devs2 = ef4_mdio_read(efx, probe_mmd, MDIO_DEVS2);
Ben Hutchings68e7f452009-04-29 08:05:08 +0000127 if (devs1 < 0 || devs2 < 0) {
Ben Hutchings62776d02010-06-23 11:30:07 +0000128 netif_err(efx, hw, efx->net_dev,
129 "failed to read devices present\n");
Ben Hutchings8ceee662008-04-27 12:55:59 +0100130 return -EIO;
131 }
Ben Hutchings68e7f452009-04-29 08:05:08 +0000132 devices = devs1 | (devs2 << 16);
Ben Hutchings8ceee662008-04-27 12:55:59 +0100133 if ((devices & mmd_mask) != mmd_mask) {
Ben Hutchings62776d02010-06-23 11:30:07 +0000134 netif_err(efx, hw, efx->net_dev,
135 "required MMDs not present: got %x, wanted %x\n",
136 devices, mmd_mask);
Ben Hutchings8ceee662008-04-27 12:55:59 +0100137 return -ENODEV;
138 }
Ben Hutchings62776d02010-06-23 11:30:07 +0000139 netif_vdbg(efx, hw, efx->net_dev, "Devices present: %x\n", devices);
Ben Hutchings8ceee662008-04-27 12:55:59 +0100140
141 /* Check all required MMDs are responding and happy. */
142 while (mmd_mask) {
Edward Cree5a6681e2016-11-28 18:55:34 +0000143 if ((mmd_mask & 1) && ef4_mdio_check_mmd(efx, mmd))
Ben Hutchingsa4611032011-02-24 23:59:15 +0000144 return -EIO;
Ben Hutchings8ceee662008-04-27 12:55:59 +0100145 mmd_mask = mmd_mask >> 1;
Ben Hutchings8ceee662008-04-27 12:55:59 +0100146 mmd++;
147 }
148
149 return 0;
150}
151
Edward Cree5a6681e2016-11-28 18:55:34 +0000152bool ef4_mdio_links_ok(struct ef4_nic *efx, unsigned int mmd_mask)
Ben Hutchings8ceee662008-04-27 12:55:59 +0100153{
Ben Hutchings3273c2e2008-05-07 13:36:19 +0100154 /* If the port is in loopback, then we should only consider a subset
155 * of mmd's */
156 if (LOOPBACK_INTERNAL(efx))
Ben Hutchingsdc8cfa52008-09-01 12:46:50 +0100157 return true;
Ben Hutchingse58f69f2009-11-29 15:08:41 +0000158 else if (LOOPBACK_MASK(efx) & LOOPBACKS_WS)
Ben Hutchingsdc8cfa52008-09-01 12:46:50 +0100159 return false;
Edward Cree5a6681e2016-11-28 18:55:34 +0000160 else if (ef4_phy_mode_disabled(efx->phy_mode))
Ben Hutchingsf8b87c12008-09-01 12:48:17 +0100161 return false;
Steve Hodgson67797762009-01-29 17:51:15 +0000162 else if (efx->loopback_mode == LOOPBACK_PHYXS)
Ben Hutchings68e7f452009-04-29 08:05:08 +0000163 mmd_mask &= ~(MDIO_DEVS_PHYXS |
164 MDIO_DEVS_PCS |
165 MDIO_DEVS_PMAPMD |
166 MDIO_DEVS_AN);
Steve Hodgson67797762009-01-29 17:51:15 +0000167 else if (efx->loopback_mode == LOOPBACK_PCS)
Ben Hutchings68e7f452009-04-29 08:05:08 +0000168 mmd_mask &= ~(MDIO_DEVS_PCS |
169 MDIO_DEVS_PMAPMD |
170 MDIO_DEVS_AN);
Ben Hutchings3273c2e2008-05-07 13:36:19 +0100171 else if (efx->loopback_mode == LOOPBACK_PMAPMD)
Ben Hutchings68e7f452009-04-29 08:05:08 +0000172 mmd_mask &= ~(MDIO_DEVS_PMAPMD |
173 MDIO_DEVS_AN);
Ben Hutchings3273c2e2008-05-07 13:36:19 +0100174
Ben Hutchings68e7f452009-04-29 08:05:08 +0000175 return mdio45_links_ok(&efx->mdio, mmd_mask);
Ben Hutchings8ceee662008-04-27 12:55:59 +0100176}
177
Edward Cree5a6681e2016-11-28 18:55:34 +0000178void ef4_mdio_transmit_disable(struct ef4_nic *efx)
Ben Hutchings3273c2e2008-05-07 13:36:19 +0100179{
Edward Cree5a6681e2016-11-28 18:55:34 +0000180 ef4_mdio_set_flag(efx, MDIO_MMD_PMAPMD,
Ben Hutchings68e7f452009-04-29 08:05:08 +0000181 MDIO_PMA_TXDIS, MDIO_PMD_TXDIS_GLOBAL,
182 efx->phy_mode & PHY_MODE_TX_DISABLED);
Ben Hutchings3273c2e2008-05-07 13:36:19 +0100183}
184
Edward Cree5a6681e2016-11-28 18:55:34 +0000185void ef4_mdio_phy_reconfigure(struct ef4_nic *efx)
Ben Hutchings3273c2e2008-05-07 13:36:19 +0100186{
Edward Cree5a6681e2016-11-28 18:55:34 +0000187 ef4_mdio_set_flag(efx, MDIO_MMD_PMAPMD,
Ben Hutchings68e7f452009-04-29 08:05:08 +0000188 MDIO_CTRL1, MDIO_PMA_CTRL1_LOOPBACK,
189 efx->loopback_mode == LOOPBACK_PMAPMD);
Edward Cree5a6681e2016-11-28 18:55:34 +0000190 ef4_mdio_set_flag(efx, MDIO_MMD_PCS,
Ben Hutchings68e7f452009-04-29 08:05:08 +0000191 MDIO_CTRL1, MDIO_PCS_CTRL1_LOOPBACK,
192 efx->loopback_mode == LOOPBACK_PCS);
Edward Cree5a6681e2016-11-28 18:55:34 +0000193 ef4_mdio_set_flag(efx, MDIO_MMD_PHYXS,
Ben Hutchings68e7f452009-04-29 08:05:08 +0000194 MDIO_CTRL1, MDIO_PHYXS_CTRL1_LOOPBACK,
Ben Hutchingse58f69f2009-11-29 15:08:41 +0000195 efx->loopback_mode == LOOPBACK_PHYXS_WS);
Ben Hutchings3273c2e2008-05-07 13:36:19 +0100196}
197
Edward Cree5a6681e2016-11-28 18:55:34 +0000198static void ef4_mdio_set_mmd_lpower(struct ef4_nic *efx,
Ben Hutchings68e7f452009-04-29 08:05:08 +0000199 int lpower, int mmd)
Ben Hutchings3e133c42008-11-04 20:34:56 +0000200{
Edward Cree5a6681e2016-11-28 18:55:34 +0000201 int stat = ef4_mdio_read(efx, mmd, MDIO_STAT1);
Ben Hutchings3e133c42008-11-04 20:34:56 +0000202
Ben Hutchings62776d02010-06-23 11:30:07 +0000203 netif_vdbg(efx, drv, efx->net_dev, "Setting low power mode for MMD %d to %d\n",
Ben Hutchings3e133c42008-11-04 20:34:56 +0000204 mmd, lpower);
205
Ben Hutchings68e7f452009-04-29 08:05:08 +0000206 if (stat & MDIO_STAT1_LPOWERABLE) {
Edward Cree5a6681e2016-11-28 18:55:34 +0000207 ef4_mdio_set_flag(efx, mmd, MDIO_CTRL1,
Ben Hutchings68e7f452009-04-29 08:05:08 +0000208 MDIO_CTRL1_LPOWER, lpower);
Ben Hutchings3e133c42008-11-04 20:34:56 +0000209 }
210}
211
Edward Cree5a6681e2016-11-28 18:55:34 +0000212void ef4_mdio_set_mmds_lpower(struct ef4_nic *efx,
Ben Hutchings68e7f452009-04-29 08:05:08 +0000213 int low_power, unsigned int mmd_mask)
Ben Hutchings3e133c42008-11-04 20:34:56 +0000214{
215 int mmd = 0;
Ben Hutchings68e7f452009-04-29 08:05:08 +0000216 mmd_mask &= ~MDIO_DEVS_AN;
Ben Hutchings3e133c42008-11-04 20:34:56 +0000217 while (mmd_mask) {
218 if (mmd_mask & 1)
Edward Cree5a6681e2016-11-28 18:55:34 +0000219 ef4_mdio_set_mmd_lpower(efx, low_power, mmd);
Ben Hutchings3e133c42008-11-04 20:34:56 +0000220 mmd_mask = (mmd_mask >> 1);
221 mmd++;
222 }
223}
224
Ben Hutchings8ceee662008-04-27 12:55:59 +0100225/**
Philippe Reynese938ed12017-01-01 19:02:46 +0100226 * ef4_mdio_set_link_ksettings - Set (some of) the PHY settings over MDIO.
Ben Hutchings8ceee662008-04-27 12:55:59 +0100227 * @efx: Efx NIC
Philippe Reynese938ed12017-01-01 19:02:46 +0100228 * @cmd: New settings
Ben Hutchings8ceee662008-04-27 12:55:59 +0100229 */
Philippe Reynese938ed12017-01-01 19:02:46 +0100230int ef4_mdio_set_link_ksettings(struct ef4_nic *efx,
231 const struct ethtool_link_ksettings *cmd)
Ben Hutchings8ceee662008-04-27 12:55:59 +0100232{
Philippe Reynese938ed12017-01-01 19:02:46 +0100233 struct ethtool_link_ksettings prev = {
234 .base.cmd = ETHTOOL_GLINKSETTINGS
235 };
236 u32 prev_advertising, advertising;
237 u32 prev_supported;
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800238
Philippe Reynese938ed12017-01-01 19:02:46 +0100239 efx->phy_op->get_link_ksettings(efx, &prev);
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800240
Philippe Reynese938ed12017-01-01 19:02:46 +0100241 ethtool_convert_link_mode_to_legacy_u32(&advertising,
242 cmd->link_modes.advertising);
243 ethtool_convert_link_mode_to_legacy_u32(&prev_advertising,
244 prev.link_modes.advertising);
245 ethtool_convert_link_mode_to_legacy_u32(&prev_supported,
246 prev.link_modes.supported);
247
248 if (advertising == prev_advertising &&
249 cmd->base.speed == prev.base.speed &&
250 cmd->base.duplex == prev.base.duplex &&
251 cmd->base.port == prev.base.port &&
252 cmd->base.autoneg == prev.base.autoneg)
Ben Hutchings8ceee662008-04-27 12:55:59 +0100253 return 0;
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800254
255 /* We can only change these settings for -T PHYs */
Philippe Reynese938ed12017-01-01 19:02:46 +0100256 if (prev.base.port != PORT_TP || cmd->base.port != PORT_TP)
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800257 return -EINVAL;
258
Ben Hutchingsaf4ad9b2009-01-29 17:59:37 +0000259 /* Check that PHY supports these settings */
Philippe Reynese938ed12017-01-01 19:02:46 +0100260 if (!cmd->base.autoneg ||
261 (advertising | SUPPORTED_Autoneg) & ~prev_supported)
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800262 return -EINVAL;
263
Philippe Reynese938ed12017-01-01 19:02:46 +0100264 ef4_link_set_advertising(efx, advertising | ADVERTISED_Autoneg);
Edward Cree5a6681e2016-11-28 18:55:34 +0000265 ef4_mdio_an_reconfigure(efx);
Ben Hutchingsd3245b22009-11-29 03:42:41 +0000266 return 0;
267}
268
269/**
Edward Cree5a6681e2016-11-28 18:55:34 +0000270 * ef4_mdio_an_reconfigure - Push advertising flags and restart autonegotiation
Ben Hutchingsd3245b22009-11-29 03:42:41 +0000271 * @efx: Efx NIC
272 */
Edward Cree5a6681e2016-11-28 18:55:34 +0000273void ef4_mdio_an_reconfigure(struct ef4_nic *efx)
Ben Hutchingsd3245b22009-11-29 03:42:41 +0000274{
Ben Hutchingsd3245b22009-11-29 03:42:41 +0000275 int reg;
276
277 WARN_ON(!(efx->mdio.mmds & MDIO_DEVS_AN));
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800278
Ben Hutchingsfc2b5e62009-10-23 08:33:27 +0000279 /* Set up the base page */
Ben Hutchings8fbca792010-09-22 10:00:11 +0000280 reg = ADVERTISE_CSMA | ADVERTISE_RESV;
Ben Hutchingsd3245b22009-11-29 03:42:41 +0000281 if (efx->link_advertising & ADVERTISED_Pause)
282 reg |= ADVERTISE_PAUSE_CAP;
283 if (efx->link_advertising & ADVERTISED_Asym_Pause)
284 reg |= ADVERTISE_PAUSE_ASYM;
Edward Cree5a6681e2016-11-28 18:55:34 +0000285 ef4_mdio_write(efx, MDIO_MMD_AN, MDIO_AN_ADVERTISE, reg);
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800286
Ben Hutchings8fbca792010-09-22 10:00:11 +0000287 /* Set up the (extended) next page */
288 efx->phy_op->set_npage_adv(efx, efx->link_advertising);
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800289
Ben Hutchingsfc2b5e62009-10-23 08:33:27 +0000290 /* Enable and restart AN */
Edward Cree5a6681e2016-11-28 18:55:34 +0000291 reg = ef4_mdio_read(efx, MDIO_MMD_AN, MDIO_CTRL1);
Ben Hutchings8fbca792010-09-22 10:00:11 +0000292 reg |= MDIO_AN_CTRL1_ENABLE | MDIO_AN_CTRL1_RESTART | MDIO_AN_CTRL1_XNP;
Edward Cree5a6681e2016-11-28 18:55:34 +0000293 ef4_mdio_write(efx, MDIO_MMD_AN, MDIO_CTRL1, reg);
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800294}
295
Edward Cree5a6681e2016-11-28 18:55:34 +0000296u8 ef4_mdio_get_pause(struct ef4_nic *efx)
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800297{
Edward Cree5a6681e2016-11-28 18:55:34 +0000298 BUILD_BUG_ON(EF4_FC_AUTO & (EF4_FC_RX | EF4_FC_TX));
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800299
Edward Cree5a6681e2016-11-28 18:55:34 +0000300 if (!(efx->wanted_fc & EF4_FC_AUTO))
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800301 return efx->wanted_fc;
Ben Hutchings18ea0242009-10-23 08:33:17 +0000302
303 WARN_ON(!(efx->mdio.mmds & MDIO_DEVS_AN));
304
305 return mii_resolve_flowctrl_fdx(
306 mii_advertise_flowctrl(efx->wanted_fc),
Edward Cree5a6681e2016-11-28 18:55:34 +0000307 ef4_mdio_read(efx, MDIO_MMD_AN, MDIO_AN_LPA));
Ben Hutchings8ceee662008-04-27 12:55:59 +0100308}
Ben Hutchings4f16c072010-02-03 09:30:50 +0000309
Edward Cree5a6681e2016-11-28 18:55:34 +0000310int ef4_mdio_test_alive(struct ef4_nic *efx)
Ben Hutchings4f16c072010-02-03 09:30:50 +0000311{
312 int rc;
313 int devad = __ffs(efx->mdio.mmds);
314 u16 physid1, physid2;
315
316 mutex_lock(&efx->mac_lock);
317
Edward Cree5a6681e2016-11-28 18:55:34 +0000318 physid1 = ef4_mdio_read(efx, devad, MDIO_DEVID1);
319 physid2 = ef4_mdio_read(efx, devad, MDIO_DEVID2);
Ben Hutchings4f16c072010-02-03 09:30:50 +0000320
321 if ((physid1 == 0x0000) || (physid1 == 0xffff) ||
322 (physid2 == 0x0000) || (physid2 == 0xffff)) {
Ben Hutchings62776d02010-06-23 11:30:07 +0000323 netif_err(efx, hw, efx->net_dev,
324 "no MDIO PHY present with ID %d\n", efx->mdio.prtad);
Ben Hutchings4f16c072010-02-03 09:30:50 +0000325 rc = -EINVAL;
326 } else {
Edward Cree5a6681e2016-11-28 18:55:34 +0000327 rc = ef4_mdio_check_mmds(efx, efx->mdio.mmds);
Ben Hutchings4f16c072010-02-03 09:30:50 +0000328 }
329
330 mutex_unlock(&efx->mac_lock);
331 return rc;
332}