blob: ee0713f03d01f77288b7b866acfc22937a175983 [file] [log] [blame]
Ben Hutchings8ceee662008-04-27 12:55:59 +01001/****************************************************************************
Ben Hutchingsf7a6d2c2013-08-29 23:32:48 +01002 * Driver for Solarflare network controllers and boards
Ben Hutchings0a6f40c2011-02-25 00:01:34 +00003 * Copyright 2006-2011 Solarflare Communications Inc.
Ben Hutchings8ceee662008-04-27 12:55:59 +01004 *
5 * This program is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 as published
7 * by the Free Software Foundation, incorporated herein by reference.
8 */
9/*
10 * Useful functions for working with MDIO clause 45 PHYs
11 */
12#include <linux/types.h>
13#include <linux/ethtool.h>
14#include <linux/delay.h>
15#include "net_driver.h"
16#include "mdio_10g.h"
Steve Hodgson8b9dc8d2009-01-29 17:49:09 +000017#include "workarounds.h"
Ben Hutchings8ceee662008-04-27 12:55:59 +010018
Edward Cree5a6681e2016-11-28 18:55:34 +000019unsigned ef4_mdio_id_oui(u32 id)
Ben Hutchings3f39a5e2009-02-27 13:07:15 +000020{
21 unsigned oui = 0;
22 int i;
23
24 /* The bits of the OUI are designated a..x, with a=0 and b variable.
25 * In the id register c is the MSB but the OUI is conventionally
26 * written as bytes h..a, p..i, x..q. Reorder the bits accordingly. */
27 for (i = 0; i < 22; ++i)
28 if (id & (1 << (i + 10)))
29 oui |= 1 << (i ^ 7);
30
31 return oui;
32}
33
Edward Cree5a6681e2016-11-28 18:55:34 +000034int ef4_mdio_reset_mmd(struct ef4_nic *port, int mmd,
Ben Hutchings8ceee662008-04-27 12:55:59 +010035 int spins, int spintime)
36{
37 u32 ctrl;
Ben Hutchings8ceee662008-04-27 12:55:59 +010038
39 /* Catch callers passing values in the wrong units (or just silly) */
Edward Cree5a6681e2016-11-28 18:55:34 +000040 EF4_BUG_ON_PARANOID(spins * spintime >= 5000);
Ben Hutchings8ceee662008-04-27 12:55:59 +010041
Edward Cree5a6681e2016-11-28 18:55:34 +000042 ef4_mdio_write(port, mmd, MDIO_CTRL1, MDIO_CTRL1_RESET);
Ben Hutchings8ceee662008-04-27 12:55:59 +010043 /* Wait for the reset bit to clear. */
44 do {
45 msleep(spintime);
Edward Cree5a6681e2016-11-28 18:55:34 +000046 ctrl = ef4_mdio_read(port, mmd, MDIO_CTRL1);
Ben Hutchings8ceee662008-04-27 12:55:59 +010047 spins--;
48
Ben Hutchings68e7f452009-04-29 08:05:08 +000049 } while (spins && (ctrl & MDIO_CTRL1_RESET));
Ben Hutchings8ceee662008-04-27 12:55:59 +010050
51 return spins ? spins : -ETIMEDOUT;
52}
53
Edward Cree5a6681e2016-11-28 18:55:34 +000054static int ef4_mdio_check_mmd(struct ef4_nic *efx, int mmd)
Ben Hutchings8ceee662008-04-27 12:55:59 +010055{
56 int status;
Ben Hutchings8ceee662008-04-27 12:55:59 +010057
Ben Hutchings04cc8ca2008-12-12 21:50:46 -080058 if (mmd != MDIO_MMD_AN) {
59 /* Read MMD STATUS2 to check it is responding. */
Edward Cree5a6681e2016-11-28 18:55:34 +000060 status = ef4_mdio_read(efx, mmd, MDIO_STAT2);
Ben Hutchings68e7f452009-04-29 08:05:08 +000061 if ((status & MDIO_STAT2_DEVPRST) != MDIO_STAT2_DEVPRST_VAL) {
Ben Hutchings62776d02010-06-23 11:30:07 +000062 netif_err(efx, hw, efx->net_dev,
63 "PHY MMD %d not responding.\n", mmd);
Ben Hutchings04cc8ca2008-12-12 21:50:46 -080064 return -EIO;
65 }
Ben Hutchings8ceee662008-04-27 12:55:59 +010066 }
67
Ben Hutchings8ceee662008-04-27 12:55:59 +010068 return 0;
69}
70
71/* This ought to be ridiculous overkill. We expect it to fail rarely */
72#define MDIO45_RESET_TIME 1000 /* ms */
73#define MDIO45_RESET_ITERS 100
74
Edward Cree5a6681e2016-11-28 18:55:34 +000075int ef4_mdio_wait_reset_mmds(struct ef4_nic *efx, unsigned int mmd_mask)
Ben Hutchings8ceee662008-04-27 12:55:59 +010076{
77 const int spintime = MDIO45_RESET_TIME / MDIO45_RESET_ITERS;
78 int tries = MDIO45_RESET_ITERS;
79 int rc = 0;
80 int in_reset;
81
82 while (tries) {
83 int mask = mmd_mask;
84 int mmd = 0;
85 int stat;
86 in_reset = 0;
87 while (mask) {
88 if (mask & 1) {
Edward Cree5a6681e2016-11-28 18:55:34 +000089 stat = ef4_mdio_read(efx, mmd, MDIO_CTRL1);
Ben Hutchings8ceee662008-04-27 12:55:59 +010090 if (stat < 0) {
Ben Hutchings62776d02010-06-23 11:30:07 +000091 netif_err(efx, hw, efx->net_dev,
92 "failed to read status of"
93 " MMD %d\n", mmd);
Ben Hutchings8ceee662008-04-27 12:55:59 +010094 return -EIO;
95 }
Ben Hutchings68e7f452009-04-29 08:05:08 +000096 if (stat & MDIO_CTRL1_RESET)
Ben Hutchings8ceee662008-04-27 12:55:59 +010097 in_reset |= (1 << mmd);
98 }
99 mask = mask >> 1;
100 mmd++;
101 }
102 if (!in_reset)
103 break;
104 tries--;
105 msleep(spintime);
106 }
107 if (in_reset != 0) {
Ben Hutchings62776d02010-06-23 11:30:07 +0000108 netif_err(efx, hw, efx->net_dev,
109 "not all MMDs came out of reset in time."
110 " MMDs still in reset: %x\n", in_reset);
Ben Hutchings8ceee662008-04-27 12:55:59 +0100111 rc = -ETIMEDOUT;
112 }
113 return rc;
114}
115
Edward Cree5a6681e2016-11-28 18:55:34 +0000116int ef4_mdio_check_mmds(struct ef4_nic *efx, unsigned int mmd_mask)
Ben Hutchings8ceee662008-04-27 12:55:59 +0100117{
Ben Hutchings68e7f452009-04-29 08:05:08 +0000118 int mmd = 0, probe_mmd, devs1, devs2;
Ben Hutchings27dd2ca2008-12-12 21:44:14 -0800119 u32 devices;
Ben Hutchings8ceee662008-04-27 12:55:59 +0100120
121 /* Historically we have probed the PHYXS to find out what devices are
122 * present,but that doesn't work so well if the PHYXS isn't expected
123 * to exist, if so just find the first item in the list supplied. */
Ben Hutchings68e7f452009-04-29 08:05:08 +0000124 probe_mmd = (mmd_mask & MDIO_DEVS_PHYXS) ? MDIO_MMD_PHYXS :
Ben Hutchings8ceee662008-04-27 12:55:59 +0100125 __ffs(mmd_mask);
Ben Hutchings8ceee662008-04-27 12:55:59 +0100126
127 /* Check all the expected MMDs are present */
Edward Cree5a6681e2016-11-28 18:55:34 +0000128 devs1 = ef4_mdio_read(efx, probe_mmd, MDIO_DEVS1);
129 devs2 = ef4_mdio_read(efx, probe_mmd, MDIO_DEVS2);
Ben Hutchings68e7f452009-04-29 08:05:08 +0000130 if (devs1 < 0 || devs2 < 0) {
Ben Hutchings62776d02010-06-23 11:30:07 +0000131 netif_err(efx, hw, efx->net_dev,
132 "failed to read devices present\n");
Ben Hutchings8ceee662008-04-27 12:55:59 +0100133 return -EIO;
134 }
Ben Hutchings68e7f452009-04-29 08:05:08 +0000135 devices = devs1 | (devs2 << 16);
Ben Hutchings8ceee662008-04-27 12:55:59 +0100136 if ((devices & mmd_mask) != mmd_mask) {
Ben Hutchings62776d02010-06-23 11:30:07 +0000137 netif_err(efx, hw, efx->net_dev,
138 "required MMDs not present: got %x, wanted %x\n",
139 devices, mmd_mask);
Ben Hutchings8ceee662008-04-27 12:55:59 +0100140 return -ENODEV;
141 }
Ben Hutchings62776d02010-06-23 11:30:07 +0000142 netif_vdbg(efx, hw, efx->net_dev, "Devices present: %x\n", devices);
Ben Hutchings8ceee662008-04-27 12:55:59 +0100143
144 /* Check all required MMDs are responding and happy. */
145 while (mmd_mask) {
Edward Cree5a6681e2016-11-28 18:55:34 +0000146 if ((mmd_mask & 1) && ef4_mdio_check_mmd(efx, mmd))
Ben Hutchingsa4611032011-02-24 23:59:15 +0000147 return -EIO;
Ben Hutchings8ceee662008-04-27 12:55:59 +0100148 mmd_mask = mmd_mask >> 1;
Ben Hutchings8ceee662008-04-27 12:55:59 +0100149 mmd++;
150 }
151
152 return 0;
153}
154
Edward Cree5a6681e2016-11-28 18:55:34 +0000155bool ef4_mdio_links_ok(struct ef4_nic *efx, unsigned int mmd_mask)
Ben Hutchings8ceee662008-04-27 12:55:59 +0100156{
Ben Hutchings3273c2e2008-05-07 13:36:19 +0100157 /* If the port is in loopback, then we should only consider a subset
158 * of mmd's */
159 if (LOOPBACK_INTERNAL(efx))
Ben Hutchingsdc8cfa52008-09-01 12:46:50 +0100160 return true;
Ben Hutchingse58f69f2009-11-29 15:08:41 +0000161 else if (LOOPBACK_MASK(efx) & LOOPBACKS_WS)
Ben Hutchingsdc8cfa52008-09-01 12:46:50 +0100162 return false;
Edward Cree5a6681e2016-11-28 18:55:34 +0000163 else if (ef4_phy_mode_disabled(efx->phy_mode))
Ben Hutchingsf8b87c12008-09-01 12:48:17 +0100164 return false;
Steve Hodgson67797762009-01-29 17:51:15 +0000165 else if (efx->loopback_mode == LOOPBACK_PHYXS)
Ben Hutchings68e7f452009-04-29 08:05:08 +0000166 mmd_mask &= ~(MDIO_DEVS_PHYXS |
167 MDIO_DEVS_PCS |
168 MDIO_DEVS_PMAPMD |
169 MDIO_DEVS_AN);
Steve Hodgson67797762009-01-29 17:51:15 +0000170 else if (efx->loopback_mode == LOOPBACK_PCS)
Ben Hutchings68e7f452009-04-29 08:05:08 +0000171 mmd_mask &= ~(MDIO_DEVS_PCS |
172 MDIO_DEVS_PMAPMD |
173 MDIO_DEVS_AN);
Ben Hutchings3273c2e2008-05-07 13:36:19 +0100174 else if (efx->loopback_mode == LOOPBACK_PMAPMD)
Ben Hutchings68e7f452009-04-29 08:05:08 +0000175 mmd_mask &= ~(MDIO_DEVS_PMAPMD |
176 MDIO_DEVS_AN);
Ben Hutchings3273c2e2008-05-07 13:36:19 +0100177
Ben Hutchings68e7f452009-04-29 08:05:08 +0000178 return mdio45_links_ok(&efx->mdio, mmd_mask);
Ben Hutchings8ceee662008-04-27 12:55:59 +0100179}
180
Edward Cree5a6681e2016-11-28 18:55:34 +0000181void ef4_mdio_transmit_disable(struct ef4_nic *efx)
Ben Hutchings3273c2e2008-05-07 13:36:19 +0100182{
Edward Cree5a6681e2016-11-28 18:55:34 +0000183 ef4_mdio_set_flag(efx, MDIO_MMD_PMAPMD,
Ben Hutchings68e7f452009-04-29 08:05:08 +0000184 MDIO_PMA_TXDIS, MDIO_PMD_TXDIS_GLOBAL,
185 efx->phy_mode & PHY_MODE_TX_DISABLED);
Ben Hutchings3273c2e2008-05-07 13:36:19 +0100186}
187
Edward Cree5a6681e2016-11-28 18:55:34 +0000188void ef4_mdio_phy_reconfigure(struct ef4_nic *efx)
Ben Hutchings3273c2e2008-05-07 13:36:19 +0100189{
Edward Cree5a6681e2016-11-28 18:55:34 +0000190 ef4_mdio_set_flag(efx, MDIO_MMD_PMAPMD,
Ben Hutchings68e7f452009-04-29 08:05:08 +0000191 MDIO_CTRL1, MDIO_PMA_CTRL1_LOOPBACK,
192 efx->loopback_mode == LOOPBACK_PMAPMD);
Edward Cree5a6681e2016-11-28 18:55:34 +0000193 ef4_mdio_set_flag(efx, MDIO_MMD_PCS,
Ben Hutchings68e7f452009-04-29 08:05:08 +0000194 MDIO_CTRL1, MDIO_PCS_CTRL1_LOOPBACK,
195 efx->loopback_mode == LOOPBACK_PCS);
Edward Cree5a6681e2016-11-28 18:55:34 +0000196 ef4_mdio_set_flag(efx, MDIO_MMD_PHYXS,
Ben Hutchings68e7f452009-04-29 08:05:08 +0000197 MDIO_CTRL1, MDIO_PHYXS_CTRL1_LOOPBACK,
Ben Hutchingse58f69f2009-11-29 15:08:41 +0000198 efx->loopback_mode == LOOPBACK_PHYXS_WS);
Ben Hutchings3273c2e2008-05-07 13:36:19 +0100199}
200
Edward Cree5a6681e2016-11-28 18:55:34 +0000201static void ef4_mdio_set_mmd_lpower(struct ef4_nic *efx,
Ben Hutchings68e7f452009-04-29 08:05:08 +0000202 int lpower, int mmd)
Ben Hutchings3e133c42008-11-04 20:34:56 +0000203{
Edward Cree5a6681e2016-11-28 18:55:34 +0000204 int stat = ef4_mdio_read(efx, mmd, MDIO_STAT1);
Ben Hutchings3e133c42008-11-04 20:34:56 +0000205
Ben Hutchings62776d02010-06-23 11:30:07 +0000206 netif_vdbg(efx, drv, efx->net_dev, "Setting low power mode for MMD %d to %d\n",
Ben Hutchings3e133c42008-11-04 20:34:56 +0000207 mmd, lpower);
208
Ben Hutchings68e7f452009-04-29 08:05:08 +0000209 if (stat & MDIO_STAT1_LPOWERABLE) {
Edward Cree5a6681e2016-11-28 18:55:34 +0000210 ef4_mdio_set_flag(efx, mmd, MDIO_CTRL1,
Ben Hutchings68e7f452009-04-29 08:05:08 +0000211 MDIO_CTRL1_LPOWER, lpower);
Ben Hutchings3e133c42008-11-04 20:34:56 +0000212 }
213}
214
Edward Cree5a6681e2016-11-28 18:55:34 +0000215void ef4_mdio_set_mmds_lpower(struct ef4_nic *efx,
Ben Hutchings68e7f452009-04-29 08:05:08 +0000216 int low_power, unsigned int mmd_mask)
Ben Hutchings3e133c42008-11-04 20:34:56 +0000217{
218 int mmd = 0;
Ben Hutchings68e7f452009-04-29 08:05:08 +0000219 mmd_mask &= ~MDIO_DEVS_AN;
Ben Hutchings3e133c42008-11-04 20:34:56 +0000220 while (mmd_mask) {
221 if (mmd_mask & 1)
Edward Cree5a6681e2016-11-28 18:55:34 +0000222 ef4_mdio_set_mmd_lpower(efx, low_power, mmd);
Ben Hutchings3e133c42008-11-04 20:34:56 +0000223 mmd_mask = (mmd_mask >> 1);
224 mmd++;
225 }
226}
227
Ben Hutchings8ceee662008-04-27 12:55:59 +0100228/**
Philippe Reynese938ed12017-01-01 19:02:46 +0100229 * ef4_mdio_set_link_ksettings - Set (some of) the PHY settings over MDIO.
Ben Hutchings8ceee662008-04-27 12:55:59 +0100230 * @efx: Efx NIC
Philippe Reynese938ed12017-01-01 19:02:46 +0100231 * @cmd: New settings
Ben Hutchings8ceee662008-04-27 12:55:59 +0100232 */
Philippe Reynese938ed12017-01-01 19:02:46 +0100233int ef4_mdio_set_link_ksettings(struct ef4_nic *efx,
234 const struct ethtool_link_ksettings *cmd)
Ben Hutchings8ceee662008-04-27 12:55:59 +0100235{
Philippe Reynese938ed12017-01-01 19:02:46 +0100236 struct ethtool_link_ksettings prev = {
237 .base.cmd = ETHTOOL_GLINKSETTINGS
238 };
239 u32 prev_advertising, advertising;
240 u32 prev_supported;
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800241
Philippe Reynese938ed12017-01-01 19:02:46 +0100242 efx->phy_op->get_link_ksettings(efx, &prev);
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800243
Philippe Reynese938ed12017-01-01 19:02:46 +0100244 ethtool_convert_link_mode_to_legacy_u32(&advertising,
245 cmd->link_modes.advertising);
246 ethtool_convert_link_mode_to_legacy_u32(&prev_advertising,
247 prev.link_modes.advertising);
248 ethtool_convert_link_mode_to_legacy_u32(&prev_supported,
249 prev.link_modes.supported);
250
251 if (advertising == prev_advertising &&
252 cmd->base.speed == prev.base.speed &&
253 cmd->base.duplex == prev.base.duplex &&
254 cmd->base.port == prev.base.port &&
255 cmd->base.autoneg == prev.base.autoneg)
Ben Hutchings8ceee662008-04-27 12:55:59 +0100256 return 0;
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800257
258 /* We can only change these settings for -T PHYs */
Philippe Reynese938ed12017-01-01 19:02:46 +0100259 if (prev.base.port != PORT_TP || cmd->base.port != PORT_TP)
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800260 return -EINVAL;
261
Ben Hutchingsaf4ad9b2009-01-29 17:59:37 +0000262 /* Check that PHY supports these settings */
Philippe Reynese938ed12017-01-01 19:02:46 +0100263 if (!cmd->base.autoneg ||
264 (advertising | SUPPORTED_Autoneg) & ~prev_supported)
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800265 return -EINVAL;
266
Philippe Reynese938ed12017-01-01 19:02:46 +0100267 ef4_link_set_advertising(efx, advertising | ADVERTISED_Autoneg);
Edward Cree5a6681e2016-11-28 18:55:34 +0000268 ef4_mdio_an_reconfigure(efx);
Ben Hutchingsd3245b22009-11-29 03:42:41 +0000269 return 0;
270}
271
272/**
Edward Cree5a6681e2016-11-28 18:55:34 +0000273 * ef4_mdio_an_reconfigure - Push advertising flags and restart autonegotiation
Ben Hutchingsd3245b22009-11-29 03:42:41 +0000274 * @efx: Efx NIC
275 */
Edward Cree5a6681e2016-11-28 18:55:34 +0000276void ef4_mdio_an_reconfigure(struct ef4_nic *efx)
Ben Hutchingsd3245b22009-11-29 03:42:41 +0000277{
Ben Hutchingsd3245b22009-11-29 03:42:41 +0000278 int reg;
279
280 WARN_ON(!(efx->mdio.mmds & MDIO_DEVS_AN));
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800281
Ben Hutchingsfc2b5e62009-10-23 08:33:27 +0000282 /* Set up the base page */
Ben Hutchings8fbca792010-09-22 10:00:11 +0000283 reg = ADVERTISE_CSMA | ADVERTISE_RESV;
Ben Hutchingsd3245b22009-11-29 03:42:41 +0000284 if (efx->link_advertising & ADVERTISED_Pause)
285 reg |= ADVERTISE_PAUSE_CAP;
286 if (efx->link_advertising & ADVERTISED_Asym_Pause)
287 reg |= ADVERTISE_PAUSE_ASYM;
Edward Cree5a6681e2016-11-28 18:55:34 +0000288 ef4_mdio_write(efx, MDIO_MMD_AN, MDIO_AN_ADVERTISE, reg);
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800289
Ben Hutchings8fbca792010-09-22 10:00:11 +0000290 /* Set up the (extended) next page */
291 efx->phy_op->set_npage_adv(efx, efx->link_advertising);
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800292
Ben Hutchingsfc2b5e62009-10-23 08:33:27 +0000293 /* Enable and restart AN */
Edward Cree5a6681e2016-11-28 18:55:34 +0000294 reg = ef4_mdio_read(efx, MDIO_MMD_AN, MDIO_CTRL1);
Ben Hutchings8fbca792010-09-22 10:00:11 +0000295 reg |= MDIO_AN_CTRL1_ENABLE | MDIO_AN_CTRL1_RESTART | MDIO_AN_CTRL1_XNP;
Edward Cree5a6681e2016-11-28 18:55:34 +0000296 ef4_mdio_write(efx, MDIO_MMD_AN, MDIO_CTRL1, reg);
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800297}
298
Edward Cree5a6681e2016-11-28 18:55:34 +0000299u8 ef4_mdio_get_pause(struct ef4_nic *efx)
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800300{
Edward Cree5a6681e2016-11-28 18:55:34 +0000301 BUILD_BUG_ON(EF4_FC_AUTO & (EF4_FC_RX | EF4_FC_TX));
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800302
Edward Cree5a6681e2016-11-28 18:55:34 +0000303 if (!(efx->wanted_fc & EF4_FC_AUTO))
Ben Hutchings04cc8ca2008-12-12 21:50:46 -0800304 return efx->wanted_fc;
Ben Hutchings18ea0242009-10-23 08:33:17 +0000305
306 WARN_ON(!(efx->mdio.mmds & MDIO_DEVS_AN));
307
308 return mii_resolve_flowctrl_fdx(
309 mii_advertise_flowctrl(efx->wanted_fc),
Edward Cree5a6681e2016-11-28 18:55:34 +0000310 ef4_mdio_read(efx, MDIO_MMD_AN, MDIO_AN_LPA));
Ben Hutchings8ceee662008-04-27 12:55:59 +0100311}
Ben Hutchings4f16c072010-02-03 09:30:50 +0000312
Edward Cree5a6681e2016-11-28 18:55:34 +0000313int ef4_mdio_test_alive(struct ef4_nic *efx)
Ben Hutchings4f16c072010-02-03 09:30:50 +0000314{
315 int rc;
316 int devad = __ffs(efx->mdio.mmds);
317 u16 physid1, physid2;
318
319 mutex_lock(&efx->mac_lock);
320
Edward Cree5a6681e2016-11-28 18:55:34 +0000321 physid1 = ef4_mdio_read(efx, devad, MDIO_DEVID1);
322 physid2 = ef4_mdio_read(efx, devad, MDIO_DEVID2);
Ben Hutchings4f16c072010-02-03 09:30:50 +0000323
324 if ((physid1 == 0x0000) || (physid1 == 0xffff) ||
325 (physid2 == 0x0000) || (physid2 == 0xffff)) {
Ben Hutchings62776d02010-06-23 11:30:07 +0000326 netif_err(efx, hw, efx->net_dev,
327 "no MDIO PHY present with ID %d\n", efx->mdio.prtad);
Ben Hutchings4f16c072010-02-03 09:30:50 +0000328 rc = -EINVAL;
329 } else {
Edward Cree5a6681e2016-11-28 18:55:34 +0000330 rc = ef4_mdio_check_mmds(efx, efx->mdio.mmds);
Ben Hutchings4f16c072010-02-03 09:30:50 +0000331 }
332
333 mutex_unlock(&efx->mac_lock);
334 return rc;
335}