blob: 052a83e2d4891a045369c4886a2bc7e32766652c [file] [log] [blame]
Laurent Pinchart26e0ca22013-06-04 11:22:30 -03001/*
2 * vsp1_wpf.c -- R-Car VSP1 Write Pixel Formatter
3 *
Laurent Pinchart8a1edc52014-02-06 14:42:31 -03004 * Copyright (C) 2013-2014 Renesas Electronics Corporation
Laurent Pinchart26e0ca22013-06-04 11:22:30 -03005 *
6 * Contact: Laurent Pinchart (laurent.pinchart@ideasonboard.com)
7 *
8 * This program is free software; you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation; either version 2 of the License, or
11 * (at your option) any later version.
12 */
13
14#include <linux/device.h>
15
16#include <media/v4l2-subdev.h>
17
18#include "vsp1.h"
Laurent Pinchartef9621b2015-11-14 22:27:52 -020019#include "vsp1_dl.h"
Laurent Pincharta0cdac52016-01-17 19:53:56 -020020#include "vsp1_pipe.h"
Laurent Pinchart26e0ca22013-06-04 11:22:30 -030021#include "vsp1_rwpf.h"
22#include "vsp1_video.h"
23
Laurent Pinchart0d268dc2016-03-25 06:51:06 -030024#define WPF_GEN2_MAX_WIDTH 2048U
25#define WPF_GEN2_MAX_HEIGHT 2048U
26#define WPF_GEN3_MAX_WIDTH 8190U
27#define WPF_GEN3_MAX_HEIGHT 8190U
Laurent Pinchart26e0ca22013-06-04 11:22:30 -030028
29/* -----------------------------------------------------------------------------
30 * Device Access
31 */
32
Laurent Pinchart5e8dbbf2015-11-22 20:29:25 -020033static inline void vsp1_wpf_write(struct vsp1_rwpf *wpf,
34 struct vsp1_dl_list *dl, u32 reg, u32 data)
Laurent Pinchart26e0ca22013-06-04 11:22:30 -030035{
Laurent Pinchart5e8dbbf2015-11-22 20:29:25 -020036 vsp1_dl_list_write(dl, reg + wpf->entity.index * VI6_WPF_OFFSET, data);
Laurent Pinchart26e0ca22013-06-04 11:22:30 -030037}
38
39/* -----------------------------------------------------------------------------
Laurent Pinchart894dde52016-05-26 05:14:22 -030040 * Controls
41 */
42
43enum wpf_flip_ctrl {
44 WPF_CTRL_VFLIP = 0,
45 WPF_CTRL_HFLIP = 1,
46 WPF_CTRL_MAX,
47};
48
49static int vsp1_wpf_s_ctrl(struct v4l2_ctrl *ctrl)
50{
51 struct vsp1_rwpf *wpf =
52 container_of(ctrl->handler, struct vsp1_rwpf, ctrls);
53 unsigned int i;
54 u32 flip = 0;
55
56 switch (ctrl->id) {
57 case V4L2_CID_HFLIP:
58 case V4L2_CID_VFLIP:
59 for (i = 0; i < WPF_CTRL_MAX; ++i) {
60 if (wpf->flip.ctrls[i])
61 flip |= wpf->flip.ctrls[i]->val ? BIT(i) : 0;
62 }
63
64 spin_lock_irq(&wpf->flip.lock);
65 wpf->flip.pending = flip;
66 spin_unlock_irq(&wpf->flip.lock);
67 break;
68
69 default:
70 return -EINVAL;
71 }
72
73 return 0;
74}
75
76static const struct v4l2_ctrl_ops vsp1_wpf_ctrl_ops = {
77 .s_ctrl = vsp1_wpf_s_ctrl,
78};
79
80static int wpf_init_controls(struct vsp1_rwpf *wpf)
81{
82 struct vsp1_device *vsp1 = wpf->entity.vsp1;
83 unsigned int num_flip_ctrls;
84
85 spin_lock_init(&wpf->flip.lock);
86
87 if (wpf->entity.index != 0) {
88 /* Only WPF0 supports flipping. */
89 num_flip_ctrls = 0;
90 } else if (vsp1->info->features & VSP1_HAS_WPF_HFLIP) {
91 /* When horizontal flip is supported the WPF implements two
92 * controls (horizontal flip and vertical flip).
93 */
94 num_flip_ctrls = 2;
95 } else if (vsp1->info->features & VSP1_HAS_WPF_VFLIP) {
96 /* When only vertical flip is supported the WPF implements a
97 * single control (vertical flip).
98 */
99 num_flip_ctrls = 1;
100 } else {
101 /* Otherwise flipping is not supported. */
102 num_flip_ctrls = 0;
103 }
104
105 vsp1_rwpf_init_ctrls(wpf, num_flip_ctrls);
106
107 if (num_flip_ctrls >= 1) {
108 wpf->flip.ctrls[WPF_CTRL_VFLIP] =
109 v4l2_ctrl_new_std(&wpf->ctrls, &vsp1_wpf_ctrl_ops,
110 V4L2_CID_VFLIP, 0, 1, 1, 0);
111 }
112
113 if (num_flip_ctrls == 2) {
114 wpf->flip.ctrls[WPF_CTRL_HFLIP] =
115 v4l2_ctrl_new_std(&wpf->ctrls, &vsp1_wpf_ctrl_ops,
116 V4L2_CID_HFLIP, 0, 1, 1, 0);
117
118 v4l2_ctrl_cluster(2, wpf->flip.ctrls);
119 }
120
121 if (wpf->ctrls.error) {
122 dev_err(vsp1->dev, "wpf%u: failed to initialize controls\n",
123 wpf->entity.index);
124 return wpf->ctrls.error;
125 }
126
127 return 0;
128}
129
130/* -----------------------------------------------------------------------------
Laurent Pinchart26e0ca22013-06-04 11:22:30 -0300131 * V4L2 Subdevice Core Operations
132 */
133
134static int wpf_s_stream(struct v4l2_subdev *subdev, int enable)
135{
136 struct vsp1_rwpf *wpf = to_rwpf(subdev);
Laurent Pinchart26e0ca22013-06-04 11:22:30 -0300137 struct vsp1_device *vsp1 = wpf->entity.vsp1;
Laurent Pinchart7578c202014-05-21 19:00:05 -0300138
Laurent Pinchart7b905f02015-11-17 13:10:26 -0200139 if (enable)
Laurent Pinchart26e0ca22013-06-04 11:22:30 -0300140 return 0;
Laurent Pinchart26e0ca22013-06-04 11:22:30 -0300141
Laurent Pinchart7b905f02015-11-17 13:10:26 -0200142 /* Write to registers directly when stopping the stream as there will be
143 * no pipeline run to apply the display list.
Laurent Pinchart629bb6d2013-07-10 18:03:46 -0300144 */
Laurent Pinchart7b905f02015-11-17 13:10:26 -0200145 vsp1_write(vsp1, VI6_WPF_IRQ_ENB(wpf->entity.index), 0);
146 vsp1_write(vsp1, wpf->entity.index * VI6_WPF_OFFSET +
147 VI6_WPF_SRCRPF, 0);
Laurent Pinchart26e0ca22013-06-04 11:22:30 -0300148
149 return 0;
150}
151
152/* -----------------------------------------------------------------------------
153 * V4L2 Subdevice Operations
154 */
155
Laurent Pincharteb9163d2016-06-17 21:11:26 -0300156static const struct v4l2_subdev_video_ops wpf_video_ops = {
Laurent Pinchart26e0ca22013-06-04 11:22:30 -0300157 .s_stream = wpf_s_stream,
158};
159
Laurent Pincharteb9163d2016-06-17 21:11:26 -0300160static const struct v4l2_subdev_ops wpf_ops = {
Laurent Pinchart26e0ca22013-06-04 11:22:30 -0300161 .video = &wpf_video_ops,
Laurent Pinchartc6c8efb2015-11-22 13:37:45 -0200162 .pad = &vsp1_rwpf_pad_ops,
Laurent Pinchart26e0ca22013-06-04 11:22:30 -0300163};
164
165/* -----------------------------------------------------------------------------
Laurent Pinchart52434532015-11-17 12:23:23 -0200166 * VSP1 Entity Operations
Laurent Pinchart26e0ca22013-06-04 11:22:30 -0300167 */
168
Laurent Pinchart52434532015-11-17 12:23:23 -0200169static void vsp1_wpf_destroy(struct vsp1_entity *entity)
Laurent Pinchart26e0ca22013-06-04 11:22:30 -0300170{
Laurent Pinchart52434532015-11-17 12:23:23 -0200171 struct vsp1_rwpf *wpf = entity_to_rwpf(entity);
172
173 vsp1_dlm_destroy(wpf->dlm);
174}
175
Laurent Pinchart83dd0192016-01-14 14:17:32 -0200176static void wpf_configure(struct vsp1_entity *entity,
177 struct vsp1_pipeline *pipe,
Laurent Pinchartd21fbbb2016-09-11 19:39:30 -0300178 struct vsp1_dl_list *dl,
179 enum vsp1_entity_params params)
Laurent Pinchart7b905f02015-11-17 13:10:26 -0200180{
Laurent Pinchart7b905f02015-11-17 13:10:26 -0200181 struct vsp1_rwpf *wpf = to_rwpf(&entity->subdev);
182 struct vsp1_device *vsp1 = wpf->entity.vsp1;
183 const struct v4l2_mbus_framefmt *source_format;
184 const struct v4l2_mbus_framefmt *sink_format;
Laurent Pinchart7b905f02015-11-17 13:10:26 -0200185 unsigned int i;
186 u32 outfmt = 0;
187 u32 srcrpf = 0;
188
Laurent Pinchartd21fbbb2016-09-11 19:39:30 -0300189 if (params == VSP1_ENTITY_PARAMS_RUNTIME) {
Laurent Pinchart894dde52016-05-26 05:14:22 -0300190 const unsigned int mask = BIT(WPF_CTRL_VFLIP)
191 | BIT(WPF_CTRL_HFLIP);
Laurent Pinchart225c2922016-09-13 20:19:29 -0300192 unsigned long flags;
Laurent Pinchart894dde52016-05-26 05:14:22 -0300193
Laurent Pinchart225c2922016-09-13 20:19:29 -0300194 spin_lock_irqsave(&wpf->flip.lock, flags);
Laurent Pinchart894dde52016-05-26 05:14:22 -0300195 wpf->flip.active = (wpf->flip.active & ~mask)
196 | (wpf->flip.pending & mask);
Laurent Pinchart225c2922016-09-13 20:19:29 -0300197 spin_unlock_irqrestore(&wpf->flip.lock, flags);
Laurent Pinchart894dde52016-05-26 05:14:22 -0300198
199 outfmt = (wpf->alpha << VI6_WPF_OUTFMT_PDV_SHIFT) | wpf->outfmt;
200
201 if (wpf->flip.active & BIT(WPF_CTRL_VFLIP))
202 outfmt |= VI6_WPF_OUTFMT_FLP;
203 if (wpf->flip.active & BIT(WPF_CTRL_HFLIP))
204 outfmt |= VI6_WPF_OUTFMT_HFLP;
205
206 vsp1_wpf_write(wpf, dl, VI6_WPF_OUTFMT, outfmt);
Laurent Pinchartfc845e52016-06-11 04:07:56 -0300207 return;
Laurent Pinchartd05a3312016-06-20 05:04:38 -0300208 }
Laurent Pinchartfc845e52016-06-11 04:07:56 -0300209
Laurent Pinchart7b905f02015-11-17 13:10:26 -0200210 sink_format = vsp1_entity_get_pad_format(&wpf->entity,
211 wpf->entity.config,
212 RWPF_PAD_SINK);
213 source_format = vsp1_entity_get_pad_format(&wpf->entity,
214 wpf->entity.config,
215 RWPF_PAD_SOURCE);
216
Laurent Pinchart8ddf3782016-09-12 09:50:13 -0300217 if (params == VSP1_ENTITY_PARAMS_PARTITION) {
218 const struct v4l2_pix_format_mplane *format = &wpf->format;
Laurent Pinchart34253822017-02-12 20:58:20 -0200219 const struct vsp1_format_info *fmtinfo = wpf->fmtinfo;
Laurent Pinchart8ddf3782016-09-12 09:50:13 -0300220 struct vsp1_rwpf_memory mem = wpf->mem;
221 unsigned int flip = wpf->flip.active;
222 unsigned int width = source_format->width;
223 unsigned int height = source_format->height;
224 unsigned int offset;
Laurent Pinchartb61bead2016-09-11 22:41:06 -0300225
Mauro Carvalho Chehabb6187392016-09-19 15:18:01 -0300226 /*
227 * Cropping. The partition algorithm can split the image into
Laurent Pinchart8ddf3782016-09-12 09:50:13 -0300228 * multiple slices.
229 */
Kieran Binghamfc6e5142016-09-11 23:26:35 -0300230 if (pipe->partitions > 1)
231 width = pipe->partition.width;
232
Laurent Pinchart8ddf3782016-09-12 09:50:13 -0300233 vsp1_wpf_write(wpf, dl, VI6_WPF_HSZCLIP, VI6_WPF_SZCLIP_EN |
234 (0 << VI6_WPF_SZCLIP_OFST_SHIFT) |
235 (width << VI6_WPF_SZCLIP_SIZE_SHIFT));
236 vsp1_wpf_write(wpf, dl, VI6_WPF_VSZCLIP, VI6_WPF_SZCLIP_EN |
237 (0 << VI6_WPF_SZCLIP_OFST_SHIFT) |
238 (height << VI6_WPF_SZCLIP_SIZE_SHIFT));
239
240 if (pipe->lif)
241 return;
242
Mauro Carvalho Chehabb6187392016-09-19 15:18:01 -0300243 /*
244 * Update the memory offsets based on flipping configuration.
Laurent Pinchart8ddf3782016-09-12 09:50:13 -0300245 * The destination addresses point to the locations where the
246 * VSP starts writing to memory, which can be different corners
Kieran Binghamfc6e5142016-09-11 23:26:35 -0300247 * of the image depending on vertical flipping.
Laurent Pinchart8ddf3782016-09-12 09:50:13 -0300248 */
Kieran Binghamfc6e5142016-09-11 23:26:35 -0300249 if (pipe->partitions > 1) {
250 const struct vsp1_format_info *fmtinfo = wpf->fmtinfo;
251
Mauro Carvalho Chehabb6187392016-09-19 15:18:01 -0300252 /*
253 * Horizontal flipping is handled through a line buffer
Kieran Binghamfc6e5142016-09-11 23:26:35 -0300254 * and doesn't modify the start address, but still needs
255 * to be handled when image partitioning is in effect to
256 * order the partitions correctly.
257 */
258 if (flip & BIT(WPF_CTRL_HFLIP))
259 offset = format->width - pipe->partition.left
260 - pipe->partition.width;
261 else
262 offset = pipe->partition.left;
263
264 mem.addr[0] += offset * fmtinfo->bpp[0] / 8;
265 if (format->num_planes > 1) {
266 mem.addr[1] += offset / fmtinfo->hsub
267 * fmtinfo->bpp[1] / 8;
268 mem.addr[2] += offset / fmtinfo->hsub
269 * fmtinfo->bpp[2] / 8;
270 }
271 }
272
Laurent Pinchart8ddf3782016-09-12 09:50:13 -0300273 if (flip & BIT(WPF_CTRL_VFLIP)) {
274 mem.addr[0] += (format->height - 1)
275 * format->plane_fmt[0].bytesperline;
276
277 if (format->num_planes > 1) {
278 offset = (format->height / wpf->fmtinfo->vsub - 1)
279 * format->plane_fmt[1].bytesperline;
280 mem.addr[1] += offset;
281 mem.addr[2] += offset;
282 }
283 }
284
Laurent Pinchart34253822017-02-12 20:58:20 -0200285 /*
286 * On Gen3 hardware the SPUVS bit has no effect on 3-planar
287 * formats. Swap the U and V planes manually in that case.
288 */
289 if (vsp1->info->gen == 3 && format->num_planes == 3 &&
290 fmtinfo->swap_uv)
291 swap(mem.addr[1], mem.addr[2]);
292
Laurent Pinchart8ddf3782016-09-12 09:50:13 -0300293 vsp1_wpf_write(wpf, dl, VI6_WPF_DSTM_ADDR_Y, mem.addr[0]);
294 vsp1_wpf_write(wpf, dl, VI6_WPF_DSTM_ADDR_C0, mem.addr[1]);
295 vsp1_wpf_write(wpf, dl, VI6_WPF_DSTM_ADDR_C1, mem.addr[2]);
296 return;
297 }
298
299 /* Format */
Laurent Pinchart7b905f02015-11-17 13:10:26 -0200300 if (!pipe->lif) {
301 const struct v4l2_pix_format_mplane *format = &wpf->format;
302 const struct vsp1_format_info *fmtinfo = wpf->fmtinfo;
303
304 outfmt = fmtinfo->hwfmt << VI6_WPF_OUTFMT_WRFMT_SHIFT;
305
306 if (fmtinfo->alpha)
307 outfmt |= VI6_WPF_OUTFMT_PXA;
308 if (fmtinfo->swap_yc)
309 outfmt |= VI6_WPF_OUTFMT_SPYCS;
310 if (fmtinfo->swap_uv)
311 outfmt |= VI6_WPF_OUTFMT_SPUVS;
312
313 /* Destination stride and byte swapping. */
Laurent Pinchart5e8dbbf2015-11-22 20:29:25 -0200314 vsp1_wpf_write(wpf, dl, VI6_WPF_DSTM_STRIDE_Y,
Laurent Pinchart7b905f02015-11-17 13:10:26 -0200315 format->plane_fmt[0].bytesperline);
316 if (format->num_planes > 1)
Laurent Pinchart5e8dbbf2015-11-22 20:29:25 -0200317 vsp1_wpf_write(wpf, dl, VI6_WPF_DSTM_STRIDE_C,
Laurent Pinchart7b905f02015-11-17 13:10:26 -0200318 format->plane_fmt[1].bytesperline);
319
Laurent Pinchart5e8dbbf2015-11-22 20:29:25 -0200320 vsp1_wpf_write(wpf, dl, VI6_WPF_DSWAP, fmtinfo->swap);
Laurent Pinchart894dde52016-05-26 05:14:22 -0300321
322 if (vsp1->info->features & VSP1_HAS_WPF_HFLIP &&
323 wpf->entity.index == 0)
324 vsp1_wpf_write(wpf, dl, VI6_WPF_ROT_CTRL,
325 VI6_WPF_ROT_CTRL_LN16 |
326 (256 << VI6_WPF_ROT_CTRL_LMEM_WD_SHIFT));
Laurent Pinchart7b905f02015-11-17 13:10:26 -0200327 }
328
329 if (sink_format->code != source_format->code)
330 outfmt |= VI6_WPF_OUTFMT_CSC;
331
Laurent Pinchartd05a3312016-06-20 05:04:38 -0300332 wpf->outfmt = outfmt;
Laurent Pinchart7b905f02015-11-17 13:10:26 -0200333
Laurent Pinchart5e8dbbf2015-11-22 20:29:25 -0200334 vsp1_dl_list_write(dl, VI6_DPR_WPF_FPORCH(wpf->entity.index),
335 VI6_DPR_WPF_FPORCH_FP_WPFN);
Laurent Pinchart7b905f02015-11-17 13:10:26 -0200336
Laurent Pinchart5e8dbbf2015-11-22 20:29:25 -0200337 vsp1_dl_list_write(dl, VI6_WPF_WRBCK_CTRL, 0);
Laurent Pinchart7b905f02015-11-17 13:10:26 -0200338
339 /* Sources. If the pipeline has a single input and BRU is not used,
340 * configure it as the master layer. Otherwise configure all
341 * inputs as sub-layers and select the virtual RPF as the master
342 * layer.
343 */
344 for (i = 0; i < vsp1->info->rpf_count; ++i) {
345 struct vsp1_rwpf *input = pipe->inputs[i];
346
347 if (!input)
348 continue;
349
350 srcrpf |= (!pipe->bru && pipe->num_inputs == 1)
351 ? VI6_WPF_SRCRPF_RPF_ACT_MST(input->entity.index)
352 : VI6_WPF_SRCRPF_RPF_ACT_SUB(input->entity.index);
353 }
354
355 if (pipe->bru || pipe->num_inputs > 1)
356 srcrpf |= VI6_WPF_SRCRPF_VIRACT_MST;
357
Laurent Pinchart5e8dbbf2015-11-22 20:29:25 -0200358 vsp1_wpf_write(wpf, dl, VI6_WPF_SRCRPF, srcrpf);
Laurent Pinchart7b905f02015-11-17 13:10:26 -0200359
360 /* Enable interrupts */
Laurent Pinchart5e8dbbf2015-11-22 20:29:25 -0200361 vsp1_dl_list_write(dl, VI6_WPF_IRQ_STA(wpf->entity.index), 0);
362 vsp1_dl_list_write(dl, VI6_WPF_IRQ_ENB(wpf->entity.index),
Kieran Bingham4c4b57b2016-09-06 06:55:02 -0300363 VI6_WFP_IRQ_ENB_DFEE);
Laurent Pinchart7b905f02015-11-17 13:10:26 -0200364}
365
Laurent Pinchart52434532015-11-17 12:23:23 -0200366static const struct vsp1_entity_operations wpf_entity_ops = {
367 .destroy = vsp1_wpf_destroy,
Laurent Pinchart7b905f02015-11-17 13:10:26 -0200368 .configure = wpf_configure,
Laurent Pinchart26e0ca22013-06-04 11:22:30 -0300369};
370
371/* -----------------------------------------------------------------------------
372 * Initialization and Cleanup
373 */
374
375struct vsp1_rwpf *vsp1_wpf_create(struct vsp1_device *vsp1, unsigned int index)
376{
Laurent Pinchart26e0ca22013-06-04 11:22:30 -0300377 struct vsp1_rwpf *wpf;
Laurent Pinchart823329d2015-11-15 19:42:01 -0200378 char name[6];
Laurent Pinchart26e0ca22013-06-04 11:22:30 -0300379 int ret;
380
381 wpf = devm_kzalloc(vsp1->dev, sizeof(*wpf), GFP_KERNEL);
382 if (wpf == NULL)
383 return ERR_PTR(-ENOMEM);
384
Laurent Pinchart0d268dc2016-03-25 06:51:06 -0300385 if (vsp1->info->gen == 2) {
386 wpf->max_width = WPF_GEN2_MAX_WIDTH;
387 wpf->max_height = WPF_GEN2_MAX_HEIGHT;
388 } else {
389 wpf->max_width = WPF_GEN3_MAX_WIDTH;
390 wpf->max_height = WPF_GEN3_MAX_HEIGHT;
391 }
Laurent Pinchart26e0ca22013-06-04 11:22:30 -0300392
Laurent Pinchart52434532015-11-17 12:23:23 -0200393 wpf->entity.ops = &wpf_entity_ops;
Laurent Pinchart26e0ca22013-06-04 11:22:30 -0300394 wpf->entity.type = VSP1_ENTITY_WPF;
395 wpf->entity.index = index;
Laurent Pinchart26e0ca22013-06-04 11:22:30 -0300396
Laurent Pinchart823329d2015-11-15 19:42:01 -0200397 sprintf(name, "wpf.%u", index);
Laurent Pinchart6a8e07b2016-02-15 22:10:26 -0200398 ret = vsp1_entity_init(vsp1, &wpf->entity, name, 2, &wpf_ops,
399 MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER);
Laurent Pinchart26e0ca22013-06-04 11:22:30 -0300400 if (ret < 0)
401 return ERR_PTR(ret);
402
Laurent Pinchart351bbf92015-11-01 15:18:56 -0200403 /* Initialize the display list manager. */
Kieran Bingham76e48892016-07-12 13:49:46 -0300404 wpf->dlm = vsp1_dlm_create(vsp1, index, 64);
Laurent Pinchart351bbf92015-11-01 15:18:56 -0200405 if (!wpf->dlm) {
406 ret = -ENOMEM;
407 goto error;
Laurent Pinchartef9621b2015-11-14 22:27:52 -0200408 }
409
Laurent Pinchart7578c202014-05-21 19:00:05 -0300410 /* Initialize the control handler. */
Laurent Pinchart894dde52016-05-26 05:14:22 -0300411 ret = wpf_init_controls(wpf);
Laurent Pinchartbd2fdd52015-11-01 12:19:42 -0200412 if (ret < 0) {
Laurent Pinchart7578c202014-05-21 19:00:05 -0300413 dev_err(vsp1->dev, "wpf%u: failed to initialize controls\n",
414 index);
Laurent Pinchart7578c202014-05-21 19:00:05 -0300415 goto error;
416 }
417
Laurent Pinchartd05a3312016-06-20 05:04:38 -0300418 v4l2_ctrl_handler_setup(&wpf->ctrls);
419
Laurent Pinchart26e0ca22013-06-04 11:22:30 -0300420 return wpf;
421
Laurent Pinchart1499be62014-05-28 12:49:13 -0300422error:
423 vsp1_entity_destroy(&wpf->entity);
Laurent Pinchart26e0ca22013-06-04 11:22:30 -0300424 return ERR_PTR(ret);
425}