linux-3.10.git
15 years agoNetLabel: SELinux cleanups
Paul Moore [Fri, 17 Nov 2006 22:38:53 +0000 (17:38 -0500)]
NetLabel: SELinux cleanups

This patch does a lot of cleanup in the SELinux NetLabel support code.  A
summary of the changes include:

* Use RCU locking for the NetLabel state variable in the skk_security_struct
  instead of using the inode_security_struct mutex.
* Remove unnecessary parameters in selinux_netlbl_socket_post_create().
* Rename selinux_netlbl_sk_clone_security() to
  selinux_netlbl_sk_security_clone() to better fit the other NetLabel
  sk_security functions.
* Improvements to selinux_netlbl_inode_permission() to help reduce the cost of
  the common case.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>
15 years agoNetLabel: use cipso_v4_doi_search() for local CIPSOv4 functions
Paul Moore [Fri, 17 Nov 2006 22:38:52 +0000 (17:38 -0500)]
NetLabel: use cipso_v4_doi_search() for local CIPSOv4 functions

The cipso_v4_doi_search() function behaves the same as cipso_v4_doi_getdef()
but is a local, static function so use it whenever possibile in the CIPSOv4
code base.

Signed-of-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>
15 years agoNetLabel: use the correct CIPSOv4 MLS label limits
Paul Moore [Fri, 17 Nov 2006 22:38:51 +0000 (17:38 -0500)]
NetLabel: use the correct CIPSOv4 MLS label limits

The CIPSOv4 engine currently has MLS label limits which are slightly larger
than what the draft allows.  This is not a major problem due to the current
implementation but we should fix this so it doesn't bite us later.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>
15 years agoNetLabel: return the correct error for translated CIPSOv4 tags
Paul Moore [Fri, 17 Nov 2006 22:38:50 +0000 (17:38 -0500)]
NetLabel: return the correct error for translated CIPSOv4 tags

The CIPSOv4 translated tag #1 mapping does not always return the correct error
code if the desired mapping does not exist; instead of returning -EPERM it
returns -ENOSPC indicating that the buffer is not large enough to hold the
translated value.  This was caused by failing to check a specific error
condition.  This patch fixes this so that unknown mappings return
-EPERM which is consistent with the rest of the related CIPSOv4 code.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>
15 years agoNetLabel: fixup the handling of CIPSOv4 tags to allow for multiple tag types
Paul Moore [Fri, 17 Nov 2006 22:38:49 +0000 (17:38 -0500)]
NetLabel: fixup the handling of CIPSOv4 tags to allow for multiple tag types

While the original CIPSOv4 code had provisions for multiple tag types the
implementation was not as great as it could be, pushing a lot of non-tag
specific processing into the tag specific code blocks.  This patch fixes that
issue making it easier to support multiple tag types in the future.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>
15 years agoNetLabel: add tag verification when adding new CIPSOv4 DOI definitions
Paul Moore [Fri, 17 Nov 2006 22:38:48 +0000 (17:38 -0500)]
NetLabel: add tag verification when adding new CIPSOv4 DOI definitions

Currently the CIPSOv4 engine does not do any sort of checking when a new DOI
definition is added.  The tags are still verified but only as a side effect of
normal NetLabel operation (packet processing, socket labeling, etc.) which
would cause application errors due to the faulty configuration.  This patch
adds tag checking when new DOI definition are added allowing us to catch these
configuration problems when they happen.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>
15 years agoNetLabel: check for a CIPSOv4 option before we do call into the CIPSOv4 layer
Paul Moore [Fri, 17 Nov 2006 22:38:47 +0000 (17:38 -0500)]
NetLabel: check for a CIPSOv4 option before we do call into the CIPSOv4 layer

Right now the NetLabel code always jumps into the CIPSOv4 layer to determine if
a CIPSO IP option is present.  However, we can do this check directly in the
NetLabel code by making use of the CIPSO_V4_OPTEXIST() macro which should save
us a function call in the common case of not having a CIPSOv4 option present.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>
15 years agoNetLabel: make netlbl_lsm_secattr struct easier/quicker to understand
Paul Moore [Fri, 17 Nov 2006 22:38:46 +0000 (17:38 -0500)]
NetLabel: make netlbl_lsm_secattr struct easier/quicker to understand

The existing netlbl_lsm_secattr struct required the LSM to check all of the
fields to determine if any security attributes were present resulting in a lot
of work in the common case of no attributes.  This patch adds a 'flags' field
which is used to indicate which attributes are present in the structure; this
should allow the LSM to do a quick comparison to determine if the structure
holds any security attributes.

Example:

 if (netlbl_lsm_secattr->flags)
/* security attributes present */
 else
/* NO security attributes present */

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>
15 years agoNetLabel: change netlbl_secattr_init() to return void
Paul Moore [Fri, 17 Nov 2006 22:38:45 +0000 (17:38 -0500)]
NetLabel: change netlbl_secattr_init() to return void

The netlbl_secattr_init() function would always return 0 making it pointless
to have a return value.  This patch changes the function to return void.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>
15 years agoNetLabel: convert the unlabeled accept flag to use RCU
Paul Moore [Fri, 17 Nov 2006 22:38:44 +0000 (17:38 -0500)]
NetLabel: convert the unlabeled accept flag to use RCU

Currently the NetLabel unlabeled packet accept flag is an atomic type and it
is checked for every non-NetLabel packet which comes into the system but rarely
ever changed.  This patch changes this flag to a normal integer and protects it
with RCU locking.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>
15 years agoNetLabel: use gfp_t instead of int where it makes sense
Paul Moore [Fri, 17 Nov 2006 22:38:43 +0000 (17:38 -0500)]
NetLabel: use gfp_t instead of int where it makes sense

There were a few places in the NetLabel code where the int type was being used
instead of the gfp_t type, this patch corrects this mistake.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>
15 years ago[TCP]: Tidy up skb_entail
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 21:59:12 +0000 (19:59 -0200)]
[TCP]: Tidy up skb_entail

Heck, it even saves us some few bytes:

[acme@newtoy net-2.6.20]$ codiff -f /tmp/tcp.o.before ../OUTPUT/qemu/net-2.6.20/net/ipv4/tcp.o
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/tcp.c:
  tcp_sendpage |   -7
  tcp_sendmsg  |   -5
 2 functions changed, 12 bytes removed
[acme@newtoy net-2.6.20]$

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
15 years ago[NETROM]: Use kmemdup
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 15:05:04 +0000 (13:05 -0200)]
[NETROM]: Use kmemdup

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
15 years ago[AX25]: Use kmemdup
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 14:43:07 +0000 (12:43 -0200)]
[AX25]: Use kmemdup

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/ax25.ko.before /tmp/ax25.ko.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ax25/ax25_out.c:
  ax25_send_frame |   -8
 1 function changed, 8 bytes removed

/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ax25/ax25_route.c:
  ax25_rt_autobind |  -15
 1 function changed, 15 bytes removed

/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ax25/af_ax25.c:
  ax25_make_new |  -33
 1 function changed, 33 bytes removed

/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ax25/sysctl_net_ax25.c:
  ax25_register_sysctl |  -21
 1 function changed, 21 bytes removed

/tmp/ax25.ko.after:
 4 functions changed, 77 bytes removed
[acme@newtoy net-2.6.20]$

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
15 years ago[DECNET]: Use kmemdup
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 14:29:21 +0000 (12:29 -0200)]
[DECNET]: Use kmemdup

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/decnet.ko.before /tmp/decnet.ko.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/decnet/dn_dev.c:
  dn_dev_sysctl_register |  -51
 1 function changed, 51 bytes removed
[acme@newtoy net-2.6.20]$

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
15 years ago[DCCP]: Use kmemdup
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 14:21:43 +0000 (12:21 -0200)]
[DCCP]: Use kmemdup

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/dccp.ko.before /tmp/dccp.ko.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/dccp/feat.c:
  __dccp_feat_init      |  -16
  dccp_feat_change_recv |  -55
  dccp_feat_clone       |  -56
 3 functions changed, 127 bytes removed
[acme@newtoy net-2.6.20]$

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
15 years ago[IPV6]: Use kmemdup
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 14:14:37 +0000 (12:14 -0200)]
[IPV6]: Use kmemdup

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/ipv6.ko.before /tmp/ipv6.ko.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv6/ip6_output.c:
  ip6_output      |  -52
  ip6_append_data |   +2
 2 functions changed, 2 bytes added, 52 bytes removed

/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv6/addrconf.c:
  addrconf_sysctl_register |  -27
 1 function changed, 27 bytes removed

/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv6/tcp_ipv6.c:
  tcp_v6_syn_recv_sock  |  -32
  tcp_v6_parse_md5_keys |  -24
 2 functions changed, 56 bytes removed

/tmp/ipv6.ko.after:
 5 functions changed, 2 bytes added, 135 bytes removed
[acme@newtoy net-2.6.20]$

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
15 years ago[TCP] minisocks: Use kmemdup and LIMIT_NETDEBUG
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 13:25:49 +0000 (11:25 -0200)]
[TCP] minisocks: Use kmemdup and LIMIT_NETDEBUG

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/tcp_minisocks.o.before /tmp/tcp_minisocks.o.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/tcp_minisocks.c:
  tcp_check_req |  -44
 1 function changed, 44 bytes removed
[acme@newtoy net-2.6.20]$

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
15 years ago[IPV4]: Use kmemdup in net/ipv4/devinet.c
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 13:18:20 +0000 (11:18 -0200)]
[IPV4]: Use kmemdup in net/ipv4/devinet.c

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/devinet.o.before /tmp/devinet.o.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/devinet.c:
  devinet_sysctl_register |  -38
 1 function changed, 38 bytes removed
[acme@newtoy net-2.6.20]$

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
15 years ago[NETLABEL]: Use kmemdup in cipso_ipv4.c
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 13:14:16 +0000 (11:14 -0200)]
[NETLABEL]: Use kmemdup in cipso_ipv4.c

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/cipso_ipv4.o.before /tmp/cipso_ipv4.o.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/cipso_ipv4.c:
  cipso_v4_cache_add |  -46
 1 function changed, 46 bytes removed
[acme@newtoy net-2.6.20]$

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
15 years ago[TCP_IPV4]: Use kmemdup where appropriate
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 13:06:01 +0000 (11:06 -0200)]
[TCP_IPV4]: Use kmemdup where appropriate

Also use a variable to avoid the longish tp->md5sig_info-> use
in tcp_v4_md5_do_add.

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/tcp_ipv4.o.before /tmp/tcp_ipv4.o.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/tcp_ipv4.c:
  tcp_v4_md5_do_add     |  -62
  tcp_v4_syn_recv_sock  |  -32
  tcp_v4_parse_md5_keys |  -86
 3 functions changed, 180 bytes removed
[acme@newtoy net-2.6.20]$

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
15 years ago[TCP_IPV4]: CodingStyle cleanups, no code change
Arnaldo Carvalho de Melo [Fri, 17 Nov 2006 12:57:30 +0000 (10:57 -0200)]
[TCP_IPV4]: CodingStyle cleanups, no code change

Mostly related to CONFIG_TCP_MD5SIG recent merge.

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
15 years ago[DCCP] CCID2: Code optimizations
Andrea Bittau [Thu, 16 Nov 2006 16:28:40 +0000 (14:28 -0200)]
[DCCP] CCID2: Code optimizations

These are code optimizations which are relevant when dealing with large
windows.  They are not coded the way I would like to, but they do the job for
the short-term.  This patch should be more neat.

Commiter note: Changed the seqno comparisions to use {after,before}48 to handle
               wrapping.

Signed-off-by: Andrea Bittau <a.bittau@cs.ucl.ac.uk>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
15 years ago[NET]: Conditionally use bh_lock_sock_nested in sk_receive_skb
Arnaldo Carvalho de Melo [Thu, 16 Nov 2006 16:06:06 +0000 (14:06 -0200)]
[NET]: Conditionally use bh_lock_sock_nested in sk_receive_skb

Spotted by Ian McDonald, tentatively fixed by Gerrit Renker:

http://www.mail-archive.com/dccp%40vger.kernel.org/msg00599.html

Rewritten not to unroll sk_receive_skb, in the common case, i.e. no lock
debugging, its optimized away.

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
15 years ago[DCCP]: One NET_INC_STATS() could be NET_INC_STATS_BH in dccp_v4_err()
Arnaldo Carvalho de Melo [Thu, 16 Nov 2006 14:23:58 +0000 (12:23 -0200)]
[DCCP]: One NET_INC_STATS() could be NET_INC_STATS_BH in dccp_v4_err()

Spotted by Eric Dumazet in tcp_v4_rcv().

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
15 years ago[DCCP]: Introduce DCCP_{BUG{_ON},CRIT} macros, use enum:8 for the ccid3 states
Gerrit Renker [Wed, 15 Nov 2006 23:27:47 +0000 (21:27 -0200)]
[DCCP]: Introduce DCCP_{BUG{_ON},CRIT} macros, use enum:8 for the ccid3 states

This patch tackles the following problem:
       * the ccid3_hc_{t,r}x_sock define ccid3hc{t,r}x_state as `u8', but
         in reality there can only be a few, pre-defined enum names
       * this necessitates addiditional checking for unexpected values
         which would otherwise be caught by the compiler

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
15 years ago[UDPLite]: udplite.h needs ip6_checksum.h
David S. Miller [Wed, 15 Nov 2006 09:09:32 +0000 (01:09 -0800)]
[UDPLite]: udplite.h needs ip6_checksum.h

Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET/IPv4]: Make udp_push_pending_frames static
Gerrit Renker [Wed, 15 Nov 2006 08:44:49 +0000 (00:44 -0800)]
[NET/IPv4]: Make udp_push_pending_frames static

udp_push_pending_frames is only referenced within
net/ipv4/udp.c and hence can remain static.

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[IPV6]: udp.c build fix
David S. Miller [Wed, 15 Nov 2006 06:09:20 +0000 (22:09 -0800)]
[IPV6]: udp.c build fix

Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: More dccp endianness annotations.
Al Viro [Wed, 15 Nov 2006 05:51:36 +0000 (21:51 -0800)]
[NET]: More dccp endianness annotations.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Preliminaty annotation of skb->csum.
Al Viro [Wed, 15 Nov 2006 05:44:08 +0000 (21:44 -0800)]
[NET]: Preliminaty annotation of skb->csum.

It's still not completely right; we need to split it into anon unions
of __wsum and unsigned - for cases when we use it for partial checksum
and for offset of checksum in skb

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET] driver/s390/net: Checksum annotations.
Al Viro [Wed, 15 Nov 2006 05:43:44 +0000 (21:43 -0800)]
[NET] driver/s390/net: Checksum annotations.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: netfilter checksum annotations
Al Viro [Wed, 15 Nov 2006 05:43:23 +0000 (21:43 -0800)]
[NET]: netfilter checksum annotations

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: ipvs checksum annotations.
Al Viro [Thu, 16 Nov 2006 10:41:18 +0000 (02:41 -0800)]
[NET]: ipvs checksum annotations.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: IP header modifier helpers annotations.
Al Viro [Wed, 15 Nov 2006 05:42:26 +0000 (21:42 -0800)]
[NET]: IP header modifier helpers annotations.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Make mangling a checksum (0 -> 0xffff on the wire) explicit.
Al Viro [Thu, 16 Nov 2006 10:36:50 +0000 (02:36 -0800)]
[NET]: Make mangling a checksum (0 -> 0xffff on the wire) explicit.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Annotate __skb_checksum_complete() and friends.
Al Viro [Wed, 15 Nov 2006 05:40:42 +0000 (21:40 -0800)]
[NET]: Annotate __skb_checksum_complete() and friends.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Annotate ip_vs_checksum_complete() and callers.
Al Viro [Wed, 15 Nov 2006 05:37:50 +0000 (21:37 -0800)]
[NET]: Annotate ip_vs_checksum_complete() and callers.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Annotate skb_copy_and_csum_bits() and callers.
Al Viro [Wed, 15 Nov 2006 05:37:33 +0000 (21:37 -0800)]
[NET]: Annotate skb_copy_and_csum_bits() and callers.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Annotate skb_checksum() and callers.
Al Viro [Wed, 15 Nov 2006 05:37:14 +0000 (21:37 -0800)]
[NET]: Annotate skb_checksum() and callers.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Annotate callers of the reset of checksum.h stuff.
Al Viro [Wed, 15 Nov 2006 05:36:54 +0000 (21:36 -0800)]
[NET]: Annotate callers of the reset of checksum.h stuff.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Annotate callers of csum_partial_copy_...() and csum_and_copy...() in net/*
Al Viro [Wed, 15 Nov 2006 05:36:34 +0000 (21:36 -0800)]
[NET]: Annotate callers of csum_partial_copy_...() and csum_and_copy...() in net/*

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Annotate csum_partial() callers in net/*
Al Viro [Wed, 15 Nov 2006 05:36:14 +0000 (21:36 -0800)]
[NET]: Annotate csum_partial() callers in net/*

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: annotate csum_ipv6_magic() callers in net/*
Al Viro [Wed, 15 Nov 2006 05:35:48 +0000 (21:35 -0800)]
[NET]: annotate csum_ipv6_magic() callers in net/*

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Annotate csum_tcpudp_magic() callers in net/*
Al Viro [Wed, 15 Nov 2006 05:28:51 +0000 (21:28 -0800)]
[NET]: Annotate csum_tcpudp_magic() callers in net/*

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Annotate csum_tcpudp_magic() callers in net/*
Al Viro [Wed, 15 Nov 2006 05:28:24 +0000 (21:28 -0800)]
[NET]: Annotate csum_tcpudp_magic() callers in net/*

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Annotate callers of csum_tcpudp_nofold() in net/*
Al Viro [Wed, 15 Nov 2006 05:26:08 +0000 (21:26 -0800)]
[NET]: Annotate callers of csum_tcpudp_nofold() in net/*

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Annotate callers of csum_fold() in net/*
Al Viro [Wed, 15 Nov 2006 05:24:49 +0000 (21:24 -0800)]
[NET]: Annotate callers of csum_fold() in net/*

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Annotate checksums in on-the-wire packets.
Al Viro [Wed, 15 Nov 2006 05:24:30 +0000 (21:24 -0800)]
[NET]: Annotate checksums in on-the-wire packets.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Generic checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:23:59 +0000 (21:23 -0800)]
[NET]: Generic checksum annotations and cleanups.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: XTENSA checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:23:40 +0000 (21:23 -0800)]
[NET]: XTENSA checksum annotations and cleanups.

* sanitize prototypes, annotate
* kill csum_partial_copy_fromuser
* kill csum_partial_copy
* kill useless shifts
* usual ntohs->shift

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: SPARC64 checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:23:20 +0000 (21:23 -0800)]
[NET]: SPARC64 checksum annotations and cleanups.

* sanitize prototypes, annotate
* kill useless shift

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: SPARC checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:22:56 +0000 (21:22 -0800)]
[NET]: SPARC checksum annotations and cleanups.

* sanitize prototypes, annotate
* kill bogus access_ok() in csum_partial_copy_from_user (the only caller checks)
* kill useless shift

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: SH checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:22:35 +0000 (21:22 -0800)]
[NET]: SH checksum annotations and cleanups.

* sanitize prototypes, annotate
* kill useless shifts
* usual ntohs->shift

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: S390 checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:22:18 +0000 (21:22 -0800)]
[NET]: S390 checksum annotations and cleanups.

* sanitize prototypes, annotate
* kill useless shifts

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: POWERPC checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:21:58 +0000 (21:21 -0800)]
[NET]: POWERPC checksum annotations and cleanups.

* sanitize prototypes, annotate
* kill useless shifts

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: I386 checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:21:37 +0000 (21:21 -0800)]
[NET]: I386 checksum annotations and cleanups.

* sanitize prototypes, annotate
* usual ntohs->shift

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: AVR32 checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:21:15 +0000 (21:21 -0800)]
[NET]: AVR32 checksum annotations and cleanups.

* sanitize prototypes, annotate
* kill useless shifts
* kill useless ntohs (it's big-endian, for fsck sake!)

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: ARM26 checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:20:51 +0000 (21:20 -0800)]
[NET]: ARM26 checksum annotations and cleanups.

* sanitize prototypes, annotate
* kill csum_partial_copy

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: ARM checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:20:28 +0000 (21:20 -0800)]
[NET]: ARM checksum annotations and cleanups.

* sanitize prototypes, annotate
* kill csum_partial_copy
* usual ntohs->shift, this time in assembler part

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: X86_64 checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:20:08 +0000 (21:20 -0800)]
[NET]: X86_64 checksum annotations and cleanups.

* sanitize prototypes, annotate
* usual ntohs->shift

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: V850 checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:19:44 +0000 (21:19 -0800)]
[NET]: V850 checksum annotations and cleanups.

* sanitize prototypes, annotate
* collapse csum_partial_copy
* usual ntohs->shift

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: UML checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:19:22 +0000 (21:19 -0800)]
[NET]: UML checksum annotations and cleanups.

* sanitize prototypes, annotate
* kill csum_partial_copy_fromuser
* kill shift-by-16 in checksum calculations
* ntohs->shift in checksum calculations

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: SH64 checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:19:01 +0000 (21:19 -0800)]
[NET]: SH64 checksum annotations and cleanups.

* sanitize prototypes, annotate
* collapse csum_partial_copy
* kill csum_partial_copy_fromuser
* ntohs->shift in checksum calculation

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: PARISC checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:18:39 +0000 (21:18 -0800)]
[NET]: PARISC checksum annotations and cleanups.

* sanitized prototypes, annotated
* kill shift-by-16 in checksum calculation

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: MIPS checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:18:18 +0000 (21:18 -0800)]
[NET]: MIPS checksum annotations and cleanups.

* sanitize prototypes, annotate
* kill shift-by-16 in checksum calculations
* htons->shift in l-e checksum calculations

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: M68Knommu checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:17:56 +0000 (21:17 -0800)]
[NET]: M68Knommu checksum annotations and cleanups.

* sanitize prototypes, annotated
* collapsed csum_partial_copy()

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: M68K checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:17:19 +0000 (21:17 -0800)]
[NET]: M68K checksum annotations and cleanups.

* sanitize prototypes, annotate

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: M32R checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:16:55 +0000 (21:16 -0800)]
[NET]: M32R checksum annotations and cleanups.

* sanitize prototypes, annotate
* ntohs -> shift in checksum calculations in l-e case
* kill shift-by-16 in checksum calculations

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: IA64 checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:16:30 +0000 (21:16 -0800)]
[NET]: IA64 checksum annotations and cleanups.

* sanitize prototypes, annotate
* ntohs -> shift in checksum calculations
* kill access_ok() in csum_partial_copy_from_user
* collapse do_csum_partial_copy_from_user

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: H8300 checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:16:07 +0000 (21:16 -0800)]
[NET]: H8300 checksum annotations and cleanups.

* sanitize prototypes and annotate
* collapse csum_partial_copy

NB: csum_partial() is almost certainly still buggy.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: FRV checksum annotations.
Al Viro [Wed, 15 Nov 2006 05:15:40 +0000 (21:15 -0800)]
[NET]: FRV checksum annotations.

* sanitize prototypes and annotate
* collapse csum_partial_copy

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Cris checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:15:19 +0000 (21:15 -0800)]
[NET]: Cris checksum annotations and cleanups.

* sanitize prototypes and annotate
* kill cast-as-lvalue abuses in csum_partial()
* usual ntohs-equals-shift for checksum purposes

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Alpha checksum annotations and cleanups.
Al Viro [Wed, 15 Nov 2006 05:14:53 +0000 (21:14 -0800)]
[NET]: Alpha checksum annotations and cleanups.

* sanitize prototypes and annotate
* kill useless access_ok() in csum_partial_copy_from_user() (the only
caller checks it already).
* do_csum_partial_copy_from_user() is not needed now
* replace htons(len) with len << 8 - they are the same wrt checksums
on little-endian.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Introduce types for checksums.
Al Viro [Wed, 15 Nov 2006 05:14:18 +0000 (21:14 -0800)]
[NET]: Introduce types for checksums.

New types - for 16bit checksums and "unfolded" 32bit variant.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Kill direct includes of asm/checksum.h
Al Viro [Wed, 15 Nov 2006 05:13:53 +0000 (21:13 -0800)]
[NET]: Kill direct includes of asm/checksum.h

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[IPVS]: Annotate ..._app_hashkey().
Al Viro [Wed, 15 Nov 2006 05:13:28 +0000 (21:13 -0800)]
[IPVS]: Annotate ..._app_hashkey().

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Annotate net_srandom().
Al Viro [Wed, 15 Nov 2006 05:12:29 +0000 (21:12 -0800)]
[NET]: Annotate net_srandom().

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[BRIDGE]: Annotations.
Al Viro [Wed, 15 Nov 2006 05:11:51 +0000 (21:11 -0800)]
[BRIDGE]: Annotations.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[ATM]: Annotations.
Al Viro [Wed, 15 Nov 2006 05:11:29 +0000 (21:11 -0800)]
[ATM]: Annotations.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NETFILTER]: More trivial annotations.
Al Viro [Wed, 15 Nov 2006 05:11:08 +0000 (21:11 -0800)]
[NETFILTER]: More trivial annotations.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[IPV6]: __ipv6_addr_diff() annotations and cleanup.
Al Viro [Wed, 15 Nov 2006 04:56:33 +0000 (20:56 -0800)]
[IPV6]: __ipv6_addr_diff() annotations and cleanup.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[IPV6]: Misc endianness annotations.
Al Viro [Wed, 15 Nov 2006 04:56:00 +0000 (20:56 -0800)]
[IPV6]: Misc endianness annotations.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[RANDOM]: Annotate random.h IP helpers.
Al Viro [Wed, 15 Nov 2006 04:52:19 +0000 (20:52 -0800)]
[RANDOM]: Annotate random.h IP helpers.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[IPV6]: Assorted trivial endianness annotations.
Al Viro [Wed, 15 Nov 2006 04:51:49 +0000 (20:51 -0800)]
[IPV6]: Assorted trivial endianness annotations.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET] net/core: Annotations.
Al Viro [Wed, 15 Nov 2006 04:48:11 +0000 (20:48 -0800)]
[NET] net/core: Annotations.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[IRDA]: Trivial annotations.
Al Viro [Wed, 15 Nov 2006 04:47:46 +0000 (20:47 -0800)]
[IRDA]: Trivial annotations.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NETPOLL]: Minor coding-style cleanups.
David S. Miller [Wed, 15 Nov 2006 04:40:49 +0000 (20:40 -0800)]
[NETPOLL]: Minor coding-style cleanups.

Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[NET]: Supporting UDP-Lite (RFC 3828) in Linux
Gerrit Renker [Mon, 27 Nov 2006 19:10:57 +0000 (11:10 -0800)]
[NET]: Supporting UDP-Lite (RFC 3828) in Linux

This is a revision of the previously submitted patch, which alters
the way files are organized and compiled in the following manner:

* UDP and UDP-Lite now use separate object files
* source file dependencies resolved via header files
  net/ipv{4,6}/udp_impl.h
* order of inclusion files in udp.c/udplite.c adapted
  accordingly

[NET/IPv4]: Support for the UDP-Lite protocol (RFC 3828)

This patch adds support for UDP-Lite to the IPv4 stack, provided as an
extension to the existing UDPv4 code:
        * generic routines are all located in net/ipv4/udp.c
        * UDP-Lite specific routines are in net/ipv4/udplite.c
        * MIB/statistics support in /proc/net/snmp and /proc/net/udplite
        * shared API with extensions for partial checksum coverage

[NET/IPv6]: Extension for UDP-Lite over IPv6

It extends the existing UDPv6 code base with support for UDP-Lite
in the same manner as per UDPv4. In particular,
        * UDPv6 generic and shared code is in net/ipv6/udp.c
        * UDP-Litev6 specific extensions are in net/ipv6/udplite.c
        * MIB/statistics support in /proc/net/snmp6 and /proc/net/udplite6
        * support for IPV6_ADDRFORM
        * aligned the coding style of protocol initialisation with af_inet6.c
        * made the error handling in udpv6_queue_rcv_skb consistent;
          to return `-1' on error on all error cases
        * consolidation of shared code

[NET]: UDP-Lite Documentation and basic XFRM/Netfilter support

The UDP-Lite patch further provides
        * API documentation for UDP-Lite
        * basic xfrm support
        * basic netfilter support for IPv4 and IPv6 (LOG target)

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[IPv6] prefix: Convert RTM_NEWPREFIX notifications to use the new netlink api
Thomas Graf [Wed, 15 Nov 2006 03:54:19 +0000 (19:54 -0800)]
[IPv6] prefix: Convert RTM_NEWPREFIX notifications to use the new netlink api

RTM_GETPREFIX is completely unused and is thus removed.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[IPv6] iflink: Convert IPv6's RTM_GETLINK to use the new netlink api
Thomas Graf [Wed, 15 Nov 2006 03:53:58 +0000 (19:53 -0800)]
[IPv6] iflink: Convert IPv6's RTM_GETLINK to use the new netlink api

By replacing the current method of exporting the device configuration
which included allocating a temporary buffer, copying ipv6_devconf
into it and copying that buffer into the message with a method that
uses nla_reserve() allowing to copy the device configuration directly
into the skb data buffer, a GFP_ATOMIC allocation could be removed.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[TCP]: Fix some warning when MD5 is disabled.
David S. Miller [Wed, 15 Nov 2006 03:53:22 +0000 (19:53 -0800)]
[TCP]: Fix some warning when MD5 is disabled.

Just some mis-placed ifdefs:

net/ipv4/tcp_minisocks.c: In function ‘tcp_twsk_destructor’:
net/ipv4/tcp_minisocks.c:364: warning: unused variable ‘twsk’
net/ipv6/tcp_ipv6.c:1846: warning: ‘tcp_sock_ipv6_specific’ defined but not used
net/ipv6/tcp_ipv6.c:1877: warning: ‘tcp_sock_ipv6_mapped_specific’ defined but not used

Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[GENL]: Add genlmsg_put_reply() to simplify building reply headers
Thomas Graf [Wed, 15 Nov 2006 03:46:02 +0000 (19:46 -0800)]
[GENL]: Add genlmsg_put_reply() to simplify building reply headers

By modyfing genlmsg_put() to take a genl_family and by adding
genlmsg_put_reply() the process of constructing the netlink
and generic netlink headers is simplified.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Acked-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[GENL]: Add genlmsg_reply() to simply unicast replies to requests
Thomas Graf [Wed, 15 Nov 2006 03:45:27 +0000 (19:45 -0800)]
[GENL]: Add genlmsg_reply() to simply unicast replies to requests

A generic netlink user has no interest in knowing how to
address the source of the original request.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Acked-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[GENL]: Add genlmsg_new() to allocate generic netlink messages
Thomas Graf [Wed, 15 Nov 2006 03:44:52 +0000 (19:44 -0800)]
[GENL]: Add genlmsg_new() to allocate generic netlink messages

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Acked-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years ago[TCP]: MD5 Signature Option (RFC2385) support.
YOSHIFUJI Hideaki [Wed, 15 Nov 2006 03:07:45 +0000 (19:07 -0800)]
[TCP]: MD5 Signature Option (RFC2385) support.

Based on implementation by Rick Payne.

Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 years agonetpoll header cleanup
Stephen Hemminger [Thu, 26 Oct 2006 22:46:56 +0000 (15:46 -0700)]
netpoll header cleanup

As Steve left netpoll beast, hopefully not to return soon.
He noticed that the header was messy. He straightened it
up and polished it a little, then waved goodbye.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
15 years agonetpoll queue cleanup
Stephen Hemminger [Thu, 26 Oct 2006 22:46:55 +0000 (15:46 -0700)]
netpoll queue cleanup

The beast had a long and not very happy history. At one
point, a friend (netdump) had asked that he open up a little.
Well, the friend was long gone now, and the beast had
this dangling piece hanging (netpoll_queue).

It wasn't hard to stitch the netpoll_queue back in
where it belonged and make everything tidy.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
15 years agonetpoll retry cleanup
Stephen Hemminger [Thu, 26 Oct 2006 22:46:54 +0000 (15:46 -0700)]
netpoll retry cleanup

The netpoll beast was still not happy. If the beast got
clogged pipes, it tended to stare blankly off in space
for a long time.

The problem couldn't be completely fixed because the
beast talked with irq's disabled. But it could be made
less painful and shorter.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
15 years agonetpoll deferred transmit path
Stephen Hemminger [Thu, 26 Oct 2006 22:46:53 +0000 (15:46 -0700)]
netpoll deferred transmit path

When the netpoll beast got busy, he tended to babble.
Instead of talking out of his large mouth as normal,
he tended to try to snort out other orifices. This lead
to words (skbs) ending up in odd places (like NIT) that
he did not intend.

The normal way of talking wouldn't work, but he could
at least change to using the same tone all the time.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>