]> nv-tegra.nvidia Code Review - linux-3.10.git/commitdiff
[PATCH] video/tuner: fix tuner->freq updating
authorJiri Benc <jbenc@suse.cz>
Sat, 7 May 2005 04:30:42 +0000 (21:30 -0700)
committerLinus Torvalds <torvalds@ppc970.osdl.org>
Sat, 7 May 2005 05:09:28 +0000 (22:09 -0700)
In VIDIOC_S_FREQUENCY command in tuner-core.c, t->freq is set to a new
value before calling set_freq().  This is not necessary, as set_freq() sets
t->freq itself.  Moreover, it causes problems with Philips tuners, as they
need to take into consideration difference between previous and new
frequency.

Signed-off-by: Jiri Benc <jbenc@suse.cz>
Cc: Gerd Knorr <kraxel@bytesex.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/media/video/tuner-core.c

index 881a0539fc1704c04be38a455a87918d1315dd84..c7d0c9f093fa9186d3cb1fee56d37638df4cd2d8 100644 (file)
@@ -357,8 +357,7 @@ tuner_command(struct i2c_client *client, unsigned int cmd, void *arg)
                    V4L2_TUNER_RADIO != t->mode)
                        set_tv_freq(client,400*16);
                t->mode  = f->type;
-               t->freq  = f->frequency;
-               set_freq(client,t->freq);
+               set_freq(client,f->frequency);
                break;
        }
        case VIDIOC_G_TUNER: