[PATCH] fs/qnx4/*: fix sparse warnings
authorAlexey Dobriyan <adobriyan@mail.ru>
Fri, 24 Jun 2005 20:52:52 +0000 (20:52 +0000)
committerLinus Torvalds <torvalds@ppc970.osdl.org>
Fri, 24 Jun 2005 21:14:24 +0000 (14:14 -0700)
This patch fixes sparse warnings in the qnx4fs (and might even make
qnx4fs work on big-endian boxes)

Signed-off-by: Alexey Dobriyan <adobriyan@mail.ru>
Signed-off-by: Domen Puncer <domen@coderock.org>
Signed-off-by: Anders Larsen <al@alarsen.net>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/qnx4/dir.c
fs/qnx4/inode.c
include/linux/qnx4_fs.h
include/linux/qnxtypes.h

index cd66147cca04c902331f6807b25b6989b8a6b3fb..7a8f5595c26fea5898f1dfe246c8b86025b3e72a 100644 (file)
@@ -61,7 +61,7 @@ static int qnx4_readdir(struct file *filp, void *dirent, filldir_t filldir)
                                                ino = blknum * QNX4_INODES_PER_BLOCK + ix - 1;
                                        else {
                                                le  = (struct qnx4_link_info*)de;
                                                ino = blknum * QNX4_INODES_PER_BLOCK + ix - 1;
                                        else {
                                                le  = (struct qnx4_link_info*)de;
-                                               ino = ( le->dl_inode_blk - 1 ) *
+                                               ino = ( le32_to_cpu(le->dl_inode_blk) - 1 ) *
                                                        QNX4_INODES_PER_BLOCK +
                                                        le->dl_inode_ndx;
                                        }
                                                        QNX4_INODES_PER_BLOCK +
                                                        le->dl_inode_ndx;
                                        }
index aa92d6b76a9af185e2f6a375d8140cfab7a77bfc..b79162a35478ce46fae25af21067844b0fabfd4b 100644 (file)
@@ -236,7 +236,7 @@ unsigned long qnx4_block_map( struct inode *inode, long iblock )
        struct buffer_head *bh = NULL;
        struct qnx4_xblk *xblk = NULL;
        struct qnx4_inode_entry *qnx4_inode = qnx4_raw_inode(inode);
        struct buffer_head *bh = NULL;
        struct qnx4_xblk *xblk = NULL;
        struct qnx4_inode_entry *qnx4_inode = qnx4_raw_inode(inode);
-       qnx4_nxtnt_t nxtnt = le16_to_cpu(qnx4_inode->di_num_xtnts);
+       u16 nxtnt = le16_to_cpu(qnx4_inode->di_num_xtnts);
 
        if ( iblock < le32_to_cpu(qnx4_inode->di_first_xtnt.xtnt_size) ) {
                // iblock is in the first extent. This is easy.
 
        if ( iblock < le32_to_cpu(qnx4_inode->di_first_xtnt.xtnt_size) ) {
                // iblock is in the first extent. This is easy.
@@ -372,7 +372,7 @@ static int qnx4_fill_super(struct super_block *s, void *data, int silent)
                printk("qnx4: unable to read the superblock\n");
                goto outnobh;
        }
                printk("qnx4: unable to read the superblock\n");
                goto outnobh;
        }
-       if ( le32_to_cpu( *(__u32*)bh->b_data ) != QNX4_SUPER_MAGIC ) {
+       if ( le32_to_cpup((__le32*) bh->b_data) != QNX4_SUPER_MAGIC ) {
                if (!silent)
                        printk("qnx4: wrong fsid in superblock.\n");
                goto out;
                if (!silent)
                        printk("qnx4: wrong fsid in superblock.\n");
                goto out;
index 22ba580b0ae89045d54f2b262f2e67437dbbc12e..fc610bb0f73397421ba88804236d950a2a4d9c7d 100644 (file)
@@ -46,11 +46,11 @@ struct qnx4_inode_entry {
        char            di_fname[QNX4_SHORT_NAME_MAX];
        qnx4_off_t      di_size;
        qnx4_xtnt_t     di_first_xtnt;
        char            di_fname[QNX4_SHORT_NAME_MAX];
        qnx4_off_t      di_size;
        qnx4_xtnt_t     di_first_xtnt;
-       __u32           di_xblk;
-       __s32           di_ftime;
-       __s32           di_mtime;
-       __s32           di_atime;
-       __s32           di_ctime;
+       __le32          di_xblk;
+       __le32          di_ftime;
+       __le32          di_mtime;
+       __le32          di_atime;
+       __le32          di_ctime;
        qnx4_nxtnt_t    di_num_xtnts;
        qnx4_mode_t     di_mode;
        qnx4_muid_t     di_uid;
        qnx4_nxtnt_t    di_num_xtnts;
        qnx4_mode_t     di_mode;
        qnx4_muid_t     di_uid;
@@ -63,18 +63,18 @@ struct qnx4_inode_entry {
 
 struct qnx4_link_info {
        char            dl_fname[QNX4_NAME_MAX];
 
 struct qnx4_link_info {
        char            dl_fname[QNX4_NAME_MAX];
-       __u32           dl_inode_blk;
+       __le32          dl_inode_blk;
        __u8            dl_inode_ndx;
        __u8            dl_spare[10];
        __u8            dl_status;
 };
 
 struct qnx4_xblk {
        __u8            dl_inode_ndx;
        __u8            dl_spare[10];
        __u8            dl_status;
 };
 
 struct qnx4_xblk {
-       __u32           xblk_next_xblk;
-       __u32           xblk_prev_xblk;
+       __le32          xblk_next_xblk;
+       __le32          xblk_prev_xblk;
        __u8            xblk_num_xtnts;
        __u8            xblk_spare[3];
        __u8            xblk_num_xtnts;
        __u8            xblk_spare[3];
-       __s32           xblk_num_blocks;
+       __le32          xblk_num_blocks;
        qnx4_xtnt_t     xblk_xtnts[QNX4_MAX_XTNTS_PER_XBLK];
        char            xblk_signature[8];
        qnx4_xtnt_t     xblk_first_xtnt;
        qnx4_xtnt_t     xblk_xtnts[QNX4_MAX_XTNTS_PER_XBLK];
        char            xblk_signature[8];
        qnx4_xtnt_t     xblk_first_xtnt;
index fb518e318c7c6209c57240a4a9517375884c3c9f..a3eb1137857b15ab616ab6a5e1352fe7e5a87eaf 100644 (file)
 #ifndef _QNX4TYPES_H
 #define _QNX4TYPES_H
 
 #ifndef _QNX4TYPES_H
 #define _QNX4TYPES_H
 
-typedef __u16 qnx4_nxtnt_t;
+typedef __le16 qnx4_nxtnt_t;
 typedef __u8  qnx4_ftype_t;
 
 typedef struct {
 typedef __u8  qnx4_ftype_t;
 
 typedef struct {
-       __u32 xtnt_blk;
-       __u32 xtnt_size;
+       __le32 xtnt_blk;
+       __le32 xtnt_size;
 } qnx4_xtnt_t;
 
 } qnx4_xtnt_t;
 
-typedef __u16 qnx4_mode_t;
-typedef __u16 qnx4_muid_t;
-typedef __u16 qnx4_mgid_t;
-typedef __u32 qnx4_off_t;
-typedef __u16 qnx4_nlink_t;
+typedef __le16 qnx4_mode_t;
+typedef __le16 qnx4_muid_t;
+typedef __le16 qnx4_mgid_t;
+typedef __le32 qnx4_off_t;
+typedef __le16 qnx4_nlink_t;
 
 #endif
 
 #endif