]> nv-tegra.nvidia Code Review - linux-3.10.git/commitdiff
[PATCH] ppc64: fix prom.c compile warning
authorPaul Mackerras <paulus@samba.org>
Fri, 6 May 2005 03:29:34 +0000 (13:29 +1000)
committerLinus Torvalds <torvalds@ppc970.osdl.org>
Fri, 6 May 2005 05:00:52 +0000 (22:00 -0700)
The code in unflatten_device_tree knows that get_property is written to
only return with lenp equal to 1 when also returning a valid pointer.
The gcc 3.3.3 compiler is not able to prove this to itself, so it warns
about a possible uninitialized pointer dereference:

 .../arch/ppc64/kernel/prom.c: In function `unflatten_device_tree':
 .../arch/ppc64/kernel/prom.c:828:
 warning: `p' might be used uninitialized in this function

Unless it is desired to rework the interaction between the two
functions, this will keep the existing behavior but quiet the compiler.

Signed-off-by: Amos Waterland <apw@us.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
arch/ppc64/kernel/prom.c

index fe2946c5831457f4baa36e55a7e4a13c20c9b552..eb6538b58008b641f06cd7fab3ca815b4ae4ca3d 100644 (file)
@@ -834,7 +834,7 @@ void __init unflatten_device_tree(void)
 {
        unsigned long start, mem, size;
        struct device_node **allnextp = &allnodes;
-       char *p;
+       char *p = NULL;
        int l = 0;
 
        DBG(" -> unflatten_device_tree()\n");