]> nv-tegra.nvidia Code Review - linux-3.10.git/commit
[PATCH] ppc64: fix prom.c compile warning
authorPaul Mackerras <paulus@samba.org>
Fri, 6 May 2005 03:29:34 +0000 (13:29 +1000)
committerLinus Torvalds <torvalds@ppc970.osdl.org>
Fri, 6 May 2005 05:00:52 +0000 (22:00 -0700)
commit3892c5fa9455670466f9f5518b3b7ef12ef3ccd6
tree4f2e43fd2efd413a9b45a90129e62516c0d16808
parent6741f3a7f9922391cd02b3ca1329e669497dc22f
[PATCH] ppc64: fix prom.c compile warning

The code in unflatten_device_tree knows that get_property is written to
only return with lenp equal to 1 when also returning a valid pointer.
The gcc 3.3.3 compiler is not able to prove this to itself, so it warns
about a possible uninitialized pointer dereference:

 .../arch/ppc64/kernel/prom.c: In function `unflatten_device_tree':
 .../arch/ppc64/kernel/prom.c:828:
 warning: `p' might be used uninitialized in this function

Unless it is desired to rework the interaction between the two
functions, this will keep the existing behavior but quiet the compiler.

Signed-off-by: Amos Waterland <apw@us.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
arch/ppc64/kernel/prom.c