]> nv-tegra.nvidia Code Review - linux-2.6.git/commitdiff
slab allocators: remove multiple alignment specifications
authorChristoph Lameter <clameter@sgi.com>
Sun, 6 May 2007 21:49:58 +0000 (14:49 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Mon, 7 May 2007 19:12:55 +0000 (12:12 -0700)
It is not necessary to tell the slab allocators to align to a cacheline
if an explicit alignment was already specified. It is rather confusing
to specify multiple alignments.

Make sure that the call sites only use one form of alignment.

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/powerpc/mm/hugetlbpage.c
arch/powerpc/mm/init_64.c
arch/sparc64/mm/tsb.c

index c8814177b7161b11ca65ebd7621f405429dc974b..d0ec887f05a23355f3ddf8fdb669f183a3fcf55c 100644 (file)
@@ -1057,7 +1057,7 @@ static int __init hugetlbpage_init(void)
        huge_pgtable_cache = kmem_cache_create("hugepte_cache",
                                               HUGEPTE_TABLE_SIZE,
                                               HUGEPTE_TABLE_SIZE,
-                                              SLAB_HWCACHE_ALIGN,
+                                              0,
                                               zero_ctor, NULL);
        if (! huge_pgtable_cache)
                panic("hugetlbpage_init(): could not create hugepte cache\n");
index 5a7750147b7d736fc680e52233905adadea9030b..4416d5140c53229acf03d5353f8aa6900e86b323 100644 (file)
@@ -183,7 +183,7 @@ void pgtable_cache_init(void)
                    "for size: %08x...\n", name, i, size);
                pgtable_cache[i] = kmem_cache_create(name,
                                                     size, size,
-                                                    SLAB_HWCACHE_ALIGN,
+                                                    0,
                                                     zero_ctor,
                                                     NULL);
                if (! pgtable_cache[i])
index 4be378d9a382e9ee72c9c494fa31e855cdeba510..8eb8a7c76ec92fc171208f7b1b4179afebd3f12d 100644 (file)
@@ -262,7 +262,7 @@ void __init pgtable_cache_init(void)
 
                tsb_caches[i] = kmem_cache_create(name,
                                                  size, size,
-                                                 SLAB_HWCACHE_ALIGN,
+                                                 0,
                                                  NULL, NULL);
                if (!tsb_caches[i]) {
                        prom_printf("Could not create %s cache\n", name);