sched: Fix cross-cpu clock sync on remote wakeups
authorPeter Zijlstra <a.p.zijlstra@chello.nl>
Tue, 31 May 2011 10:26:55 +0000 (12:26 +0200)
committerIngo Molnar <mingo@elte.hu>
Tue, 31 May 2011 12:19:56 +0000 (14:19 +0200)
Markus reported that commit 317f394160e ("sched: Move the second half
of ttwu() to the remote cpu") caused some accounting funnies on his AMD
Phenom II X4, such as weird 'top' results.

It turns out that this is due to non-synced TSC and the queued remote
wakeups stopped coupeling the two relevant cpu clocks, which leads to
wakeups seeing time jumps, which in turn lead to skewed runtime stats.

Add an explicit call to sched_clock_cpu() to couple the per-cpu clocks
to restore the normal flow of time.

Reported-and-tested-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1306835745.2353.3.camel@twins
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/sched.c

index cbb3a0eee58eb2c5c6748b949fca5579bbb57432..49cc70b152cf00e92e0ca4474204339773fb94e6 100644 (file)
@@ -2600,6 +2600,7 @@ static void ttwu_queue(struct task_struct *p, int cpu)
 
 #if defined(CONFIG_SMP)
        if (sched_feat(TTWU_QUEUE) && cpu != smp_processor_id()) {
 
 #if defined(CONFIG_SMP)
        if (sched_feat(TTWU_QUEUE) && cpu != smp_processor_id()) {
+               sched_clock_cpu(cpu); /* sync clocks x-cpu */
                ttwu_queue_remote(p, cpu);
                return;
        }
                ttwu_queue_remote(p, cpu);
                return;
        }