]> nv-tegra.nvidia Code Review - linux-2.6.git/commitdiff
NTFS: Use i_size_read() once and then use the cached value in
authorAnton Altaparmakov <aia21@cantab.net>
Thu, 11 Nov 2004 12:42:00 +0000 (12:42 +0000)
committerAnton Altaparmakov <aia21@cantab.net>
Wed, 4 May 2005 16:00:18 +0000 (17:00 +0100)
      fs/ntfs/lcnalloc.c::ntfs_cluster_alloc().

Signed-off-by: Anton Altaparmakov <aia21@cantab.net>
fs/ntfs/ChangeLog
fs/ntfs/lcnalloc.c

index b1a949401be38ca65f1e954b2c5fa48bcdf95889..ff0d9b132df8364c8d88b8d0ef4f0a22100d5e00 100644 (file)
@@ -31,6 +31,8 @@ ToDo/Notes:
          out.
        - Use i_size_read() in fs/ntfs/attrib.c::ntfs_attr_set().
        - Use i_size_read() in fs/ntfs/logfile.c::ntfs_{check,empty}_logfile().
+       - Use i_size_read() once and then use the cached value in
+         fs/ntfs/lcnalloc.c::ntfs_cluster_alloc().
 
 2.1.22 - Many bug and race fixes and error handling improvements.
 
index 23fd911078b1efc6c80ce65290ff8bdffc4e5631..5346596fa871baea1723a54c619830f84cdfb074 100644 (file)
@@ -140,6 +140,7 @@ runlist_element *ntfs_cluster_alloc(ntfs_volume *vol, const VCN start_vcn,
        LCN zone_start, zone_end, bmp_pos, bmp_initial_pos, last_read_pos, lcn;
        LCN prev_lcn = 0, prev_run_len = 0, mft_zone_size;
        s64 clusters;
+       loff_t i_size;
        struct inode *lcnbmp_vi;
        runlist_element *rl = NULL;
        struct address_space *mapping;
@@ -249,6 +250,7 @@ runlist_element *ntfs_cluster_alloc(ntfs_volume *vol, const VCN start_vcn,
        clusters = count;
        rlpos = rlsize = 0;
        mapping = lcnbmp_vi->i_mapping;
+       i_size = i_size_read(lcnbmp_vi);
        while (1) {
                ntfs_debug("Start of outer while loop: done_zones 0x%x, "
                                "search_zone %i, pass %i, zone_start 0x%llx, "
@@ -263,7 +265,7 @@ runlist_element *ntfs_cluster_alloc(ntfs_volume *vol, const VCN start_vcn,
                last_read_pos = bmp_pos >> 3;
                ntfs_debug("last_read_pos 0x%llx.",
                                (unsigned long long)last_read_pos);
-               if (last_read_pos > lcnbmp_vi->i_size) {
+               if (last_read_pos > i_size) {
                        ntfs_debug("End of attribute reached.  "
                                        "Skipping to zone_pass_done.");
                        goto zone_pass_done;
@@ -287,8 +289,8 @@ runlist_element *ntfs_cluster_alloc(ntfs_volume *vol, const VCN start_vcn,
                buf_size = last_read_pos & ~PAGE_CACHE_MASK;
                buf = page_address(page) + buf_size;
                buf_size = PAGE_CACHE_SIZE - buf_size;
-               if (unlikely(last_read_pos + buf_size > lcnbmp_vi->i_size))
-                       buf_size = lcnbmp_vi->i_size - last_read_pos;
+               if (unlikely(last_read_pos + buf_size > i_size))
+                       buf_size = i_size - last_read_pos;
                buf_size <<= 3;
                lcn = bmp_pos & 7;
                bmp_pos &= ~7;