]> nv-tegra.nvidia Code Review - linux-2.6.git/commitdiff
Pull trivial2 into release branch
authorLen Brown <len.brown@intel.com>
Fri, 16 Jun 2006 01:31:17 +0000 (21:31 -0400)
committerLen Brown <len.brown@intel.com>
Fri, 16 Jun 2006 01:31:17 +0000 (21:31 -0400)
arch/ia64/kernel/acpi.c
arch/ia64/mm/init.c
drivers/acpi/asus_acpi.c
drivers/acpi/processor_idle.c
drivers/acpi/thermal.c
drivers/acpi/utils.c

index 58c93a30348cdfdc43bd6b7c5acbf36245141b75..f97cc6c7f13abdd3773ee5f86e2fdd4d2518ea10 100644 (file)
@@ -68,8 +68,6 @@ EXPORT_SYMBOL(pm_power_off);
 unsigned char acpi_kbd_controller_present = 1;
 unsigned char acpi_legacy_devices;
 
-static unsigned int __initdata acpi_madt_rev;
-
 unsigned int acpi_cpei_override;
 unsigned int acpi_cpei_phys_cpuid;
 
@@ -243,6 +241,8 @@ acpi_parse_iosapic(acpi_table_entry_header * header, const unsigned long end)
        return iosapic_init(iosapic->address, iosapic->global_irq_base);
 }
 
+static unsigned int __initdata acpi_madt_rev;
+
 static int __init
 acpi_parse_plat_int_src(acpi_table_entry_header * header,
                        const unsigned long end)
index cafa8776a53dbbb41443d8b07a2d7e91bd7b4cea..11f08001f8c26e9aaa820b37d379d78eedac0bbd 100644 (file)
@@ -671,9 +671,11 @@ int add_memory(u64 start, u64 size)
 
        return ret;
 }
+EXPORT_SYMBOL_GPL(add_memory);
 
 int remove_memory(u64 start, u64 size)
 {
        return -EINVAL;
 }
+EXPORT_SYMBOL_GPL(remove_memory);
 #endif
index 90eb3c5a15cae8eae0d0d0acd296a39a838844ca..839f423d738d8618f8bc444b5707c672f833a5ac 100644 (file)
@@ -1245,7 +1245,7 @@ static int __init asus_acpi_init(void)
        if (!asus_hotk_found) {
                acpi_bus_unregister_driver(&asus_hotk_driver);
                remove_proc_entry(PROC_ASUS, acpi_root_dir);
-               return -ENODEV;
+               return result;
        }
 
        return 0;
index 80fa43471f484dd68c190d8726086a2e03cc00b3..3b97a5eae9e83d9e8676df512af7a8999770b01b 100644 (file)
@@ -54,10 +54,10 @@ ACPI_MODULE_NAME("acpi_processor")
 #define US_TO_PM_TIMER_TICKS(t)                ((t * (PM_TIMER_FREQUENCY/1000)) / 1000)
 #define C2_OVERHEAD                    4       /* 1us (3.579 ticks per us) */
 #define C3_OVERHEAD                    4       /* 1us (3.579 ticks per us) */
-static void (*pm_idle_save) (void);
+static void (*pm_idle_save) (void) __read_mostly;
 module_param(max_cstate, uint, 0644);
 
-static unsigned int nocst = 0;
+static unsigned int nocst __read_mostly;
 module_param(nocst, uint, 0000);
 
 /*
@@ -67,7 +67,7 @@ module_param(nocst, uint, 0000);
  * 100 HZ: 0x0000000F: 4 jiffies = 40ms
  * reduce history for more aggressive entry into C3
  */
-static unsigned int bm_history =
+static unsigned int bm_history __read_mostly =
     (HZ >= 800 ? 0xFFFFFFFF : ((1U << (HZ / 25)) - 1));
 module_param(bm_history, uint, 0644);
 /* --------------------------------------------------------------------------
@@ -1081,7 +1081,7 @@ int acpi_processor_power_init(struct acpi_processor *pr,
                              struct acpi_device *device)
 {
        acpi_status status = 0;
-       static int first_run = 0;
+       static int first_run;
        struct proc_dir_entry *entry = NULL;
        unsigned int i;
 
index a29af58cb4cd8771cc2d4a42b487db263f6e0541..f003763de7bbb684ffa9b59f08d89975f2b9ada2 100644 (file)
@@ -1343,7 +1343,7 @@ static int acpi_thermal_add(struct acpi_device *device)
 
        result = acpi_thermal_add_fs(device);
        if (result)
-               return_VALUE(result);
+               goto end;
 
        init_timer(&tz->timer);
 
index 6458c47f7ac202c5113fab82f2563f11d477bac8..6b516852ac12ac82d69515d6a3f98db96ed13c42 100644 (file)
@@ -273,11 +273,13 @@ acpi_evaluate_integer(acpi_handle handle,
        status = acpi_evaluate_object(handle, pathname, arguments, &buffer);
        if (ACPI_FAILURE(status)) {
                acpi_util_eval_error(handle, pathname, status);
+               kfree(element);
                return_ACPI_STATUS(status);
        }
 
        if (element->type != ACPI_TYPE_INTEGER) {
                acpi_util_eval_error(handle, pathname, AE_BAD_DATA);
+               kfree(element);
                return_ACPI_STATUS(AE_BAD_DATA);
        }