]> nv-tegra.nvidia Code Review - linux-2.6.git/commitdiff
pci: use pci_ioremap_bar() in drivers/misc
authorArjan van de Ven <arjan@linux.intel.com>
Tue, 6 Jan 2009 22:40:39 +0000 (14:40 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 6 Jan 2009 23:59:10 +0000 (15:59 -0800)
Use the newly introduced pci_ioremap_bar() function in drivers/misc.
pci_ioremap_bar() just takes a pci device and a bar number, with the goal
of making it really hard to get wrong, while also having a central place
to stick sanity checks.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/misc/ibmasm/module.c
drivers/misc/tifm_7xx1.c

index b5f6add34b0b9b4a39b587c51e3dc7079722c50a..dc14b0b9cbfa27ff0bfb0cc2e97ed93e0e8d52a7 100644 (file)
@@ -104,8 +104,7 @@ static int __devinit ibmasm_init_one(struct pci_dev *pdev, const struct pci_devi
        }
 
        sp->irq = pdev->irq;
-       sp->base_address = ioremap(pci_resource_start(pdev, 0),
-                                       pci_resource_len(pdev, 0));
+       sp->base_address = pci_ioremap_bar(pdev, 0);
        if (!sp->base_address) {
                dev_err(sp->dev, "Failed to ioremap pci memory\n");
                result =  -ENODEV;
index 67503ea71d218bc4c5ff67cdbd8afbb6e2c94a7d..af6173319e070c9f041506bced6e38c7edac701a 100644 (file)
@@ -354,8 +354,7 @@ static int tifm_7xx1_probe(struct pci_dev *dev,
        fm->has_ms_pif = tifm_7xx1_has_ms_pif;
        pci_set_drvdata(dev, fm);
 
-       fm->addr = ioremap(pci_resource_start(dev, 0),
-                          pci_resource_len(dev, 0));
+       fm->addr = pci_ioremap_bar(dev, 0);
        if (!fm->addr)
                goto err_out_free;