]> nv-tegra.nvidia Code Review - linux-2.6.git/commitdiff
xen: check EFER for NX before setting up GDT mapping
authorJeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Mon, 21 Sep 2009 20:34:06 +0000 (13:34 -0700)
committerJeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Mon, 21 Sep 2009 20:49:43 +0000 (13:49 -0700)
x86-64 assumes NX is available by default, so we need to
explicitly check for it before using NX.  Some first-generation
Intel x86-64 processors didn't support NX, and even recent systems
allow it to be disabled in BIOS.

[ Impact: prevent Xen crash on NX-less 64-bit machines ]

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Cc: Stable Kernel <stable@kernel.org>
arch/x86/mm/Makefile
arch/x86/xen/enlighten.c

index 9b5a9f59a478781bd32025a938826e9c239e0d17..dd313d035de7eb7430cf5ae95c8d894fc2b04063 100644 (file)
@@ -4,6 +4,7 @@ obj-y   :=  init.o init_$(BITS).o fault.o ioremap.o extable.o pageattr.o mmap.o \
 # Make sure __phys_addr has no stackprotector
 nostackp := $(call cc-option, -fno-stack-protector)
 CFLAGS_physaddr.o              := $(nostackp)
 # Make sure __phys_addr has no stackprotector
 nostackp := $(call cc-option, -fno-stack-protector)
 CFLAGS_physaddr.o              := $(nostackp)
+CFLAGS_init.o                  := $(nostackp)
 
 obj-$(CONFIG_SMP)              += tlb.o
 
 
 obj-$(CONFIG_SMP)              += tlb.o
 
index 0dd0c2c6cae0ff1fb8aa1ce563636e7ad38ad880..5d701bf66a23993ca29fc623254ab8ecbe7bec56 100644 (file)
@@ -1083,6 +1083,11 @@ asmlinkage void __init xen_start_kernel(void)
 
        __supported_pte_mask |= _PAGE_IOMAP;
 
 
        __supported_pte_mask |= _PAGE_IOMAP;
 
+#ifdef CONFIG_X86_64
+       /* Work out if we support NX */
+       check_efer();
+#endif
+
        xen_setup_features();
 
        /* Get mfn list */
        xen_setup_features();
 
        /* Get mfn list */
@@ -1123,11 +1128,6 @@ asmlinkage void __init xen_start_kernel(void)
 
        pgd = (pgd_t *)xen_start_info->pt_base;
 
 
        pgd = (pgd_t *)xen_start_info->pt_base;
 
-#ifdef CONFIG_X86_64
-       /* Work out if we support NX */
-       check_efer();
-#endif
-
        /* Don't do the full vcpu_info placement stuff until we have a
           possible map and a non-dummy shared_info. */
        per_cpu(xen_vcpu, 0) = &HYPERVISOR_shared_info->vcpu_info[0];
        /* Don't do the full vcpu_info placement stuff until we have a
           possible map and a non-dummy shared_info. */
        per_cpu(xen_vcpu, 0) = &HYPERVISOR_shared_info->vcpu_info[0];