]> nv-tegra.nvidia Code Review - linux-2.6.git/commitdiff
genirq: NULL struct irq_desc's member 'name' in dynamic_irq_cleanup()
authorDean Nelson <dcn@sgi.com>
Sat, 18 Oct 2008 23:06:56 +0000 (16:06 -0700)
committerIngo Molnar <mingo@elte.hu>
Tue, 21 Oct 2008 13:59:21 +0000 (15:59 +0200)
If the member 'name' of the irq_desc structure happens to point to a
character string that is resident within a kernel module, problems ensue
if that module is rmmod'd (at which time dynamic_irq_cleanup() is called)
and then later show_interrupts() is called by someone.

It is also not a good thing if the character string resided in kmalloc'd
space that has been kfree'd (after having called dynamic_irq_cleanup()).
dynamic_irq_cleanup() fails to NULL the 'name' member and
show_interrupts() references it on a few architectures (like h8300, sh and

Signed-off-by: Dean Nelson <dcn@sgi.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

index 3de6ea3ee7403af33371f924dfa46229cf702bc9..10b5092e9bfe749da57b2ab408e3f6d38ae81d75 100644 (file)
@@ -76,6 +76,7 @@ void dynamic_irq_cleanup(unsigned int irq)
        desc->chip_data = NULL;
        desc->handle_irq = handle_bad_irq;
        desc->chip = &no_irq_chip;
+       desc->name = NULL;
        spin_unlock_irqrestore(&desc->lock, flags);