]> nv-tegra.nvidia Code Review - linux-2.6.git/commitdiff
via-velocity: fix memory corruption when changing the mtu
authorFrancois Romieu <romieu@fr.zoreil.com>
Mon, 27 Feb 2006 22:11:08 +0000 (23:11 +0100)
committerFrancois Romieu <romieu@fr.zoreil.com>
Mon, 27 Feb 2006 22:11:08 +0000 (23:11 +0100)
velocity_rx_refill() only replenishes the descriptor entries which
belong to the CPU. It works great in the Rx path but the driver must
ensure that all the descriptors are freed before velocity_rx_refill()
is used in velocity_change_mtu(). The patch resets the Rx descriptors
in velocity_free_rd_ring().

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
drivers/net/via-velocity.c

index c2d5907dc8e054edd6ecab18bdc954cfbfd1554b..ed1f837c8fda2274a3874855550f1d39e81f1bcd 100644 (file)
@@ -1106,6 +1106,9 @@ static void velocity_free_rd_ring(struct velocity_info *vptr)
 
        for (i = 0; i < vptr->options.numrx; i++) {
                struct velocity_rd_info *rd_info = &(vptr->rd_info[i]);
+               struct rx_desc *rd = vptr->rd_ring + i;
+
+               memset(rd, 0, sizeof(*rd));
 
                if (!rd_info->skb)
                        continue;