]> nv-tegra.nvidia Code Review - linux-2.6.git/commitdiff
[PATCH] __group_complete_signal: remove bogus BUG_ON
authorOleg Nesterov <oleg@tv-sign.ru>
Tue, 11 Apr 2006 18:18:58 +0000 (22:18 +0400)
committerLinus Torvalds <torvalds@g5.osdl.org>
Tue, 11 Apr 2006 14:34:01 +0000 (07:34 -0700)
Commit e56d090310d7625ecb43a1eeebd479f04affb48b

   [PATCH] RCU signal handling

made this BUG_ON() unsafe. This code runs under ->siglock,
while switch_exec_pids() takes tasklist_lock.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
kernel/signal.c

index 5ccaac505e8dabd792eab331cf4e80bfa9a5f4cf..b14f895027c3491cbb0283b2dd7a9d055d35b570 100644 (file)
@@ -868,7 +868,6 @@ __group_complete_signal(int sig, struct task_struct *p)
                if (t == NULL)
                        /* restart balancing at this thread */
                        t = p->signal->curr_target = p;
-               BUG_ON(t->tgid != p->tgid);
 
                while (!wants_signal(sig, t)) {
                        t = next_thread(t);