]> nv-tegra.nvidia Code Review - linux-2.6.git/commitdiff
[PATCH] v9fs: fix fid check in v9fs_create
authorLatchesar Ionkov <lucho@ionkov.net>
Wed, 28 Jun 2006 11:26:51 +0000 (04:26 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Wed, 28 Jun 2006 21:59:05 +0000 (14:59 -0700)
Fix an incorrect check whether a fid was allocated in v9fs_create and if it
should be freed on error.

Signed-off-by: Latchesar Ionkov <lucho@ionkov.net>
Cc: Eric Van Hensbergen <ericvh@ericvh.myip.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/9p/vfs_inode.c

index 5c6bdf82146c3618caeae2f9ff5a1f2832e89fae..2f580a197b8dadf573ce7093742e4e647c950c82 100644 (file)
@@ -300,7 +300,7 @@ clunk_fid:
        fid = V9FS_NOFID;
 
 put_fid:
-       if (fid >= 0)
+       if (fid != V9FS_NOFID)
                v9fs_put_idpool(fid, &v9ses->fidpool);
 
        kfree(fcall);