]> nv-tegra.nvidia Code Review - linux-2.6.git/commitdiff
[PATCH] uml: restore include breakage, breaking binary format of COW driver
authorPaolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Sun, 9 Oct 2005 19:37:35 +0000 (21:37 +0200)
committerLinus Torvalds <torvalds@g5.osdl.org>
Mon, 10 Oct 2005 15:36:00 +0000 (08:36 -0700)
Commit 44456d37b59d8e541936ed26d8b6e08d27e88ac1, between 2.6.13-rc3 and -rc4,
was a "nice cleanup" which broke something. Revert the offending part.

It broke because:
a) because this part doesn't fall under the description
b) the author didn't know what he was doing here
c) the author didn't try to compile the existing code and see that it worked
d) the author didn't ask us what was happening
e) you didn't either, and somebody there should have learned that UML is a bit

In fact, UML is special in linking to host libc and using its includes.

In particular, since host includes always define both __BIG_ENDIAN and
__LITTLE_ENDIAN, ntohll() macros started thinking to be in a big-endian world;
and on-disk compatibility was broken.

Many thanks go to Nix for reporting the problem and correctly diagnosing an
endianness problem.

Btw, this patch restores the previous code, which worked; but the definitions
would be uncorrect if used in kernelspace files.

Next patch addresses that.

Cc: Nix <nix@esperi.org.uk>, Olaf Hering <olh@suse.de>
Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

index 4fcf3a8d13f4a356ee8e8d8a4d341d0d37aeb3c8..4fcbe8b1b77e112767c3a144d6d08fbdf97768d3 100644 (file)
@@ -3,10 +3,10 @@
 #include <asm/types.h>
-#if defined(__BIG_ENDIAN)
 # define ntohll(x) (x)
 # define htonll(x) (x)
-#elif defined(__LITTLE_ENDIAN)
 # define ntohll(x)  bswap_64(x)
 # define htonll(x)  bswap_64(x)