]> nv-tegra.nvidia Code Review - linux-2.6.git/commitdiff
move wm8400-regulator's probe function to .devinit.text
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 12 Jan 2009 22:25:05 +0000 (23:25 +0100)
committerLiam Girdwood <lrg@slimlogic.co.uk>
Sat, 17 Jan 2009 13:46:40 +0000 (13:46 +0000)
A pointer to wm8400_regulator_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded.  Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.

An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
drivers/regulator/wm8400-regulator.c

index 48b372e038a8092cd1f8c8f1a783f44d126c6cd7..56e23d44ba591383696ec9382a1a3c4b05ae32a9 100644 (file)
@@ -289,7 +289,7 @@ static struct regulator_desc regulators[] = {
        },
 };
 
-static int __init wm8400_regulator_probe(struct platform_device *pdev)
+static int __devinit wm8400_regulator_probe(struct platform_device *pdev)
 {
        struct regulator_dev *rdev;