[PATCH] synclink_gt: make ->init_error signed
authorDarren Jenkins <darrenrjenkins@gmail.com>
Wed, 1 Mar 2006 00:59:20 +0000 (16:59 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Wed, 1 Mar 2006 04:53:44 +0000 (20:53 -0800)
Examples of misuse are

3112 info->init_error = -1;

4440 if ((info->init_error = register_test(info)) < 0) {

Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Acked-by: Paul Fulghum <paulkf@microgate.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/char/synclink_gt.c

index a85a60a93deb27358e7a7d7d9e6806c3bedacafe..b046390cd256cd92b166878f362868e421d986be 100644 (file)
@@ -306,7 +306,7 @@ struct slgt_info {
        int tx_active;
 
        unsigned char signals;    /* serial signal states */
        int tx_active;
 
        unsigned char signals;    /* serial signal states */
-       unsigned int init_error;  /* initialization error */
+       int init_error;  /* initialization error */
 
        unsigned char *tx_buf;
        int tx_count;
 
        unsigned char *tx_buf;
        int tx_count;