]> nv-tegra.nvidia Code Review - linux-2.6.git/commitdiff
[PATCH] cs5520: fix return value of cs5520_init_one()
authorAmit Gud <amitg@calsoftinc.com>
Fri, 18 Nov 2005 22:03:19 +0000 (23:03 +0100)
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Fri, 18 Nov 2005 22:03:19 +0000 (23:03 +0100)
From: Amit Gud <amitg@calsoftinc.com>

Patch follows from the suggestions by AC and Felipe W Damasio for fixing the
return codes from IDE drivers.

[ bart: fix coding style while at it ]

Signed-off-by: Amit Gud <gud@eth.net>
Signed-off-by: Domen Puncer <domen@coderock.org>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
drivers/ide/pci/cs5520.c

index 7dc24682d197d44a4be32da254b0beb7b190e3fc..ea3c52cc8ac1cf5c55aad7d31267d6f5d2142a00 100644 (file)
@@ -222,10 +222,9 @@ static int __devinit cs5520_init_one(struct pci_dev *dev, const struct pci_devic
 
        /* We must not grab the entire device, it has 'ISA' space in its
           BARS too and we will freak out other bits of the kernel */
-       if(pci_enable_device_bars(dev, 1<<2))
-       {
+       if (pci_enable_device_bars(dev, 1<<2)) {
                printk(KERN_WARNING "%s: Unable to enable 55x0.\n", d->name);
-               return 1;
+               return -ENODEV;
        }
        pci_set_master(dev);
        if (pci_set_dma_mask(dev, DMA_32BIT_MASK)) {