]> nv-tegra.nvidia Code Review - linux-2.6.git/commitdiff
omap: rng: Use resource_size instead of manual calculation
authorTobias Klauser <tklauser@distanz.ch>
Thu, 24 Sep 2009 23:23:18 +0000 (16:23 -0700)
committerTony Lindgren <tony@atomide.com>
Thu, 24 Sep 2009 23:23:18 +0000 (16:23 -0700)
Use the resource_size function instead of manually calculating the
resource size. This reduces the chance of introducing off-by-one-errors.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
drivers/char/hw_random/omap-rng.c

index 00dd3de1be51ef341c7c7a3819f0537d529a2ebd..06aad0831c73f5ec4c08746798fba27f59c8ff98 100644 (file)
@@ -116,7 +116,7 @@ static int __devinit omap_rng_probe(struct platform_device *pdev)
        if (!res)
                return -ENOENT;
 
-       mem = request_mem_region(res->start, res->end - res->start + 1,
+       mem = request_mem_region(res->start, resource_size(res),
                                 pdev->name);
        if (mem == NULL) {
                ret = -EBUSY;
@@ -124,7 +124,7 @@ static int __devinit omap_rng_probe(struct platform_device *pdev)
        }
 
        dev_set_drvdata(&pdev->dev, mem);
-       rng_base = ioremap(res->start, res->end - res->start + 1);
+       rng_base = ioremap(res->start, resource_size(res));
        if (!rng_base) {
                ret = -ENOMEM;
                goto err_ioremap;