]> nv-tegra.nvidia Code Review - linux-2.6.git/commitdiff
mfd: Fix incorrect kfree(i2c) in tps6507x i2c_driver probe
authorAxel Lin <axel.lin@gmail.com>
Mon, 9 Aug 2010 06:49:46 +0000 (14:49 +0800)
committerSamuel Ortiz <sameo@linux.intel.com>
Thu, 12 Aug 2010 09:28:12 +0000 (11:28 +0200)
The i2c_client received in probe() should not be kfree()'d.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/mfd/tps6507x.c

index d859dffed39f009d8b68c6a069d8f589341a36c2..fc01976492816dc7b1cb4570be0d1aad79734569 100644 (file)
@@ -89,10 +89,8 @@ static int tps6507x_i2c_probe(struct i2c_client *i2c,
        int ret = 0;
 
        tps6507x = kzalloc(sizeof(struct tps6507x_dev), GFP_KERNEL);
-       if (tps6507x == NULL) {
-               kfree(i2c);
+       if (tps6507x == NULL)
                return -ENOMEM;
-       }
 
        i2c_set_clientdata(i2c, tps6507x);
        tps6507x->dev = &i2c->dev;