]> nv-tegra.nvidia Code Review - linux-2.6.git/commit
tracing: Fix lockdep warning in global_clock()
authorLi Zefan <lizf@cn.fujitsu.com>
Wed, 24 Mar 2010 02:57:37 +0000 (10:57 +0800)
committerSteven Rostedt <rostedt@goodmis.org>
Mon, 29 Mar 2010 19:16:44 +0000 (15:16 -0400)
commite36673ec5126f15a8cddf6049aede7bdcf484c26
tree020070456e2875bc2293c36b4fb7415e4d717199
parentb72c40949b0f04728f2993a1434598d3bad094ea
tracing: Fix lockdep warning in global_clock()

# echo 1 > events/enable
 # echo global > trace_clock

------------[ cut here ]------------
WARNING: at kernel/lockdep.c:3162 check_flags+0xb2/0x190()
...
---[ end trace 3f86734a89416623 ]---
possible reason: unannotated irqs-on.
...

There's no reason to use the raw_local_irq_save() in trace_clock_global.
The local_irq_save() version is fine, and does not cause the bug in lockdep.

Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
LKML-Reference: <4BA97FA1.7030606@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace_clock.c