]> nv-tegra.nvidia Code Review - linux-2.6.git/commit
[PATCH] remove TTY_DONT_FLIP
authorPaul Fulghum <paulkf@microgate.com>
Wed, 28 Jun 2006 11:26:47 +0000 (04:26 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Wed, 28 Jun 2006 21:59:05 +0000 (14:59 -0700)
commit817d6d3bceaf34c99f5343820f9b9e6021f0655c
tree651104833124262db46c2a372b7adb55289cd8dd
parente0ac4761fa52acda90f9f53819c81474b511e3af
[PATCH] remove TTY_DONT_FLIP

Remove TTY_DONT_FLIP tty flag.  This flag was introduced in 2.1.X kernels
to prevent the N_TTY line discipline functions read_chan() and
n_tty_receive_buf() from running at the same time.  2.2.15 introduced
tty->read_lock to protect access to the N_TTY read buffer, which is the
only state requiring protection between these two functions.

The current TTY_DONT_FLIP implementation is broken for SMP, and is not
universally honored by drivers that send data directly to the line
discipline receive_buf function.

Because TTY_DONT_FLIP is not necessary, is broken in implementation, and is
not universally honored, it is removed.

Signed-off-by: Paul Fulghum <paulkf@microgate.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/char/mxser.c
drivers/char/n_tty.c
drivers/char/pty.c
drivers/char/tty_io.c
drivers/serial/crisv10.c
drivers/serial/jsm/jsm_tty.c
drivers/usb/serial/ir-usb.c
include/linux/tty.h
net/bluetooth/rfcomm/tty.c