]> nv-tegra.nvidia Code Review - linux-2.6.git/commit
slab allocators: Remove SLAB_CTOR_ATOMIC
authorChristoph Lameter <clameter@sgi.com>
Sun, 6 May 2007 21:50:17 +0000 (14:50 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Mon, 7 May 2007 19:12:57 +0000 (12:12 -0700)
commit4f104934591ed98534b3a4c3d17d972b790e9c42
tree149d7ba5ab6b9b7f8a82eb3ce41cb36f28bccaf9
parent50953fe9e00ebbeffa032a565ab2f08312d51a87
slab allocators: Remove SLAB_CTOR_ATOMIC

SLAB_CTOR atomic is never used which is no surprise since I cannot imagine
that one would want to do something serious in a constructor or destructor.
 In particular given that the slab allocators run with interrupts disabled.
 Actions in constructors and destructors are by their nature very limited
and usually do not go beyond initializing variables and list operations.

(The i386 pgd ctor and dtors do take a spinlock in constructor and
destructor.....  I think that is the furthest we go at this point.)

There is no flag passed to the destructor so removing SLAB_CTOR_ATOMIC also
establishes a certain symmetry.

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/linux/slab.h
mm/slab.c
mm/slub.c