]> nv-tegra.nvidia Code Review - linux-2.6.git/commit
pty: reconnect the BSD TIOCSPTLCK handling to legacy ptys
authorLinus Torvalds <torvalds@linux-foundation.org>
Wed, 30 Sep 2009 14:49:40 +0000 (07:49 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 30 Sep 2009 14:49:40 +0000 (07:49 -0700)
commit342a597146e8639f7c8d49f056340c2e5536dda6
treebe6ef41a9c2b595a79e088c976932314facceb9f
parente207e143e2fb6a2790b1ce3687c8aedc3ddc357b
pty: reconnect the BSD TIOCSPTLCK handling to legacy ptys

David Howells noticed (due to the compiler warning about an unused
'pty_ops_bsd' variable) that we haven't actually been using the code
that implements TIOCSPTLCK for legacy pty handling.  It's been that way
since 2.6.26, commit 3e8e88ca053150efdbecb45d8f481cf560ec808d to be
exact ("pty: prepare for tty->ops changes").

DavidH initially submitted a patch just removing the dead code entirely,
and since nobody has apparently ever complained, I'm not entirely sure
that wouldn't be the right thing to do.  But since the whole and only
point of the legacy pty code is to be compatible with legacy distros
that don't use the new unix98 pty model, let's just wire it up again.

And clean it up a bit while we're at it.

Acked-by: David Howells <dhowells@redhat.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/char/pty.c