]> nv-tegra.nvidia Code Review - linux-2.6.git/commit
[PATCH] remove active field from tty buffer structure
authorPaul Fulghum <paulkf@microgate.com>
Wed, 28 Jun 2006 11:26:49 +0000 (04:26 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Wed, 28 Jun 2006 21:59:05 +0000 (14:59 -0700)
commit33b37a33c242542fac2980b8ccd90977388b7a8d
treee3a18605e57e1d1268dd04e9a3e5276f7f0488fe
parent2c3bb20f46709a0adfa7ea408013edbcab945d5a
[PATCH] remove active field from tty buffer structure

Remove 'active' field from tty buffer structure.  This was added in 2.6.16
as part of a patch to make the new tty buffering SMP safe.  This field is
unnecessary with the more intelligently written flush_to_ldisc that adds
receive_room handling.

Removing this field reverts to simpler logic where the tail buffer is
always the 'active' buffer, which should not be freed by flush_to_ldisc.
(active == buffer being filled with new data)

The result is simpler, smaller, and faster tty buffer code.

Signed-off-by: Paul Fulghum <paulkf@microgate.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/char/tty_io.c
include/linux/kbd_kern.h
include/linux/tty.h
include/linux/tty_flip.h