]> nv-tegra.nvidia Code Review - linux-2.6.git/blobdiff - drivers/mtd/chips/jedec_probe.c
mtd: change struct flchip_shared spinlock locking into mutex
[linux-2.6.git] / drivers / mtd / chips / jedec_probe.c
index 8db1148dfa470e0bc6c3e4d051a2395d2e8a0043..d72a5fb2d041eb7f57a4257c9de708d061f63e35 100644 (file)
 #include <linux/mtd/cfi.h>
 #include <linux/mtd/gen_probe.h>
 
-/* Manufacturers */
-#define MANUFACTURER_AMD       0x0001
-#define MANUFACTURER_ATMEL     0x001f
-#define MANUFACTURER_EON       0x001c
-#define MANUFACTURER_FUJITSU   0x0004
-#define MANUFACTURER_HYUNDAI   0x00AD
-#define MANUFACTURER_INTEL     0x0089
-#define MANUFACTURER_MACRONIX  0x00C2
-#define MANUFACTURER_NEC       0x0010
-#define MANUFACTURER_PMC       0x009D
-#define MANUFACTURER_SHARP     0x00b0
-#define MANUFACTURER_SST       0x00BF
-#define MANUFACTURER_ST                0x0020
-#define MANUFACTURER_TOSHIBA   0x0098
-#define MANUFACTURER_WINBOND   0x00da
-#define CONTINUATION_CODE      0x007f
-
-
 /* AMD */
 #define AM29DL800BB    0x22CB
 #define AM29DL800BT    0x224A
 #define SST39LF160     0x2782
 #define SST39VF1601    0x234b
 #define SST39VF3201    0x235b
+#define SST39WF1601    0x274b
+#define SST39WF1602    0x274a
 #define SST39LF512     0x00D4
 #define SST39LF010     0x00D5
 #define SST39LF020     0x00D6
@@ -309,7 +293,7 @@ struct amd_flash_info {
  */
 static const struct amd_flash_info jedec_table[] = {
        {
-               .mfr_id         = MANUFACTURER_AMD,
+               .mfr_id         = CFI_MFR_AMD,
                .dev_id         = AM29F032B,
                .name           = "AMD AM29F032B",
                .uaddr          = MTD_UADDR_0x0555_0x02AA,
@@ -321,7 +305,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,64)
                }
        }, {
-               .mfr_id         = MANUFACTURER_AMD,
+               .mfr_id         = CFI_MFR_AMD,
                .dev_id         = AM29LV160DT,
                .name           = "AMD AM29LV160DT",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -336,7 +320,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x04000,1)
                }
        }, {
-               .mfr_id         = MANUFACTURER_AMD,
+               .mfr_id         = CFI_MFR_AMD,
                .dev_id         = AM29LV160DB,
                .name           = "AMD AM29LV160DB",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -351,7 +335,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,31)
                }
        }, {
-               .mfr_id         = MANUFACTURER_AMD,
+               .mfr_id         = CFI_MFR_AMD,
                .dev_id         = AM29LV400BB,
                .name           = "AMD AM29LV400BB",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -366,7 +350,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,7)
                }
        }, {
-               .mfr_id         = MANUFACTURER_AMD,
+               .mfr_id         = CFI_MFR_AMD,
                .dev_id         = AM29LV400BT,
                .name           = "AMD AM29LV400BT",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -381,7 +365,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x04000,1)
                }
        }, {
-               .mfr_id         = MANUFACTURER_AMD,
+               .mfr_id         = CFI_MFR_AMD,
                .dev_id         = AM29LV800BB,
                .name           = "AMD AM29LV800BB",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -397,7 +381,7 @@ static const struct amd_flash_info jedec_table[] = {
                }
        }, {
 /* add DL */
-               .mfr_id         = MANUFACTURER_AMD,
+               .mfr_id         = CFI_MFR_AMD,
                .dev_id         = AM29DL800BB,
                .name           = "AMD AM29DL800BB",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -414,7 +398,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,14)
                }
        }, {
-               .mfr_id         = MANUFACTURER_AMD,
+               .mfr_id         = CFI_MFR_AMD,
                .dev_id         = AM29DL800BT,
                .name           = "AMD AM29DL800BT",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -431,7 +415,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x04000,1)
                }
        }, {
-               .mfr_id         = MANUFACTURER_AMD,
+               .mfr_id         = CFI_MFR_AMD,
                .dev_id         = AM29F800BB,
                .name           = "AMD AM29F800BB",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -446,7 +430,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,15),
                }
        }, {
-               .mfr_id         = MANUFACTURER_AMD,
+               .mfr_id         = CFI_MFR_AMD,
                .dev_id         = AM29LV800BT,
                .name           = "AMD AM29LV800BT",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -461,7 +445,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x04000,1)
                }
        }, {
-               .mfr_id         = MANUFACTURER_AMD,
+               .mfr_id         = CFI_MFR_AMD,
                .dev_id         = AM29F800BT,
                .name           = "AMD AM29F800BT",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -476,7 +460,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x04000,1)
                }
        }, {
-               .mfr_id         = MANUFACTURER_AMD,
+               .mfr_id         = CFI_MFR_AMD,
                .dev_id         = AM29F017D,
                .name           = "AMD AM29F017D",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -488,7 +472,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,32),
                }
        }, {
-               .mfr_id         = MANUFACTURER_AMD,
+               .mfr_id         = CFI_MFR_AMD,
                .dev_id         = AM29F016D,
                .name           = "AMD AM29F016D",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -500,7 +484,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,32),
                }
        }, {
-               .mfr_id         = MANUFACTURER_AMD,
+               .mfr_id         = CFI_MFR_AMD,
                .dev_id         = AM29F080,
                .name           = "AMD AM29F080",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -512,7 +496,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,16),
                }
        }, {
-               .mfr_id         = MANUFACTURER_AMD,
+               .mfr_id         = CFI_MFR_AMD,
                .dev_id         = AM29F040,
                .name           = "AMD AM29F040",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -524,7 +508,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,8),
                }
        }, {
-               .mfr_id         = MANUFACTURER_AMD,
+               .mfr_id         = CFI_MFR_AMD,
                .dev_id         = AM29LV040B,
                .name           = "AMD AM29LV040B",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -536,7 +520,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,8),
                }
        }, {
-               .mfr_id         = MANUFACTURER_AMD,
+               .mfr_id         = CFI_MFR_AMD,
                .dev_id         = AM29F002T,
                .name           = "AMD AM29F002T",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -551,7 +535,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x04000,1),
                }
        }, {
-               .mfr_id         = MANUFACTURER_AMD,
+               .mfr_id         = CFI_MFR_AMD,
                .dev_id         = AM29SL800DT,
                .name           = "AMD AM29SL800DT",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -566,7 +550,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x04000,1),
                }
        }, {
-               .mfr_id         = MANUFACTURER_AMD,
+               .mfr_id         = CFI_MFR_AMD,
                .dev_id         = AM29SL800DB,
                .name           = "AMD AM29SL800DB",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -581,7 +565,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,15),
                }
        }, {
-               .mfr_id         = MANUFACTURER_ATMEL,
+               .mfr_id         = CFI_MFR_ATMEL,
                .dev_id         = AT49BV512,
                .name           = "Atmel AT49BV512",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -593,7 +577,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,1)
                }
        }, {
-               .mfr_id         = MANUFACTURER_ATMEL,
+               .mfr_id         = CFI_MFR_ATMEL,
                .dev_id         = AT29LV512,
                .name           = "Atmel AT29LV512",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -606,7 +590,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x80,256)
                }
        }, {
-               .mfr_id         = MANUFACTURER_ATMEL,
+               .mfr_id         = CFI_MFR_ATMEL,
                .dev_id         = AT49BV16X,
                .name           = "Atmel AT49BV16X",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -619,7 +603,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,31)
                }
        }, {
-               .mfr_id         = MANUFACTURER_ATMEL,
+               .mfr_id         = CFI_MFR_ATMEL,
                .dev_id         = AT49BV16XT,
                .name           = "Atmel AT49BV16XT",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -632,7 +616,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x02000,8)
                }
        }, {
-               .mfr_id         = MANUFACTURER_ATMEL,
+               .mfr_id         = CFI_MFR_ATMEL,
                .dev_id         = AT49BV32X,
                .name           = "Atmel AT49BV32X",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -645,7 +629,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,63)
                }
        }, {
-               .mfr_id         = MANUFACTURER_ATMEL,
+               .mfr_id         = CFI_MFR_ATMEL,
                .dev_id         = AT49BV32XT,
                .name           = "Atmel AT49BV32XT",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -658,7 +642,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x02000,8)
                }
        }, {
-               .mfr_id         = MANUFACTURER_EON,
+               .mfr_id         = CFI_MFR_EON,
                .dev_id         = EN29SL800BT,
                .name           = "Eon EN29SL800BT",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -673,7 +657,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x04000,1),
                }
        }, {
-               .mfr_id         = MANUFACTURER_EON,
+               .mfr_id         = CFI_MFR_EON,
                .dev_id         = EN29SL800BB,
                .name           = "Eon EN29SL800BB",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -688,7 +672,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,15),
                }
        }, {
-               .mfr_id         = MANUFACTURER_FUJITSU,
+               .mfr_id         = CFI_MFR_FUJITSU,
                .dev_id         = MBM29F040C,
                .name           = "Fujitsu MBM29F040C",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -700,7 +684,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,8)
                }
        }, {
-               .mfr_id         = MANUFACTURER_FUJITSU,
+               .mfr_id         = CFI_MFR_FUJITSU,
                .dev_id         = MBM29F800BA,
                .name           = "Fujitsu MBM29F800BA",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -715,7 +699,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,15),
                }
        }, {
-               .mfr_id         = MANUFACTURER_FUJITSU,
+               .mfr_id         = CFI_MFR_FUJITSU,
                .dev_id         = MBM29LV650UE,
                .name           = "Fujitsu MBM29LV650UE",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -727,7 +711,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,128)
                }
        }, {
-               .mfr_id         = MANUFACTURER_FUJITSU,
+               .mfr_id         = CFI_MFR_FUJITSU,
                .dev_id         = MBM29LV320TE,
                .name           = "Fujitsu MBM29LV320TE",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -740,7 +724,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x02000,8)
                }
        }, {
-               .mfr_id         = MANUFACTURER_FUJITSU,
+               .mfr_id         = CFI_MFR_FUJITSU,
                .dev_id         = MBM29LV320BE,
                .name           = "Fujitsu MBM29LV320BE",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -753,7 +737,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,63)
                }
        }, {
-               .mfr_id         = MANUFACTURER_FUJITSU,
+               .mfr_id         = CFI_MFR_FUJITSU,
                .dev_id         = MBM29LV160TE,
                .name           = "Fujitsu MBM29LV160TE",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -768,7 +752,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x04000,1)
                }
        }, {
-               .mfr_id         = MANUFACTURER_FUJITSU,
+               .mfr_id         = CFI_MFR_FUJITSU,
                .dev_id         = MBM29LV160BE,
                .name           = "Fujitsu MBM29LV160BE",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -783,7 +767,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,31)
                }
        }, {
-               .mfr_id         = MANUFACTURER_FUJITSU,
+               .mfr_id         = CFI_MFR_FUJITSU,
                .dev_id         = MBM29LV800BA,
                .name           = "Fujitsu MBM29LV800BA",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -798,7 +782,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,15)
                }
        }, {
-               .mfr_id         = MANUFACTURER_FUJITSU,
+               .mfr_id         = CFI_MFR_FUJITSU,
                .dev_id         = MBM29LV800TA,
                .name           = "Fujitsu MBM29LV800TA",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -813,7 +797,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x04000,1)
                }
        }, {
-               .mfr_id         = MANUFACTURER_FUJITSU,
+               .mfr_id         = CFI_MFR_FUJITSU,
                .dev_id         = MBM29LV400BC,
                .name           = "Fujitsu MBM29LV400BC",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -828,7 +812,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,7)
                }
        }, {
-               .mfr_id         = MANUFACTURER_FUJITSU,
+               .mfr_id         = CFI_MFR_FUJITSU,
                .dev_id         = MBM29LV400TC,
                .name           = "Fujitsu MBM29LV400TC",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -843,7 +827,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x04000,1)
                }
        }, {
-               .mfr_id         = MANUFACTURER_HYUNDAI,
+               .mfr_id         = CFI_MFR_HYUNDAI,
                .dev_id         = HY29F002T,
                .name           = "Hyundai HY29F002T",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -858,7 +842,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x04000,1),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F004B3B,
                .name           = "Intel 28F004B3B",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -871,7 +855,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000, 7),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F004B3T,
                .name           = "Intel 28F004B3T",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -884,7 +868,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x02000, 8),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F400B3B,
                .name           = "Intel 28F400B3B",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -897,7 +881,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000, 7),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F400B3T,
                .name           = "Intel 28F400B3T",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -910,7 +894,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x02000, 8),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F008B3B,
                .name           = "Intel 28F008B3B",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -923,7 +907,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000, 15),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F008B3T,
                .name           = "Intel 28F008B3T",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -936,7 +920,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x02000, 8),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F008S5,
                .name           = "Intel 28F008S5",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -948,7 +932,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,16),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F016S5,
                .name           = "Intel 28F016S5",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -960,7 +944,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,32),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F008SA,
                .name           = "Intel 28F008SA",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -972,7 +956,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000, 16),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F800B3B,
                .name           = "Intel 28F800B3B",
                .devtypes       = CFI_DEVICETYPE_X16,
@@ -985,7 +969,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000, 15),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F800B3T,
                .name           = "Intel 28F800B3T",
                .devtypes       = CFI_DEVICETYPE_X16,
@@ -998,7 +982,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x02000, 8),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F016B3B,
                .name           = "Intel 28F016B3B",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1011,7 +995,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000, 31),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F016S3,
                .name           = "Intel I28F016S3",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1023,7 +1007,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000, 32),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F016B3T,
                .name           = "Intel 28F016B3T",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1036,7 +1020,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x02000, 8),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F160B3B,
                .name           = "Intel 28F160B3B",
                .devtypes       = CFI_DEVICETYPE_X16,
@@ -1049,7 +1033,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000, 31),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F160B3T,
                .name           = "Intel 28F160B3T",
                .devtypes       = CFI_DEVICETYPE_X16,
@@ -1062,7 +1046,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x02000, 8),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F320B3B,
                .name           = "Intel 28F320B3B",
                .devtypes       = CFI_DEVICETYPE_X16,
@@ -1075,7 +1059,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000, 63),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F320B3T,
                .name           = "Intel 28F320B3T",
                .devtypes       = CFI_DEVICETYPE_X16,
@@ -1088,7 +1072,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x02000, 8),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F640B3B,
                .name           = "Intel 28F640B3B",
                .devtypes       = CFI_DEVICETYPE_X16,
@@ -1101,7 +1085,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000, 127),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F640B3T,
                .name           = "Intel 28F640B3T",
                .devtypes       = CFI_DEVICETYPE_X16,
@@ -1114,7 +1098,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x02000, 8),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I28F640C3B,
                .name           = "Intel 28F640C3B",
                .devtypes       = CFI_DEVICETYPE_X16,
@@ -1127,7 +1111,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000, 127),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I82802AB,
                .name           = "Intel 82802AB",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1139,7 +1123,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,8),
                }
        }, {
-               .mfr_id         = MANUFACTURER_INTEL,
+               .mfr_id         = CFI_MFR_INTEL,
                .dev_id         = I82802AC,
                .name           = "Intel 82802AC",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1151,7 +1135,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,16),
                }
        }, {
-               .mfr_id         = MANUFACTURER_MACRONIX,
+               .mfr_id         = CFI_MFR_MACRONIX,
                .dev_id         = MX29LV040C,
                .name           = "Macronix MX29LV040C",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1163,7 +1147,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,8),
                }
        }, {
-               .mfr_id         = MANUFACTURER_MACRONIX,
+               .mfr_id         = CFI_MFR_MACRONIX,
                .dev_id         = MX29LV160T,
                .name           = "MXIC MX29LV160T",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -1178,7 +1162,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x04000,1)
                }
        }, {
-               .mfr_id         = MANUFACTURER_NEC,
+               .mfr_id         = CFI_MFR_NEC,
                .dev_id         = UPD29F064115,
                .name           = "NEC uPD29F064115",
                .devtypes       = CFI_DEVICETYPE_X16,
@@ -1192,7 +1176,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x2000,8),
                }
        }, {
-               .mfr_id         = MANUFACTURER_MACRONIX,
+               .mfr_id         = CFI_MFR_MACRONIX,
                .dev_id         = MX29LV160B,
                .name           = "MXIC MX29LV160B",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -1207,7 +1191,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,31)
                }
        }, {
-               .mfr_id         = MANUFACTURER_MACRONIX,
+               .mfr_id         = CFI_MFR_MACRONIX,
                .dev_id         = MX29F040,
                .name           = "Macronix MX29F040",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1219,7 +1203,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,8),
                }
        }, {
-               .mfr_id         = MANUFACTURER_MACRONIX,
+               .mfr_id         = CFI_MFR_MACRONIX,
                .dev_id         = MX29F016,
                .name           = "Macronix MX29F016",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1231,7 +1215,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,32),
                }
        }, {
-               .mfr_id         = MANUFACTURER_MACRONIX,
+               .mfr_id         = CFI_MFR_MACRONIX,
                .dev_id         = MX29F004T,
                .name           = "Macronix MX29F004T",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1246,7 +1230,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x04000,1),
                }
        }, {
-               .mfr_id         = MANUFACTURER_MACRONIX,
+               .mfr_id         = CFI_MFR_MACRONIX,
                .dev_id         = MX29F004B,
                .name           = "Macronix MX29F004B",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1261,7 +1245,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,7),
                }
        }, {
-               .mfr_id         = MANUFACTURER_MACRONIX,
+               .mfr_id         = CFI_MFR_MACRONIX,
                .dev_id         = MX29F002T,
                .name           = "Macronix MX29F002T",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1276,7 +1260,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x04000,1),
                }
        }, {
-               .mfr_id         = MANUFACTURER_PMC,
+               .mfr_id         = CFI_MFR_PMC,
                .dev_id         = PM49FL002,
                .name           = "PMC Pm49FL002",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1288,7 +1272,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO( 0x01000, 64 )
                }
        }, {
-               .mfr_id         = MANUFACTURER_PMC,
+               .mfr_id         = CFI_MFR_PMC,
                .dev_id         = PM49FL004,
                .name           = "PMC Pm49FL004",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1300,7 +1284,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO( 0x01000, 128 )
                }
        }, {
-               .mfr_id         = MANUFACTURER_PMC,
+               .mfr_id         = CFI_MFR_PMC,
                .dev_id         = PM49FL008,
                .name           = "PMC Pm49FL008",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1312,7 +1296,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO( 0x01000, 256 )
                }
        }, {
-               .mfr_id         = MANUFACTURER_SHARP,
+               .mfr_id         = CFI_MFR_SHARP,
                .dev_id         = LH28F640BF,
                .name           = "LH28F640BF",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1324,7 +1308,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x40000,16),
                }
        }, {
-               .mfr_id         = MANUFACTURER_SST,
+               .mfr_id         = CFI_MFR_SST,
                .dev_id         = SST39LF512,
                .name           = "SST 39LF512",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1336,7 +1320,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x01000,16),
                }
        }, {
-               .mfr_id         = MANUFACTURER_SST,
+               .mfr_id         = CFI_MFR_SST,
                .dev_id         = SST39LF010,
                .name           = "SST 39LF010",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1348,8 +1332,8 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x01000,32),
                }
        }, {
-               .mfr_id         = MANUFACTURER_SST,
-               .dev_id         = SST29EE020,
+               .mfr_id         = CFI_MFR_SST,
+               .dev_id         = SST29EE020,
                .name           = "SST 29EE020",
                .devtypes       = CFI_DEVICETYPE_X8,
                .uaddr          = MTD_UADDR_0x5555_0x2AAA,
@@ -1359,9 +1343,9 @@ static const struct amd_flash_info jedec_table[] = {
                .regions = {ERASEINFO(0x01000,64),
                }
        }, {
-               .mfr_id         = MANUFACTURER_SST,
+               .mfr_id         = CFI_MFR_SST,
                .dev_id         = SST29LE020,
-               .name           = "SST 29LE020",
+               .name           = "SST 29LE020",
                .devtypes       = CFI_DEVICETYPE_X8,
                .uaddr          = MTD_UADDR_0x5555_0x2AAA,
                .dev_size       = SIZE_256KiB,
@@ -1370,7 +1354,7 @@ static const struct amd_flash_info jedec_table[] = {
                .regions = {ERASEINFO(0x01000,64),
                }
        }, {
-               .mfr_id         = MANUFACTURER_SST,
+               .mfr_id         = CFI_MFR_SST,
                .dev_id         = SST39LF020,
                .name           = "SST 39LF020",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1382,7 +1366,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x01000,64),
                }
        }, {
-               .mfr_id         = MANUFACTURER_SST,
+               .mfr_id         = CFI_MFR_SST,
                .dev_id         = SST39LF040,
                .name           = "SST 39LF040",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1394,7 +1378,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x01000,128),
                }
        }, {
-               .mfr_id         = MANUFACTURER_SST,
+               .mfr_id         = CFI_MFR_SST,
                .dev_id         = SST39SF010A,
                .name           = "SST 39SF010A",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1406,7 +1390,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x01000,32),
                }
        }, {
-               .mfr_id         = MANUFACTURER_SST,
+               .mfr_id         = CFI_MFR_SST,
                .dev_id         = SST39SF020A,
                .name           = "SST 39SF020A",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1418,7 +1402,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x01000,64),
                }
        }, {
-               .mfr_id         = MANUFACTURER_SST,
+               .mfr_id         = CFI_MFR_SST,
                .dev_id         = SST39SF040,
                .name           = "SST 39SF040",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1430,7 +1414,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x01000,128),
                }
        }, {
-               .mfr_id         = MANUFACTURER_SST,
+               .mfr_id         = CFI_MFR_SST,
                .dev_id         = SST49LF040B,
                .name           = "SST 49LF040B",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1443,7 +1427,7 @@ static const struct amd_flash_info jedec_table[] = {
                }
        }, {
 
-               .mfr_id         = MANUFACTURER_SST,
+               .mfr_id         = CFI_MFR_SST,
                .dev_id         = SST49LF004B,
                .name           = "SST 49LF004B",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1455,7 +1439,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x01000,128),
                }
        }, {
-               .mfr_id         = MANUFACTURER_SST,
+               .mfr_id         = CFI_MFR_SST,
                .dev_id         = SST49LF008A,
                .name           = "SST 49LF008A",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1467,7 +1451,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x01000,256),
                }
        }, {
-               .mfr_id         = MANUFACTURER_SST,
+               .mfr_id         = CFI_MFR_SST,
                .dev_id         = SST49LF030A,
                .name           = "SST 49LF030A",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1479,7 +1463,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x01000,96),
                }
        }, {
-               .mfr_id         = MANUFACTURER_SST,
+               .mfr_id         = CFI_MFR_SST,
                .dev_id         = SST49LF040A,
                .name           = "SST 49LF040A",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1491,7 +1475,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x01000,128),
                }
        }, {
-               .mfr_id         = MANUFACTURER_SST,
+               .mfr_id         = CFI_MFR_SST,
                .dev_id         = SST49LF080A,
                .name           = "SST 49LF080A",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1503,7 +1487,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x01000,256),
                }
        }, {
-               .mfr_id         = MANUFACTURER_SST,     /* should be CFI */
+               .mfr_id         = CFI_MFR_SST,     /* should be CFI */
                .dev_id         = SST39LF160,
                .name           = "SST 39LF160",
                .devtypes       = CFI_DEVICETYPE_X16,
@@ -1516,7 +1500,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x1000,256)
                }
        }, {
-               .mfr_id         = MANUFACTURER_SST,     /* should be CFI */
+               .mfr_id         = CFI_MFR_SST,     /* should be CFI */
                .dev_id         = SST39VF1601,
                .name           = "SST 39VF1601",
                .devtypes       = CFI_DEVICETYPE_X16,
@@ -1529,7 +1513,35 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x1000,256)
                }
        }, {
-               .mfr_id         = MANUFACTURER_SST,     /* should be CFI */
+               /* CFI is broken: reports AMD_STD, but needs custom uaddr */
+               .mfr_id         = CFI_MFR_SST,
+               .dev_id         = SST39WF1601,
+               .name           = "SST 39WF1601",
+               .devtypes       = CFI_DEVICETYPE_X16,
+               .uaddr          = MTD_UADDR_0xAAAA_0x5555,
+               .dev_size       = SIZE_2MiB,
+               .cmd_set        = P_ID_AMD_STD,
+               .nr_regions     = 2,
+               .regions        = {
+                       ERASEINFO(0x1000,256),
+                       ERASEINFO(0x1000,256)
+               }
+       }, {
+               /* CFI is broken: reports AMD_STD, but needs custom uaddr */
+               .mfr_id         = CFI_MFR_SST,
+               .dev_id         = SST39WF1602,
+               .name           = "SST 39WF1602",
+               .devtypes       = CFI_DEVICETYPE_X16,
+               .uaddr          = MTD_UADDR_0xAAAA_0x5555,
+               .dev_size       = SIZE_2MiB,
+               .cmd_set        = P_ID_AMD_STD,
+               .nr_regions     = 2,
+               .regions        = {
+                       ERASEINFO(0x1000,256),
+                       ERASEINFO(0x1000,256)
+               }
+       }, {
+               .mfr_id         = CFI_MFR_SST,     /* should be CFI */
                .dev_id         = SST39VF3201,
                .name           = "SST 39VF3201",
                .devtypes       = CFI_DEVICETYPE_X16,
@@ -1544,7 +1556,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x1000,256)
                }
        }, {
-               .mfr_id         = MANUFACTURER_SST,
+               .mfr_id         = CFI_MFR_SST,
                .dev_id         = SST36VF3203,
                .name           = "SST 36VF3203",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -1556,7 +1568,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,64),
                }
        }, {
-               .mfr_id         = MANUFACTURER_ST,
+               .mfr_id         = CFI_MFR_ST,
                .dev_id         = M29F800AB,
                .name           = "ST M29F800AB",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -1571,7 +1583,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,15),
                }
        }, {
-               .mfr_id         = MANUFACTURER_ST,      /* FIXME - CFI device? */
+               .mfr_id         = CFI_MFR_ST,   /* FIXME - CFI device? */
                .dev_id         = M29W800DT,
                .name           = "ST M29W800DT",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -1586,7 +1598,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x04000,1)
                }
        }, {
-               .mfr_id         = MANUFACTURER_ST,      /* FIXME - CFI device? */
+               .mfr_id         = CFI_MFR_ST,   /* FIXME - CFI device? */
                .dev_id         = M29W800DB,
                .name           = "ST M29W800DB",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -1601,7 +1613,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,15)
                }
        },  {
-               .mfr_id         = MANUFACTURER_ST,
+               .mfr_id         = CFI_MFR_ST,
                .dev_id         = M29W400DT,
                .name           = "ST M29W400DT",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -1616,7 +1628,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,1)
                }
        }, {
-               .mfr_id         = MANUFACTURER_ST,
+               .mfr_id         = CFI_MFR_ST,
                .dev_id         = M29W400DB,
                .name           = "ST M29W400DB",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -1631,7 +1643,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,7)
                }
        }, {
-               .mfr_id         = MANUFACTURER_ST,      /* FIXME - CFI device? */
+               .mfr_id         = CFI_MFR_ST,   /* FIXME - CFI device? */
                .dev_id         = M29W160DT,
                .name           = "ST M29W160DT",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -1646,7 +1658,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x04000,1)
                }
        }, {
-               .mfr_id         = MANUFACTURER_ST,      /* FIXME - CFI device? */
+               .mfr_id         = CFI_MFR_ST,   /* FIXME - CFI device? */
                .dev_id         = M29W160DB,
                .name           = "ST M29W160DB",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -1661,7 +1673,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,31)
                }
        }, {
-               .mfr_id         = MANUFACTURER_ST,
+               .mfr_id         = CFI_MFR_ST,
                .dev_id         = M29W040B,
                .name           = "ST M29W040B",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1673,7 +1685,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,8),
                }
        }, {
-               .mfr_id         = MANUFACTURER_ST,
+               .mfr_id         = CFI_MFR_ST,
                .dev_id         = M50FW040,
                .name           = "ST M50FW040",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1685,7 +1697,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,8),
                }
        }, {
-               .mfr_id         = MANUFACTURER_ST,
+               .mfr_id         = CFI_MFR_ST,
                .dev_id         = M50FW080,
                .name           = "ST M50FW080",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1697,7 +1709,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,16),
                }
        }, {
-               .mfr_id         = MANUFACTURER_ST,
+               .mfr_id         = CFI_MFR_ST,
                .dev_id         = M50FW016,
                .name           = "ST M50FW016",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1709,7 +1721,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,32),
                }
        }, {
-               .mfr_id         = MANUFACTURER_ST,
+               .mfr_id         = CFI_MFR_ST,
                .dev_id         = M50LPW080,
                .name           = "ST M50LPW080",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1721,7 +1733,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,16),
                },
        }, {
-               .mfr_id         = MANUFACTURER_ST,
+               .mfr_id         = CFI_MFR_ST,
                .dev_id         = M50FLW080A,
                .name           = "ST M50FLW080A",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1736,7 +1748,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x1000,16),
                }
        }, {
-               .mfr_id         = MANUFACTURER_ST,
+               .mfr_id         = CFI_MFR_ST,
                .dev_id         = M50FLW080B,
                .name           = "ST M50FLW080B",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1751,7 +1763,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x1000,16),
                }
        }, {
-               .mfr_id         = 0xff00 | MANUFACTURER_ST,
+               .mfr_id         = 0xff00 | CFI_MFR_ST,
                .dev_id         = 0xff00 | PSD4256G6V,
                .name           = "ST PSD4256G6V",
                .devtypes       = CFI_DEVICETYPE_X16,
@@ -1763,7 +1775,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,16),
                }
        }, {
-               .mfr_id         = MANUFACTURER_TOSHIBA,
+               .mfr_id         = CFI_MFR_TOSHIBA,
                .dev_id         = TC58FVT160,
                .name           = "Toshiba TC58FVT160",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -1778,7 +1790,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x04000,1)
                }
        }, {
-               .mfr_id         = MANUFACTURER_TOSHIBA,
+               .mfr_id         = CFI_MFR_TOSHIBA,
                .dev_id         = TC58FVB160,
                .name           = "Toshiba TC58FVB160",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -1793,7 +1805,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,31)
                }
        }, {
-               .mfr_id         = MANUFACTURER_TOSHIBA,
+               .mfr_id         = CFI_MFR_TOSHIBA,
                .dev_id         = TC58FVB321,
                .name           = "Toshiba TC58FVB321",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -1806,7 +1818,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,63)
                }
        }, {
-               .mfr_id         = MANUFACTURER_TOSHIBA,
+               .mfr_id         = CFI_MFR_TOSHIBA,
                .dev_id         = TC58FVT321,
                .name           = "Toshiba TC58FVT321",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -1819,7 +1831,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x02000,8)
                }
        }, {
-               .mfr_id         = MANUFACTURER_TOSHIBA,
+               .mfr_id         = CFI_MFR_TOSHIBA,
                .dev_id         = TC58FVB641,
                .name           = "Toshiba TC58FVB641",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -1832,7 +1844,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x10000,127)
                }
        }, {
-               .mfr_id         = MANUFACTURER_TOSHIBA,
+               .mfr_id         = CFI_MFR_TOSHIBA,
                .dev_id         = TC58FVT641,
                .name           = "Toshiba TC58FVT641",
                .devtypes       = CFI_DEVICETYPE_X16|CFI_DEVICETYPE_X8,
@@ -1845,7 +1857,7 @@ static const struct amd_flash_info jedec_table[] = {
                        ERASEINFO(0x02000,8)
                }
        }, {
-               .mfr_id         = MANUFACTURER_WINBOND,
+               .mfr_id         = CFI_MFR_WINBOND,
                .dev_id         = W49V002A,
                .name           = "Winbond W49V002A",
                .devtypes       = CFI_DEVICETYPE_X8,
@@ -1878,7 +1890,7 @@ static inline u32 jedec_read_mfr(struct map_info *map, uint32_t base,
                mask = (1 << (cfi->device_type * 8)) - 1;
                result = map_read(map, base + ofs);
                bank++;
-       } while ((result.x[0] & mask) == CONTINUATION_CODE);
+       } while ((result.x[0] & mask) == CFI_MFR_CONTINUATION);
 
        return result.x[0] & mask;
 }
@@ -1969,7 +1981,7 @@ static int cfi_jedec_setup(struct cfi_private *p_cfi, int index)
        p_cfi->addr_unlock1 = unlock_addrs[uaddr].addr1 / p_cfi->device_type;
        p_cfi->addr_unlock2 = unlock_addrs[uaddr].addr2 / p_cfi->device_type;
 
-       return 1;       /* ok */
+       return 1;       /* ok */
 }