perf evlist: Pass struct perf_target to perf_evlist__prepare_workload()
Namhyung Kim [Mon, 11 Mar 2013 07:43:15 +0000 (16:43 +0900)]
It's a preparation step of removing @opts arg from the function so that
it can be used more widely.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1362987798-24969-4-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

tools/perf/builtin-record.c
tools/perf/builtin-trace.c
tools/perf/tests/perf-record.c
tools/perf/util/evlist.c
tools/perf/util/evlist.h

index e3261ea..a803017 100644 (file)
@@ -474,7 +474,8 @@ static int __cmd_record(struct perf_record *rec, int argc, const char **argv)
        }
 
        if (forks) {
-               err = perf_evlist__prepare_workload(evsel_list, opts, argv);
+               err = perf_evlist__prepare_workload(evsel_list, &opts->target,
+                                                   opts, argv);
                if (err < 0) {
                        pr_err("Couldn't run the workload!\n");
                        goto out_delete_session;
index 6198eb1..1de3971 100644 (file)
@@ -461,7 +461,8 @@ static int trace__run(struct trace *trace, int argc, const char **argv)
        signal(SIGINT, sig_handler);
 
        if (forks) {
-               err = perf_evlist__prepare_workload(evlist, &trace->opts, argv);
+               err = perf_evlist__prepare_workload(evlist, &trace->opts.target,
+                                                   &trace->opts, argv);
                if (err < 0) {
                        printf("Couldn't run the workload!\n");
                        goto out_delete_evlist;
index f6ba75a..adf6b4a 100644 (file)
@@ -93,7 +93,7 @@ int test__PERF_RECORD(void)
         * so that we have time to open the evlist (calling sys_perf_event_open
         * on all the fds) and then mmap them.
         */
-       err = perf_evlist__prepare_workload(evlist, &opts, argv);
+       err = perf_evlist__prepare_workload(evlist, &opts.target, &opts, argv);
        if (err < 0) {
                pr_debug("Couldn't run the workload!\n");
                goto out_delete_maps;
index 7d71a69..291884c 100644 (file)
@@ -745,6 +745,7 @@ out_err:
 }
 
 int perf_evlist__prepare_workload(struct perf_evlist *evlist,
+                                 struct perf_target *target,
                                  struct perf_record_opts *opts,
                                  const char *argv[])
 {
@@ -800,7 +801,7 @@ int perf_evlist__prepare_workload(struct perf_evlist *evlist,
                exit(-1);
        }
 
-       if (perf_target__none(&opts->target))
+       if (perf_target__none(target))
                evlist->threads->map[0] = evlist->workload.pid;
 
        close(child_ready_pipe[1]);
index 9a7b76e..e089906 100644 (file)
@@ -86,6 +86,7 @@ void perf_evlist__config(struct perf_evlist *evlist,
                         struct perf_record_opts *opts);
 
 int perf_evlist__prepare_workload(struct perf_evlist *evlist,
+                                 struct perf_target *target,
                                  struct perf_record_opts *opts,
                                  const char *argv[]);
 int perf_evlist__start_workload(struct perf_evlist *evlist);