[POWERPC] Don't cast a struct pointer to list_head pointer
Li Zefan [Thu, 6 Dec 2007 09:33:14 +0000 (20:33 +1100)]
The casting is safe only when the list_head member is the first member
of the structure, and even then it is better to use the address of the
list_head structure member.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>

arch/ppc/syslib/ocp.c

index 3f5be2c..d42d408 100644 (file)
@@ -376,7 +376,7 @@ ocp_remove_one_device(unsigned int vendor, unsigned int function, int index)
 
        down_write(&ocp_devices_sem);
        dev = __ocp_find_device(vendor, function, index);
-       list_del((struct list_head *)dev);
+       list_del(&dev->link);
        up_write(&ocp_devices_sem);
 
        DBG(("ocp: ocp_remove_one_device(vendor: %x, function: %x, index: %d)... done.\n", vendor, function, index));