tools/hv: Fix permissions of created directory and files
Ben Hutchings [Tue, 27 Nov 2012 07:56:34 +0000 (08:56 +0100)]
It's silly to create directories without execute permission, or to
give permissions to 'other' but not the group-owner.

Write the permissions in octal and 'ls -l' format since these are much
easier to read than the named macros.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Tomas Hozza <thozza@redhat.com>
Acked-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

tools/hv/hv_kvp_daemon.c

index 5c052db..0358ad2 100644 (file)
@@ -235,7 +235,7 @@ static int kvp_file_init(void)
        int alloc_unit = sizeof(struct kvp_record) * ENTRIES_PER_BLOCK;
 
        if (access(KVP_CONFIG_LOC, F_OK)) {
-               if (mkdir(KVP_CONFIG_LOC, S_IRUSR | S_IWUSR | S_IROTH)) {
+               if (mkdir(KVP_CONFIG_LOC, 0755 /* rwxr-xr-x */)) {
                        syslog(LOG_ERR, " Failed to create %s", KVP_CONFIG_LOC);
                        exit(EXIT_FAILURE);
                }
@@ -246,7 +246,7 @@ static int kvp_file_init(void)
                records_read = 0;
                num_blocks = 1;
                sprintf(fname, "%s/.kvp_pool_%d", KVP_CONFIG_LOC, i);
-               fd = open(fname, O_RDWR | O_CREAT, S_IRUSR | S_IWUSR | S_IROTH);
+               fd = open(fname, O_RDWR | O_CREAT, 0644 /* rw-r--r-- */);
 
                if (fd == -1)
                        return 1;