]> nv-tegra.nvidia Code Review - linux-3.10.git/commit
[PATCH] sched: less locking
authorNick Piggin <nickpiggin@yahoo.com.au>
Sat, 10 Sep 2005 07:26:18 +0000 (00:26 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sat, 10 Sep 2005 17:06:23 +0000 (10:06 -0700)
commite17224bf1d01b461ec02a60f5a9b7657a89bdd23
tree30dbb20798fde88a09680e9d82bd32ad8c343692
parentd6d5cfaf4551aa7713ca6ab73bb77e832602204b
[PATCH] sched: less locking

During periodic load balancing, don't hold this runqueue's lock while
scanning remote runqueues, which can take a non trivial amount of time
especially on very large systems.

Holding the runqueue lock will only help to stabilise ->nr_running, however
this doesn't do much to help because tasks being woken will simply get held
up on the runqueue lock, so ->nr_running would not provide a really
accurate picture of runqueue load in that case anyway.

What's more, ->nr_running (and possibly the cpu_load averages) of remote
runqueues won't be stable anyway, so load balancing is always an inexact
operation.

Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
kernel/sched.c