]> nv-tegra.nvidia Code Review - linux-2.6.git/commit
x86/PCI: fix broken ISA DMA
authorTakashi Iwai <tiwai@suse.de>
Fri, 9 May 2008 06:06:55 +0000 (08:06 +0200)
committerJesse Barnes <jbarnes@virtuousgeek.org>
Tue, 13 May 2008 16:51:53 +0000 (09:51 -0700)
commit4a367f3a9dbf2e7ffcee4702203479809236ee6e
tree8481ac4f6d916f7d4322d3cee235131f537819c8
parent21e2b0a5efb3a01de58e7cb630f2eb70894da352
x86/PCI: fix broken ISA DMA

Rene Herman reported:

> commit 8779f2fc3b84ebb6c5181fb13d702e9944c16069
>
> "x86: don't try to allocate from DMA zone at first"
>
> breaks all of ISA DMA. Or all of ALSA ISA DMA at least. All
> ISA soundcards are silent following that commit -- no error
> messages, everything appears fine, just silence.

That patch is buggy. We had an implicit assumption that
dev = NULL for ISA devices that require 24bit DMA.

The recent work on x86 dma_alloc_coherent() breaks the ISA DMA buffer
allocation, which is represented by "dev = NULL" and requires 24bit
DMA implicitly.

Bisected-by: Rene Herman <rene.herman@keyaccess.nl>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
arch/x86/kernel/pci-dma.c