sfc: Change order of device removal to reverse of probe order
Ben Hutchings [Fri, 23 Oct 2009 08:31:37 +0000 (08:31 +0000)]
This makes efx_pci_remove_main() more obviously the inverse of
efx_pci_probe_main(), and matches our out-of-tree driver.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

drivers/net/sfc/efx.c

index 8b67553..862e483 100644 (file)
@@ -2025,12 +2025,12 @@ static void efx_pci_remove_main(struct efx_nic *efx)
        if (!efx->membase)
                return;
 
+       falcon_fini_interrupt(efx);
        efx_fini_channels(efx);
        efx_fini_port(efx);
 
        /* Shutdown the board, then the NIC and board state */
        efx->board_info.fini(efx);
-       falcon_fini_interrupt(efx);
 
        efx_fini_napi(efx);
        efx_remove_all(efx);