[NETFILTER]: Decrease number of pointer derefs in nf_conntrack_core.c
Jesper Juhl [Thu, 5 Jan 2006 20:16:16 +0000 (12:16 -0800)]
Benefits of the patch:
 - Fewer pointer dereferences should make the code slightly faster.
 - Size of generated code is smaller
 - improved readability

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

net/netfilter/nf_conntrack_core.c

index a7c7b49..0c5b01d 100644 (file)
@@ -1129,6 +1129,7 @@ static inline int refresh_timer(struct nf_conntrack_expect *i)
 int nf_conntrack_expect_related(struct nf_conntrack_expect *expect)
 {
        struct nf_conntrack_expect *i;
+       struct nf_conn *master = expect->master;
        int ret;
 
        DEBUGP("nf_conntrack_expect_related %p\n", related_to);
@@ -1149,9 +1150,9 @@ int nf_conntrack_expect_related(struct nf_conntrack_expect *expect)
                }
        }
        /* Will be over limit? */
-       if (expect->master->helper->max_expected && 
-           expect->master->expecting >= expect->master->helper->max_expected)
-               evict_oldest_expect(expect->master);
+       if (master->helper->max_expected && 
+           master->expecting >= master->helper->max_expected)
+               evict_oldest_expect(master);
 
        nf_conntrack_expect_insert(expect);
        nf_conntrack_expect_event(IPEXP_NEW, expect);