[PATCH] sound/oss/sonicvibes.c: fix an array overflow
Adrian Bunk [Sun, 1 May 2005 15:59:30 +0000 (08:59 -0700)]
This patch fixes an array overflow found by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

sound/oss/sonicvibes.c

index e1d6961..06047e7 100644 (file)
@@ -1149,7 +1149,7 @@ static int mixer_ioctl(struct sv_state *s, unsigned int cmd, unsigned long arg)
                        if (mixtable[i].rec)
                                break;
                }
-               if (!mixtable[i].rec)
+               if (i == SOUND_MIXER_NRDEVICES)
                        return 0;
                spin_lock_irqsave(&s->lock, flags);
                frobindir(s, SV_CIMIX_ADCINL, 0x1f, mixtable[i].rec << 5);