[SCSI] scsi_dh: create sysfs file, dh_state for all SCSI disk devices
Chandra Seetharaman [Fri, 11 Sep 2009 17:20:35 +0000 (10:20 -0700)]
Create the sysfs file, dh_state even if the new SCSI device is not
in the any of the device handler's internal lists.

Signed-Off-by: Chandra Seetharaman <sekharan@us.ibm.com>
Acked-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>

drivers/scsi/device_handler/scsi_dh.c

index 6f7f798..e19a1a5 100644 (file)
@@ -304,18 +304,15 @@ static int scsi_dh_notifier(struct notifier_block *nb,
        sdev = to_scsi_device(dev);
 
        if (action == BUS_NOTIFY_ADD_DEVICE) {
+               err = device_create_file(dev, &scsi_dh_state_attr);
+               /* don't care about err */
                devinfo = device_handler_match(NULL, sdev);
-               if (!devinfo)
-                       goto out;
-
-               err = scsi_dh_handler_attach(sdev, devinfo);
-               if (!err)
-                       err = device_create_file(dev, &scsi_dh_state_attr);
+               if (devinfo)
+                       err = scsi_dh_handler_attach(sdev, devinfo);
        } else if (action == BUS_NOTIFY_DEL_DEVICE) {
                device_remove_file(dev, &scsi_dh_state_attr);
                scsi_dh_handler_detach(sdev, NULL);
        }
-out:
        return err;
 }