[PATCH] ptrace_h8300: condition bugfix
Domen Puncer [Thu, 23 Jun 2005 07:08:47 +0000 (00:08 -0700)]
Assignment doesn't make much sense here as condition would always be true.

Signed-off-by: Domen Puncer <domen@coderock.org>
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

arch/h8300/platform/h8300h/ptrace_h8300h.c

index 18e51a7..6ac93c0 100644 (file)
@@ -245,12 +245,12 @@ static unsigned short *getnextpc(struct task_struct *child, unsigned short *pc)
                                                addr = h8300_get_reg(child, regno-1+PT_ER1);
                                        return (unsigned short *)addr;
                                case relb:
-                                       if ((inst = 0x55) || isbranch(child,inst & 0x0f))
+                                       if (inst == 0x55 || isbranch(child,inst & 0x0f))
                                                pc = (unsigned short *)((unsigned long)pc +
                                                                       ((signed char)(*fetch_p)));
                                        return pc+1; /* skip myself */
                                case relw:
-                                       if ((inst = 0x5c) || isbranch(child,(*fetch_p & 0xf0) >> 4))
+                                       if (inst == 0x5c || isbranch(child,(*fetch_p & 0xf0) >> 4))
                                                pc = (unsigned short *)((unsigned long)pc +
                                                                       ((signed short)(*(pc+1))));
                                        return pc+2; /* skip myself */