perf buildid-list: Always show the DSO name
Arnaldo Carvalho de Melo [Mon, 16 Nov 2009 23:45:25 +0000 (21:45 -0200)]
Porcelain can ignore it, humans can make more sense of it.

Suggested-by: Frederic Weisbecker <fweisbec@gmail.com>
Suggested-by: Ingo Molnar <mingo@elte.hu>
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
LKML-Reference: <1258415125-15019-2-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

tools/perf/Documentation/perf-buildid-list.txt
tools/perf/builtin-buildid-list.c
tools/perf/util/symbol.c

index abab34e..01b642c 100644 (file)
@@ -26,7 +26,7 @@ OPTIONS
        Don't do ownership validation.
 -v::
 --verbose::
-       Be more verbose, showing the name of the DSOs after the buildids.
+       Be more verbose.
 
 SEE ALSO
 --------
index 2e377e1..7dee9d1 100644 (file)
@@ -28,7 +28,7 @@ static const struct option options[] = {
                    "input file name"),
        OPT_BOOLEAN('f', "force", &force, "don't complain, do it"),
        OPT_BOOLEAN('v', "verbose", &verbose,
-                   "be more verbose (show counter open errors, etc)"),
+                   "be more verbose"),
        OPT_END()
 };
 
index 53de9c4..1b77e81 100644 (file)
@@ -1442,10 +1442,7 @@ size_t dsos__fprintf_buildid(FILE *fp)
 
        list_for_each_entry(pos, &dsos, node) {
                ret += dso__fprintf_buildid(pos, fp);
-               if (verbose)
-                       ret += fprintf(fp, " %s\n", pos->long_name);
-               else
-                       ret += fprintf(fp, "\n");
+               ret += fprintf(fp, " %s\n", pos->long_name);
        }
        return ret;
 }