x86: fix pte_flags() to only return flags, fix lguest (updated)
authorRusty Russell <rusty@rustcorp.com.au>
Tue, 22 Jul 2008 05:40:46 +0000 (15:40 +1000)
committerIngo Molnar <mingo@elte.hu>
Tue, 22 Jul 2008 08:41:18 +0000 (10:41 +0200)
commitc2e3277f875b83e5adc34e96989d6d87ec5f80f7
treec25f6dd50e136d720f8f35d689946b6d256d054b
parent988781dc3e1d9209192b04458d279815923f5e76
x86: fix pte_flags() to only return flags, fix lguest (updated)

(Jeremy said:
rusty: use PTE_MASK
rusty: use PTE_MASK
rusty: use PTE_MASK
 When I asked:
jsgf: does that include the NX flag?
 He responded eloquently:
rusty: use PTE_MASK
rusty: use PTE_MASK
yes, it's the official constant of masking flags out of ptes
)

Change a15af1c9ea2750a9ff01e51615c45950bad8221b 'x86/paravirt: add
pte_flags to just get pte flags' removed lguest's private pte_flags()
in favor of a generic one.

Unfortunately, the generic one doesn't filter out the non-flags bits:
this results in lguest creating corrupt shadow page tables and blowing
up host memory.

Since noone is supposed to use the pfn part of pte_flags(), it seems
safest to always do the filtering.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: Jeremy Fitzhardinge <jeremy@goop.org>
Signed-off-and-morning-tea-spilled-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/paravirt.c
include/asm-x86/page.h
include/asm-x86/paravirt.h