8 years agodownloadmanager should use "files" dir - not "cache" dir to store its files
Vasu Nori [Fri, 7 Jan 2011 19:39:25 +0000]
downloadmanager should use "files" dir - not "cache" dir to store its files

data/data/com.android.providers.downlaods/cache is being used
to store the downloaded files, when the user doesn't specify the
destination path.
but system seems to remove files from this dir EVEN when space is
running low. bug:3324673
instead, let DownloadManager use
data/data/com.android.providers.downlaods/files dir
Downlaodmanager manages its space anyway.

Change-Id: I2eb15570395a214477891f50f635fada0b466544

8 years agoAdding HelpersTest.java for testing the download provider's helpers class. Note ...
olly [Thu, 23 Dec 2010 16:27:05 +0000]
Adding HelpersTest.java for testing the download provider's helpers class. Note - only a small fraction of input cases are currently tested.

Change-Id: I830fff43cc283367a3534b7a3ffcc2a6d296e7c3

8 years agoMerge "bug:3286430 set quota on downloads data dir"
Vasu Nori [Fri, 24 Dec 2010 00:47:13 +0000]
Merge "bug:3286430 set quota on downloads data dir"

8 years agoImport revised translations.
Eric Fischer [Thu, 23 Dec 2010 22:38:17 +0000]
Import revised translations.

Change-Id: I2031a68f02f7e5fcd8702b1184e01c381cdc40fe

8 years agobug:3286430 set quota on downloads data dir
Vasu Nori [Fri, 17 Dec 2010 02:31:23 +0000]
bug:3286430 set quota on downloads data dir

make sure the doanloads data dir size is limited by some quote -
100MB default and 200MB for SR.
bug:3286430

tests are in Change-Id: I688f7e058511089bec7fa21e972e23780604d98a

Change-Id: Iba7fab9fa91ea018f35e1c3ef5ec0e6b03cba650

8 years agoFixing Helpers to correctly parse file names / extensions in the case where the filen...
olly [Tue, 21 Dec 2010 19:09:12 +0000]
Fixing Helpers to correctly parse file names / extensions in the case where the filename does not have a file extension but there are one or more dots in the parent directory names.

e.g. /mnt/sdcard/Android/data/com.google.android.youtube/files/file

Change-Id: I5aad1625a9f36135e947c0f929ee740fc66eb0d3

8 years agoMerge "when download-complete-notif is clicked on, don't show notif anymore"
Vasu Nori [Fri, 17 Dec 2010 02:35:11 +0000]
Merge "when download-complete-notif is clicked on, don't show notif anymore"

8 years agofix a bug in one of the downloadmanager queries
Vasu Nori [Thu, 16 Dec 2010 22:59:29 +0000]
fix a bug in one of the downloadmanager queries

Change-Id: Ie8148af67507bdc1d12307ce0d957343d2a28af0

8 years agowhen download-complete-notif is clicked on, don't show notif anymore
Vasu Nori [Thu, 16 Dec 2010 00:47:10 +0000]
when download-complete-notif is clicked on, don't show notif anymore

bug:3272589
in HC, when using public API, if the downloaded file is in downloads data
dir, wrong intent action is set when the user clicks on download-complete
notification.
fix this by sending the correct intent action if the download is
in downloads data dir or any other location specified by the app.

Change-Id: I72621be5f1d6a5caecb8ec85634b351e08b66c31

8 years agofix downloadmanager tests. again.
Vasu Nori [Wed, 15 Dec 2010 22:19:57 +0000]
fix downloadmanager tests. again.

Change-Id: I61c6020017a300076ab2a5901ab87eabb1e0d0b7

8 years agoDownload dir: /data/data/com.android.providers.downloads/cache NOT /cache
Vasu Nori [Tue, 14 Dec 2010 00:29:29 +0000]
Download dir: /data/data/com.android.providers.downloads/cache NOT /cache

bug:3264401
still to do:
   make sure only N bytes are taken up by downloads dir
     N = a value specific to each device.
     default = 100MB.

Change-Id: I2a49f4b3831d3a8d7be13b5fd46d85d56e831e38

8 years agoam bf04a04e: am ee39528f: reconcile with open-source gingerbread
Jean-Baptiste Queru [Fri, 10 Dec 2010 16:53:51 +0000]
am bf04a04e: am ee39528f: reconcile with open-source gingerbread

* commit 'bf04a04e2022673c08617ad9dbb2522da2e87a8e':

8 years agoam ee39528f: reconcile with open-source gingerbread
Jean-Baptiste Queru [Fri, 10 Dec 2010 16:49:44 +0000]
am ee39528f: reconcile with open-source gingerbread

* commit 'ee39528f004afeb45883e32daf3fbd5a698b8a05':

8 years agofix broken DownloadManager tests
Vasu Nori [Mon, 6 Dec 2010 23:16:23 +0000]
fix broken DownloadManager tests

one big change in this CL is addition of a new feature to MockWebServer.
It can now play a long response to the Downloading thread to keep it busy
while something - such as cancel/remove - can be done to that Download Request.

Also, added changes to FakeSystemFacade to start threads in normal fashion
instead of queuing them up and later running just their run() methods.

the following tests should work now
packages/providers/DownloadProvider/tests/src/com/android/providers/downloads/
  DownloadManagerFunctionalTest.java
  PublicApiFunctionalTest.java
  ThreadingTest.java
  PublicApiAccessTest.java
  DownloadProviderPermissionsTest.java

the following are flaky. they need to be split up into smaller tests.
frameworks/base/core/tests/coretests/src/android/app/
  DownloadManagerIntegrationTest.java
  DownloadManagerStressTest.java

Change-Id: Ia0b11963f92e8f8365f701761dcbce467be3ee9b

8 years agoam 79595ec9: am 5ad8a55c: merge from gingerbread
Jean-Baptiste Queru [Thu, 9 Dec 2010 18:51:47 +0000]
am 79595ec9: am 5ad8a55c: merge from gingerbread

* commit '79595ec955da98510746ff2fa0ea47dc3d874012':
  Don't filter by UID for apps with ACCESS_ALL_DOWNLOADS

8 years agoam 5ad8a55c: merge from gingerbread
Jean-Baptiste Queru [Thu, 9 Dec 2010 18:48:05 +0000]
am 5ad8a55c: merge from gingerbread

* commit '5ad8a55c2a74f855fd4530e98147059206b7b2b0':
  Don't filter by UID for apps with ACCESS_ALL_DOWNLOADS

8 years agoreconcile with open-source gingerbread
Jean-Baptiste Queru [Thu, 9 Dec 2010 18:18:49 +0000]
reconcile with open-source gingerbread

Change-Id: I6a6553f8e89f576cf21ee0fb0cba62479f96f2b3

8 years agomerge from gingerbread
Jean-Baptiste Queru [Thu, 9 Dec 2010 17:11:23 +0000]
merge from gingerbread

Change-Id: I38873b898f431d1815ead588807a00068a7e802c

8 years agoDon't filter by UID for apps with ACCESS_ALL_DOWNLOADS tegra-10.11.0 tegra-10.11.1 tegra-10.11.1.1 tegra-10.11.2 tegra-10.11.3 tegra-10.11.4 tegra-10.11.ER1
Kenny Root [Wed, 1 Dec 2010 19:38:41 +0000]
Don't filter by UID for apps with ACCESS_ALL_DOWNLOADS

Old platform behavior of DownloadProvider would allow anyone with
special access to access all the downloads. New behavior is to return
/my_downloads/ on an .insert() call. For things that aren't using the
new API where DownloadInfo.getAllDownloadsUri() is accessible, make any
application with ACCESS_ALL_DOWNLOADS permission bypass the calling UID
check for /my_downloads/

Bug: 3242328
Change-Id: I4d7dae75c528d2803d594c5d79d19865ef37ed30

8 years agoam bf7c06b5: am 5bbe15ed: downloads broken by Change-Id: I115b3ba6cfe0262269dbbc4c336...
Vasu Nori [Mon, 6 Dec 2010 18:42:28 +0000]
am bf7c06b5: am 5bbe15ed: downloads broken by Change-Id: I115b3ba6cfe0262269dbbc4c336b9e1d63c618e4

* commit 'bf7c06b57a99bd9be0c8edc20b05f5eadbe02030':
  downloads broken by Change-Id: I115b3ba6cfe0262269dbbc4c336b9e1d63c618e4

8 years agoam 5bbe15ed: downloads broken by Change-Id: I115b3ba6cfe0262269dbbc4c336b9e1d63c618e4
Vasu Nori [Sun, 5 Dec 2010 07:45:08 +0000]
am 5bbe15ed: downloads broken by Change-Id: I115b3ba6cfe0262269dbbc4c336b9e1d63c618e4

* commit '5bbe15ed66d72dcab0ef133b9d237bba28cd6d98':
  downloads broken by Change-Id: I115b3ba6cfe0262269dbbc4c336b9e1d63c618e4

8 years agomanually merging Change-Id: If7dc0f86ea7a3c4394603416ca0fc33847f10fa7
Vasu Nori [Fri, 3 Dec 2010 21:19:04 +0000]
manually merging Change-Id: If7dc0f86ea7a3c4394603416ca0fc33847f10fa7

need this CL from GB. without it, downloads are badly broken in master.

Change-Id: I82ebc467f877bed50e373c437481ad19e14635bf

8 years agodownloads broken by Change-Id: I115b3ba6cfe0262269dbbc4c336b9e1d63c618e4
Vasu Nori [Fri, 3 Dec 2010 19:13:50 +0000]
downloads broken by Change-Id: I115b3ba6cfe0262269dbbc4c336b9e1d63c618e4

big typo in that CL broke the downloading functionality.

Change-Id: If7dc0f86ea7a3c4394603416ca0fc33847f10fa7

8 years agoMerge "bug:3144642 fix is to treat empty strings as nulls"
Vasu Nori [Fri, 3 Dec 2010 00:08:50 +0000]
Merge "bug:3144642 fix is to treat empty strings as nulls"

8 years agoam 084c3dc3: am 26f86843: Merge "(GB MR) bug:3144642 temporary small fix in GB MR...
Vasu Nori [Thu, 2 Dec 2010 22:49:26 +0000]
am 084c3dc3: am 26f86843: Merge "(GB MR) bug:3144642 temporary small fix in GB MR and real fix in HC" into gingerbread

* commit '084c3dc34ed9e6ae9ddc471819de0d6d55021dfd':
  (GB MR) bug:3144642 temporary small fix in GB MR and real fix in HC

8 years agoam 26f86843: Merge "(GB MR) bug:3144642 temporary small fix in GB MR and real fix...
Vasu Nori [Thu, 2 Dec 2010 22:47:17 +0000]
am 26f86843: Merge "(GB MR) bug:3144642 temporary small fix in GB MR and real fix in HC" into gingerbread

* commit '26f86843f48b3d7878837a1a9f93865b3eba0aee':
  (GB MR) bug:3144642 temporary small fix in GB MR and real fix in HC

8 years agoMerge "(GB MR) bug:3144642 temporary small fix in GB MR and real fix in HC" into...
Vasu Nori [Thu, 2 Dec 2010 22:45:30 +0000]
Merge "(GB MR) bug:3144642 temporary small fix in GB MR and real fix in HC" into gingerbread

8 years agoRename Indonesian and Hebrew translations to match Locale.java conventions
Eric Fischer [Thu, 2 Dec 2010 22:13:22 +0000]
Rename Indonesian and Hebrew translations to match Locale.java conventions

Change-Id: Ib1e73afe5daa389177da8f3614761364ae6bcc26

8 years agobug:3144642 fix is to treat empty strings as nulls
Vasu Nori [Thu, 2 Dec 2010 19:09:39 +0000]
bug:3144642 fix is to treat empty strings as nulls

in the database, sometimes _data column in downloads is set to null
and sometimes to empty string. this is inconsistent
and causes bugs such as bug:3144642
aThis bug is caused by line# 793 in DownloadThread.
state.mFileName is null sometimes and empty string sometimes - because
the correspodning field is set inconsistentlt in downloads.db
_data column.

Change-Id: Ifea1544737023008eff44aef9acd976902a0c143

8 years ago(GB MR) bug:3144642 temporary small fix in GB MR and real fix in HC
Vasu Nori [Thu, 2 Dec 2010 02:23:09 +0000]
(GB MR) bug:3144642 temporary small fix in GB MR and real fix in HC

Real fix is in Change-Id: Ifea1544737023008eff44aef9acd976902a0c143
In the database, sometimes _data column in downloads is set to null
and sometimes to empty string. this is inconsistent
and causes bugs such as bug:3144642.
This bug is caused by line# 793 in DownloadThread.
state.mFileName is null sometimes and empty string sometimes - because
the correspodning field is set inconsistentlt in downloads.db
_data column.

in GB MR, apply a bandaid because real fix could be too risky for
GB.

Change-Id: I115b3ba6cfe0262269dbbc4c336b9e1d63c618e4

8 years agoam 5ec56824: (-s ours) am 6ae8b6ef: Merge "Import revised translations. DO NOT MERGE...
Eric Fischer [Thu, 2 Dec 2010 00:33:27 +0000]
am 5ec56824: (-s ours) am 6ae8b6ef: Merge "Import revised translations.  DO NOT MERGE" into gingerbread

* commit '5ec5682406244769bc4fb552e2e47757194e55e0':
  Import revised translations.  DO NOT MERGE

8 years agoam 6ae8b6ef: Merge "Import revised translations. DO NOT MERGE" into gingerbread
Eric Fischer [Thu, 2 Dec 2010 00:30:21 +0000]
am 6ae8b6ef: Merge "Import revised translations.  DO NOT MERGE" into gingerbread

* commit '6ae8b6efc5ce136b95c062268f12624b85332b6d':
  Import revised translations.  DO NOT MERGE

8 years agoMerge "Import revised translations. DO NOT MERGE" into gingerbread
Eric Fischer [Thu, 2 Dec 2010 00:28:09 +0000]
Merge "Import revised translations.  DO NOT MERGE" into gingerbread

8 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Wed, 1 Dec 2010 23:09:56 +0000]
Import revised translations.  DO NOT MERGE

Bug 3245452

Change-Id: Ie2e81528c7a16dce5350f5d6845c8b4c0da15f96

8 years agoam 5c29cce0: am e1823c84: Don\'t filter by UID for apps with ACCESS_ALL_DOWNLOADS
Kenny Root [Wed, 1 Dec 2010 22:23:13 +0000]
am 5c29cce0: am e1823c84: Don\'t filter by UID for apps with ACCESS_ALL_DOWNLOADS

* commit '5c29cce0bac00a7a32cd92210825a789e140cf94':
  Don't filter by UID for apps with ACCESS_ALL_DOWNLOADS

8 years agoam e1823c84: Don\'t filter by UID for apps with ACCESS_ALL_DOWNLOADS
Kenny Root [Wed, 1 Dec 2010 22:20:45 +0000]
am e1823c84: Don\'t filter by UID for apps with ACCESS_ALL_DOWNLOADS

* commit 'e1823c84698006aa26a8c5dcfa5c4034858dfbe3':
  Don't filter by UID for apps with ACCESS_ALL_DOWNLOADS

8 years agoDon't filter by UID for apps with ACCESS_ALL_DOWNLOADS
Kenny Root [Wed, 1 Dec 2010 19:38:41 +0000]
Don't filter by UID for apps with ACCESS_ALL_DOWNLOADS

Old platform behavior of DownloadProvider would allow anyone with
special access to access all the downloads. New behavior is to return
/my_downloads/ on an .insert() call. For things that aren't using the
new API where DownloadInfo.getAllDownloadsUri() is accessible, make any
application with ACCESS_ALL_DOWNLOADS permission bypass the calling UID
check for /my_downloads/

Bug: 3242328
Change-Id: I536fde4525dd74066879f7c7da7fa609ff344645

8 years agoMove icons to mipmap.
Ying Wang [Tue, 23 Nov 2010 19:49:59 +0000]
Move icons to mipmap.

Change-Id: I0d541c99b413ba8124abe307b81fe35fdf0fe610

8 years agoImport initial translations for 20 new locales.
Eric Fischer [Thu, 18 Nov 2010 00:44:53 +0000]
Import initial translations for 20 new locales.

Change-Id: I1837f21d4369070e4ba167f8cab45f6df1daa037

8 years agofix permissions when accessing downloads thru various Uri's
Vasu Nori [Tue, 16 Nov 2010 22:35:31 +0000]
fix permissions when accessing downloads thru various Uri's

fixes this bug bug:3169457 also

Change-Id: I0f60333361c5c399c64faa2d497038530064bef0

8 years agoprovider changes due to CL: Ief1693785f0484c1b434fb41a68693f9aff96492
Vasu Nori [Tue, 9 Nov 2010 20:30:19 +0000]
provider changes due to CL: Ief1693785f0484c1b434fb41a68693f9aff96492

Change-Id: I8940778292d0a9166cfcfb92d37ea568b8f6ceef

8 years agosimplify actions to perform when user clicks on delete in download app
Vasu Nori [Tue, 9 Nov 2010 20:13:38 +0000]
simplify actions to perform when user clicks on delete in download app

bug:3175143
let downloadservice do the cleanup from all dataases and
also let it handle removal of the file from the sdcard.

Change-Id: I12eb8458223228109f1340552009d400b070bf54

8 years agowhen a download fails, store the error msg in db
Vasu Nori [Thu, 11 Nov 2010 23:26:07 +0000]
when a download fails, store the error msg in db

useful for debugging for bugs like bug:3187299
without this error message, one doesn't know WHY downloads
fail.
to prevent PII info in database,
there is a STOPSHIP comment around storage of this error
message in database.

Change-Id: I612e383aef8483b68b772f70dff722a5daea2ef5

8 years agoImport revised translations.
Eric Fischer [Wed, 10 Nov 2010 01:44:17 +0000]
Import revised translations.

Change-Id: Ic0c8d1b205c495bbcaccf3141abcbc1d14e6ea42

8 years agoif any exceptions encountered while trimming downloads db, ignore 'em.
Vasu Nori [Tue, 9 Nov 2010 21:25:37 +0000]
if any exceptions encountered while trimming downloads db, ignore 'em.

bug:3176990
Change-Id: I182331cbd63b6524a18d19e4d8567210886f8c16

8 years agoallow the column "scanned" from DownloadManager. bug:3169437
Vasu Nori [Fri, 5 Nov 2010 18:00:31 +0000]
allow the column "scanned" from DownloadManager. bug:3169437

Change-Id: I96f0b51295611b67735c1b726bcd46bbeaa90613

8 years agochanges to support CL: I1f5dd734e394db0056579a3a0c26862fee27981e
Vasu Nori [Thu, 4 Nov 2010 22:03:31 +0000]
changes to support CL: I1f5dd734e394db0056579a3a0c26862fee27981e

1. if an application designates a downloaded file to be mediascanner
scannable or not, store that fact in database.
2. use the above to determine whether a file shoudl be mediascanned or not
in DownloadService
3. implement code to return mimetype for the new Uri "/public_downloads"
introduced in CL: I1f5dd734e394db0056579a3a0c26862fee27981e

Change-Id: I5c062ad6d1b58306044cee49ff3827e908d27fd9

8 years agodownloadmanager public API usage can cause non-scanning of media files
Vasu Nori [Wed, 3 Nov 2010 20:12:11 +0000]
downloadmanager public API usage can cause non-scanning of media files

bug:3162073
Change-Id: I13b80fedd7658c8574f33b43b74b5aa28a2895bc

8 years agoin DM public API, sending notifications on clicks should include data
Vasu Nori [Wed, 27 Oct 2010 18:47:25 +0000]
in DM public API, sending notifications on clicks should include data

receiving application needs to know WHAT items the clicks occurred on -
not just the fact that *something* was clicked on.
this is duplicating the behavior as it exists today in the non-public API.

depends on Change-Id: Ibe53ccd9934c73175459e42e3d417eee69ae6735

Change-Id: I924f85bd5faf443ac5648839b68390ec4de1f677

8 years agomake sure filename is non-null before delting it.
Vasu Nori [Fri, 29 Oct 2010 20:34:14 +0000]
make sure filename is non-null before delting it.

if a download fails for some reason, then filename could be null.
move Helpers.deleteFile() code into private method in DownloadService

Change-Id: Ifb12a84b6185e19c70d62392e102950c07f56a01

8 years agowhen using DM public API, allow duplicate downloads of same file
Vasu Nori [Thu, 28 Oct 2010 19:08:42 +0000]
when using DM public API, allow duplicate downloads of same file

bug:3132790
this mimics the behavior that exists today (in non-public API)

Change-Id: I722b3bc23fe8c9b0bf66a088c5f6a3130be2129f

8 years agoMerge "Import revised translations."
Eric Fischer [Wed, 27 Oct 2010 22:18:13 +0000]
Merge "Import revised translations."

8 years agoMerge "reduce number of times mediascanner is invoked by downloadservice"
Vasu Nori [Wed, 27 Oct 2010 21:55:07 +0000]
Merge "reduce number of times mediascanner is invoked by downloadservice"

8 years agoImport revised translations.
Eric Fischer [Wed, 27 Oct 2010 21:37:44 +0000]
Import revised translations.

Change-Id: I0560d6ae179ababe74f53d3b937b8c53b674451b

8 years agoMerge "allow run-time verbose debugging option on downloadmanager code."
Vasu Nori [Wed, 27 Oct 2010 19:01:31 +0000]
Merge "allow run-time verbose debugging option on downloadmanager code."

8 years agoallow run-time verbose debugging option on downloadmanager code.
Vasu Nori [Wed, 27 Oct 2010 18:54:50 +0000]
allow run-time verbose debugging option on downloadmanager code.

otherwise, one has to recompile and reflash to get debug output

Change-Id: I1d89d7cca3363fa793f74ba805136667e1ce3091

8 years agoam b2fb2046: (-s ours) am 6bc0865d: Import revised translations. DO NOT MERGE
Eric Fischer [Wed, 27 Oct 2010 18:03:58 +0000]
am b2fb2046: (-s ours) am 6bc0865d: Import revised translations.  DO NOT MERGE

8 years agoam 6bc0865d: Import revised translations. DO NOT MERGE
Eric Fischer [Wed, 27 Oct 2010 18:02:04 +0000]
am 6bc0865d: Import revised translations.  DO NOT MERGE

8 years agoreduce number of times mediascanner is invoked by downloadservice
Vasu Nori [Tue, 26 Oct 2010 23:37:08 +0000]
reduce number of times mediascanner is invoked by downloadservice

this is one of the 2 bugs mentioned in bug:3129943
sometimes MediaProvider returns null for returned param Uri.
in such cases, mark the file as 'scanned' in the downloads db
so that it is NOT scanned again later by DownlaodService.

depends on Change-Id: I92514e1a11f5119229c0c7292e410e352a9dbcdd

Change-Id: Ie9d839581f656c929a77bd5f244ad6b2fb1585e6

8 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Wed, 27 Oct 2010 00:03:27 +0000]
Import revised translations.  DO NOT MERGE

Change-Id: Iadedcf076f8bbe43d1864baf989b21d9d30f13f7

8 years agoam cba66d82: (-s ours) am c08eb279: Import revised translations. DO NOT MERGE
Eric Fischer [Tue, 26 Oct 2010 00:30:55 +0000]
am cba66d82: (-s ours) am c08eb279: Import revised translations.  DO NOT MERGE

Merge commit 'cba66d82e30d3ae1be826989229975e05cd9a754'

* commit 'cba66d82e30d3ae1be826989229975e05cd9a754':
  Import revised translations.  DO NOT MERGE

8 years agoam c08eb279: Import revised translations. DO NOT MERGE
Eric Fischer [Tue, 26 Oct 2010 00:11:45 +0000]
am c08eb279: Import revised translations.  DO NOT MERGE

Merge commit 'c08eb2797760e31f3962795b84d0528149a84986' into gingerbread-plus-aosp

* commit 'c08eb2797760e31f3962795b84d0528149a84986':
  Import revised translations.  DO NOT MERGE

8 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Mon, 25 Oct 2010 23:52:50 +0000]
Import revised translations.  DO NOT MERGE

Change-Id: Id9cdaf0062ee97f067b644bcc00d41182ff52934

8 years agoam 298c2cd1: am 404d31e3: Replace shared storage with USB storage.
Eric Fischer [Thu, 21 Oct 2010 20:41:52 +0000]
am 298c2cd1: am 404d31e3: Replace shared storage with USB storage.

Merge commit '298c2cd136e25a705486c543d8c04311ab655d98'

* commit '298c2cd136e25a705486c543d8c04311ab655d98':
  Replace shared storage with USB storage.

8 years agoam e664fbaf: am 3c3ed3c1: bug:3083060 UI tweaks to DownloadManager screens
Vasu Nori [Thu, 21 Oct 2010 17:50:53 +0000]
am e664fbaf: am 3c3ed3c1: bug:3083060 UI tweaks to DownloadManager screens

Merge commit 'e664fbafc566f31f844dd543c30064e92f3653f7'

* commit 'e664fbafc566f31f844dd543c30064e92f3653f7':
  bug:3083060 UI tweaks to DownloadManager screens

8 years agoam 404d31e3: Replace shared storage with USB storage.
Eric Fischer [Wed, 20 Oct 2010 20:57:07 +0000]
am 404d31e3: Replace shared storage with USB storage.

Merge commit '404d31e3e2ca00e9c45b94ca0de9c36a87e999ab' into gingerbread-plus-aosp

* commit '404d31e3e2ca00e9c45b94ca0de9c36a87e999ab':
  Replace shared storage with USB storage.

8 years agoremove usage of hidden public constants.
Vasu Nori [Wed, 20 Oct 2010 20:38:10 +0000]
remove usage of hidden public constants.

Change-Id: I2edf1bef5e741de8193cb293807e3ace42003b0c

8 years agoReplace shared storage with USB storage.
Eric Fischer [Wed, 20 Oct 2010 01:13:47 +0000]
Replace shared storage with USB storage.

Change-Id: If3fb1c213f9f9c6f21bd1f13f633393a32d2509a

8 years agoam 3c3ed3c1: bug:3083060 UI tweaks to DownloadManager screens
Vasu Nori [Wed, 20 Oct 2010 04:37:21 +0000]
am 3c3ed3c1: bug:3083060 UI tweaks to DownloadManager screens

Merge commit '3c3ed3c1488c2ebfd2b66a3cdf09b3e312883159' into gingerbread-plus-aosp

* commit '3c3ed3c1488c2ebfd2b66a3cdf09b3e312883159':
  bug:3083060 UI tweaks to DownloadManager screens

8 years agobug:3083060 UI tweaks to DownloadManager screens
Vasu Nori [Fri, 15 Oct 2010 22:23:12 +0000]
bug:3083060 UI tweaks to DownloadManager screens

Change-Id: I3c7ee819077d344072deee4cfd61f883c64da758

8 years agoam 1b831d75: (-s ours) am 4c1acb60: Merge "Import revised translations DO NOT MERGE...
Kenny Root [Mon, 18 Oct 2010 17:31:03 +0000]
am 1b831d75: (-s ours) am 4c1acb60: Merge "Import revised translations DO NOT MERGE" into gingerbread

Merge commit '1b831d75cec0f75f4bdbaac2a77053da93d5cb2d'

* commit '1b831d75cec0f75f4bdbaac2a77053da93d5cb2d':
  Import revised translations DO NOT MERGE

8 years agoam 9f6654cf: Merge 216736d2 from gingerbread
Jean-Baptiste Queru [Mon, 18 Oct 2010 17:30:10 +0000]
am 9f6654cf: Merge 216736d2 from gingerbread

Merge commit '9f6654cfec6e6d8d1e3de9a8adeba46137a22105'

* commit '9f6654cfec6e6d8d1e3de9a8adeba46137a22105':
  bug:3099994 NPE in DownloadManager when deleting non-media file

8 years agoam 4c1acb60: Merge "Import revised translations DO NOT MERGE" into gingerbread
Kenny Root [Sat, 16 Oct 2010 01:41:00 +0000]
am 4c1acb60: Merge "Import revised translations DO NOT MERGE" into gingerbread

Merge commit '4c1acb60162e2a2e8c80a996676a4d543a2eb3a7' into gingerbread-plus-aosp

* commit '4c1acb60162e2a2e8c80a996676a4d543a2eb3a7':
  Import revised translations DO NOT MERGE

8 years agoMerge 216736d2 from gingerbread
Jean-Baptiste Queru [Sat, 16 Oct 2010 01:28:49 +0000]
Merge 216736d2 from gingerbread

Change-Id: I404d1a66d337b1dade181ade92dc21fc0e819aa7

8 years agoMerge "Import revised translations DO NOT MERGE" into gingerbread
Kenny Root [Fri, 15 Oct 2010 23:55:25 +0000]
Merge "Import revised translations DO NOT MERGE" into gingerbread

8 years agoam f61c1d08: (-s ours) am 887a95e2: Import revised translations
Kenny Root [Fri, 15 Oct 2010 23:49:25 +0000]
am f61c1d08: (-s ours) am 887a95e2: Import revised translations

Merge commit 'f61c1d08555ac418d2b3337f74807821a30ab47c'

* commit 'f61c1d08555ac418d2b3337f74807821a30ab47c':
  Import revised translations

8 years agoMerge "bug:3099994 NPE in DownloadManager when deleting non-media file" into gingerbread
Vasu Nori [Fri, 15 Oct 2010 23:07:22 +0000]
Merge "bug:3099994 NPE in DownloadManager when deleting non-media file" into gingerbread

8 years agoImport revised translations DO NOT MERGE
Kenny Root [Fri, 15 Oct 2010 22:28:41 +0000]
Import revised translations DO NOT MERGE

Change-Id: I21052e55a62dd3d9a9846dec30c3ac12cc9c25af

8 years agoam 3e759e21: am a53c21ed: fix broken build bug:3095237
Vasu Nori [Fri, 15 Oct 2010 20:59:55 +0000]
am 3e759e21: am a53c21ed: fix broken build  bug:3095237

Merge commit '3e759e21291d6ca1a49ded3f24f3be0a26af4e2b'

* commit '3e759e21291d6ca1a49ded3f24f3be0a26af4e2b':
  fix broken build  bug:3095237

8 years agoam 57c4e918: am e00c3120: bug:3069735 in Download UI app, handle deletes correctly
Vasu Nori [Fri, 15 Oct 2010 19:43:04 +0000]
am 57c4e918: am e00c3120: bug:3069735 in Download UI app, handle deletes correctly

Merge commit '57c4e9180e3a339dba984f1c8dff76ef18443a7a'

* commit '57c4e9180e3a339dba984f1c8dff76ef18443a7a':
  bug:3069735 in Download UI app, handle deletes correctly

8 years agobug:3099994 NPE in DownloadManager when deleting non-media file
Vasu Nori [Fri, 15 Oct 2010 05:57:46 +0000]
bug:3099994 NPE in DownloadManager when deleting non-media file

DownloadService always scans files and assumes MediaProvider
returns a valid Uri. But MediaProvider returns null for
return param 'uri'
if the file is not audio/video/image etc media type file
(for example, pdf)

Change-Id: If32bd1895b00b5406973a5e240ad3558d46f9f4a

8 years agoam 887a95e2: Import revised translations
Kenny Root [Thu, 14 Oct 2010 21:24:29 +0000]
am 887a95e2: Import revised translations

Merge commit '887a95e29a8776a07b411c472a11e82ad84464a8' into gingerbread-plus-aosp

* commit '887a95e29a8776a07b411c472a11e82ad84464a8':
  Import revised translations

8 years agoImport revised translations
Kenny Root [Thu, 14 Oct 2010 16:47:03 +0000]
Import revised translations

Change-Id: I03a58b6efd2e1a12054bc7dbb320368be6cfdd17

8 years agoam a53c21ed: fix broken build bug:3095237
Vasu Nori [Thu, 14 Oct 2010 05:53:40 +0000]
am a53c21ed: fix broken build  bug:3095237

Merge commit 'a53c21edb5dc57d97dcddd03fbfa2022abf43787' into gingerbread-plus-aosp

* commit 'a53c21edb5dc57d97dcddd03fbfa2022abf43787':
  fix broken build  bug:3095237

8 years agofix broken build bug:3095237
Vasu Nori [Thu, 14 Oct 2010 00:53:37 +0000]
fix broken build  bug:3095237

Change-Id: I7e1fe99cc482fc270894a820049275fc0c64233e

8 years agoam e00c3120: bug:3069735 in Download UI app, handle deletes correctly
Vasu Nori [Wed, 13 Oct 2010 23:56:17 +0000]
am e00c3120: bug:3069735 in Download UI app, handle deletes correctly

Merge commit 'e00c31208405bd2e4c88e069df7a2b15237f70bf' into gingerbread-plus-aosp

* commit 'e00c31208405bd2e4c88e069df7a2b15237f70bf':
  bug:3069735 in Download UI app, handle deletes correctly

8 years agobug:3069735 in Download UI app, handle deletes correctly
Vasu Nori [Wed, 13 Oct 2010 06:27:49 +0000]
bug:3069735 in Download UI app, handle deletes correctly

gingerbread.
High-level details
1. When a file is downloaded by DownloadManager, metadata about the file
   is stored in 2 databases: DownloadProvider and MediaProvider.

2. So, when it is to be deleted, its metadata needs to be cleaned up from
   both the databases.

3. But the 2 databases use differnt content-uri's as "primary keys" and
   DownloadProvider loses the "primary-key" of the row in MediaProvider
   database.

4. Easiest thing would have been to have DownloadProvider give filepath
   to MediaProvider and let MediaProvider linearly scan its database
   to locate the row and delete it.

5. The other - faster but more coding for now - option is to have
   DownloadProvider store the "primary-key" of the MediaProvider's
   row. implemented in this CL.

Low-level details
1. add 2 new columns to downloads table in downloads.db:
    mediaprovider_uri = downloaded file's content_uri in mediaprovider db
      this column is null for downloads that finished before this column is
      added to the database.
    deleted = flag is set to true if a file is to be deleted
2. download UI app shows only those files whose 'deleted' flag is not set.
3. when the user deletes downloads from download UI app,
    3.1. if mediaprovider_uri is NOT null, then the row is deleted from
         downloads table AND from the mediaprovider database.
    3.2 if mediaprovider_uri is NULL, then its row in downloads database
         is marked 'tp be deleted' by setting 'deleted' column to '1'.
4. When DownloadService (in DownloadProvider) processes all rows from
     downloads table, if it sees any rows wth 'deleted' = 1, then
     it uses MediaScanner Service to re-scan the file,
     get the mediaprovider_uri from MediaProvider
     and update the row in downloads table with this mediaprovider_uri value
     and then delete the row by doing the following
        1. delete it from MediaProvider database using mediaprovider_uri
        2. delete it from DownloadProvider database

Problem with this solution:
There is a small window where it is deleted by the user on the Download app
(and the row disappears from the display) but it is still present in
Gallery app.
   Thats due to the following asynchronous operations
   1. DownladService which processes rows-to-be-deleted is not always up
   2. DownloadService uses asynchronous call to have the file re-scanned
        by MediaScanner to get mediaprovider_uri

Change-Id: Ib90eb9e647f543312c865d3bbf9a06fb867a648b

8 years agoam 1f262cf3: am cd990514: Merge "Make DownloadProvider use parameterized queries...
Steve Howard [Mon, 11 Oct 2010 00:46:24 +0000]
am 1f262cf3: am cd990514: Merge "Make DownloadProvider use parameterized queries." into gingerbread

Merge commit '1f262cf3af0512e0d621b7818aab9bb79527f01f'

* commit '1f262cf3af0512e0d621b7818aab9bb79527f01f':
  Make DownloadProvider use parameterized queries.

8 years agoam 136b2d6a: (-s ours) am 49f78e40: Import revised translations. DO NOT MERGE
Eric Fischer [Sat, 9 Oct 2010 16:39:28 +0000]
am 136b2d6a: (-s ours) am 49f78e40: Import revised translations.  DO NOT MERGE

Merge commit '136b2d6aed4adc9537504e33e5d3b9b0bc5ef22f'

* commit '136b2d6aed4adc9537504e33e5d3b9b0bc5ef22f':
  Import revised translations.  DO NOT MERGE

8 years agoam cd990514: Merge "Make DownloadProvider use parameterized queries." into gingerbread
Steve Howard [Fri, 8 Oct 2010 20:13:07 +0000]
am cd990514: Merge "Make DownloadProvider use parameterized queries." into gingerbread

Merge commit 'cd990514feb2b17848809d9262e0d73a828b2142' into gingerbread-plus-aosp

* commit 'cd990514feb2b17848809d9262e0d73a828b2142':
  Make DownloadProvider use parameterized queries.

8 years agoMerge "Make DownloadProvider use parameterized queries." into gingerbread
Steve Howard [Fri, 8 Oct 2010 20:10:57 +0000]
Merge "Make DownloadProvider use parameterized queries." into gingerbread

8 years agoMake DownloadProvider use parameterized queries.
Steve Howard [Fri, 8 Oct 2010 01:16:15 +0000]
Make DownloadProvider use parameterized queries.

This avoids filling up the query cache unnecessary, but required some
structural changes to ease the passing around of a selection along
with its arguments.

Change-Id: I724185763b94146d17573cab68f675c24e49634e

8 years agoam 49f78e40: Import revised translations. DO NOT MERGE
Eric Fischer [Thu, 7 Oct 2010 14:17:11 +0000]
am 49f78e40: Import revised translations.  DO NOT MERGE

Merge commit '49f78e40831793ff805bb602b226c372212998ec' into gingerbread-plus-aosp

* commit '49f78e40831793ff805bb602b226c372212998ec':
  Import revised translations.  DO NOT MERGE

8 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Thu, 7 Oct 2010 00:15:43 +0000]
Import revised translations.  DO NOT MERGE

Change-Id: I1f00b783250d0c4112cf7918f9ab05f83c209407

8 years agoam f5328cae: am e4b64535: Merge "Updated assets for downloads UI launcher icon" into...
Steve Howard [Mon, 4 Oct 2010 21:28:58 +0000]
am f5328cae: am e4b64535: Merge "Updated assets for downloads UI launcher icon" into gingerbread

Merge commit 'f5328cae2422ca2c03c6eb888545d6a56ccfdf0c'

* commit 'f5328cae2422ca2c03c6eb888545d6a56ccfdf0c':
  Updated assets for downloads UI launcher icon

8 years agoam e4b64535: Merge "Updated assets for downloads UI launcher icon" into gingerbread
Steve Howard [Mon, 4 Oct 2010 20:21:47 +0000]
am e4b64535: Merge "Updated assets for downloads UI launcher icon" into gingerbread

Merge commit 'e4b6453558531bc897720f9c94affc650c99e974' into gingerbread-plus-aosp

* commit 'e4b6453558531bc897720f9c94affc650c99e974':
  Updated assets for downloads UI launcher icon

8 years agoMerge "Updated assets for downloads UI launcher icon" into gingerbread
Steve Howard [Mon, 4 Oct 2010 20:20:07 +0000]
Merge "Updated assets for downloads UI launcher icon" into gingerbread

8 years agoam ace1d5da: am d4dc8501: Merge "Seriously improve error reporting in DownloadThread...
Steve Howard [Fri, 1 Oct 2010 21:19:03 +0000]
am ace1d5da: am d4dc8501: Merge "Seriously improve error reporting in DownloadThread." into gingerbread

Merge commit 'ace1d5da2b288f6166224cf2164731ae0fa2de61'

* commit 'ace1d5da2b288f6166224cf2164731ae0fa2de61':
  Seriously improve error reporting in DownloadThread.

8 years agoam 42469fa4: am 5d81e244: Avoid NPE when checking file URI in DownloadProvider
Steve Howard [Fri, 1 Oct 2010 21:18:58 +0000]
am 42469fa4: am 5d81e244: Avoid NPE when checking file URI in DownloadProvider

Merge commit '42469fa405c7aa891e7c431cd65edd424803979c'

* commit '42469fa405c7aa891e7c431cd65edd424803979c':
  Avoid NPE when checking file URI in DownloadProvider

8 years agoam d4dc8501: Merge "Seriously improve error reporting in DownloadThread." into ginger...
Steve Howard [Fri, 1 Oct 2010 20:16:13 +0000]
am d4dc8501: Merge "Seriously improve error reporting in DownloadThread." into gingerbread

Merge commit 'd4dc8501ecb89b91f865510207297dd960afe031' into gingerbread-plus-aosp

* commit 'd4dc8501ecb89b91f865510207297dd960afe031':
  Seriously improve error reporting in DownloadThread.