Reduce deletion logging.
Jeff Sharkey [Fri, 20 Jul 2012 23:06:35 +0000 (16:06 -0700)]
Bug: 6544953
Change-Id: I4157c67b9b9cddab4ade795c328a202f6a230f95

src/com/android/providers/downloads/DownloadService.java
src/com/android/providers/downloads/DownloadThread.java
src/com/android/providers/downloads/StorageManager.java

index 3b566f8..55efefc 100644 (file)
@@ -38,7 +38,6 @@ import android.os.RemoteException;
 import android.provider.Downloads;
 import android.text.TextUtils;
 import android.util.Log;
-import android.util.Slog;
 
 import com.android.internal.util.IndentingPrintWriter;
 import com.google.android.collect.Maps;
@@ -483,7 +482,9 @@ public class DownloadService extends Service {
             info.mStatus = Downloads.Impl.STATUS_CANCELED;
         }
         if (info.mDestination != Downloads.Impl.DESTINATION_EXTERNAL && info.mFileName != null) {
-            Slog.d(TAG, "deleteDownloadLocked() deleting " + info.mFileName);
+            if (Constants.LOGVV) {
+                Log.d(TAG, "deleteDownloadLocked() deleting " + info.mFileName);
+            }
             new File(info.mFileName).delete();
         }
         mSystemFacade.cancelNotification(info.mId);
@@ -559,7 +560,9 @@ public class DownloadService extends Service {
     private void deleteFileIfExists(String path) {
         try {
             if (!TextUtils.isEmpty(path)) {
-                Slog.d(TAG, "deleteFileIfExists() deleting " + path);
+                if (Constants.LOGVV) {
+                    Log.d(TAG, "deleteFileIfExists() deleting " + path);
+                }
                 File file = new File(path);
                 file.delete();
             }
index bd91eaa..37db32b 100644 (file)
@@ -33,7 +33,6 @@ import android.provider.Downloads;
 import android.text.TextUtils;
 import android.util.Log;
 import android.util.Pair;
-import android.util.Slog;
 
 import org.apache.http.Header;
 import org.apache.http.HttpResponse;
@@ -330,7 +329,9 @@ public class DownloadThread extends Thread {
 
         closeDestination(state);
         if (state.mFilename != null && Downloads.Impl.isStatusError(finalStatus)) {
-            Slog.d(TAG, "cleanupDestination() deleting " + state.mFilename);
+            if (Constants.LOGVV) {
+                Log.d(TAG, "cleanupDestination() deleting " + state.mFilename);
+            }
             new File(state.mFilename).delete();
             state.mFilename = null;
         }
@@ -847,8 +848,10 @@ public class DownloadThread extends Thread {
                 long fileLength = f.length();
                 if (fileLength == 0) {
                     // The download hadn't actually started, we can restart from scratch
-                    Slog.d(TAG, "setupDestinationFile() found fileLength=0, deleting "
-                            + state.mFilename);
+                    if (Constants.LOGVV) {
+                        Log.d(TAG, "setupDestinationFile() found fileLength=0, deleting "
+                                + state.mFilename);
+                    }
                     f.delete();
                     state.mFilename = null;
                     if (Constants.LOGV) {
@@ -857,8 +860,10 @@ public class DownloadThread extends Thread {
                     }
                 } else if (mInfo.mETag == null && !mInfo.mNoIntegrity) {
                     // This should've been caught upon failure
-                    Slog.d(TAG, "setupDestinationFile() unable to resume download, deleting "
-                            + state.mFilename);
+                    if (Constants.LOGVV) {
+                        Log.d(TAG, "setupDestinationFile() unable to resume download, deleting "
+                                + state.mFilename);
+                    }
                     f.delete();
                     throw new StopRequestException(Downloads.Impl.STATUS_CANNOT_RESUME,
                             "Trying to resume a download that can't be resumed");
index 4b51921..915d141 100644 (file)
@@ -30,7 +30,6 @@ import android.os.StatFs;
 import android.provider.Downloads;
 import android.text.TextUtils;
 import android.util.Log;
-import android.util.Slog;
 
 import com.android.internal.R;
 
@@ -342,9 +341,9 @@ class StorageManager {
                 if (TextUtils.isEmpty(data)) continue;
 
                 File file = new File(data);
-                if (true || Constants.LOGV) {
-                    Slog.d(Constants.TAG, "purging " + file.getAbsolutePath() + " for " +
-                            file.length() + " bytes");
+                if (Constants.LOGV) {
+                    Log.d(Constants.TAG, "purging " + file.getAbsolutePath() + " for "
+                            + file.length() + " bytes");
                 }
                 totalFreed += file.length();
                 file.delete();
@@ -416,7 +415,9 @@ class StorageManager {
             try {
                 final StructStat stat = Libcore.os.stat(path);
                 if (stat.st_uid == myUid) {
-                    Slog.d(TAG, "deleting spurious file " + path);
+                    if (Constants.LOGVV) {
+                        Log.d(TAG, "deleting spurious file " + path);
+                    }
                     file.delete();
                 }
             } catch (ErrnoException e) {