3 years agoMerge "Add hidden intent for sms based carrier provisioning." into mnc-dev
Junda Liu [Mon, 17 Aug 2015 18:58:20 +0000]
Merge "Add hidden intent for sms based carrier provisioning." into mnc-dev

3 years agoAdd hidden intent for sms based carrier provisioning.
Junda Liu [Thu, 13 Aug 2015 21:18:07 +0000]
Add hidden intent for sms based carrier provisioning.

Bug: b/22982966
Change-Id: I4ea1fe67f8554ed9ba9d76faab8883d147f9b4f3

3 years agoMerge "UE doesn't make 1x call if IMS not registered." into mnc-dev
Etan Cohen [Thu, 13 Aug 2015 23:58:57 +0000]
Merge "UE doesn't make 1x call if IMS not registered." into mnc-dev

3 years agoMerge "Don't set prefer network type on RIL connected." into mnc-dev
Junda Liu [Thu, 13 Aug 2015 23:29:10 +0000]
Merge "Don't set prefer network type on RIL connected." into mnc-dev

3 years agoDon't set prefer network type on RIL connected.
Junda Liu [Thu, 13 Aug 2015 20:58:28 +0000]
Don't set prefer network type on RIL connected.

Bug: b/23187758
Change-Id: Ie60893290665f0dc670571c6eccc07040cee1e37

3 years agoUE doesn't make 1x call if IMS not registered.
Moon Do Seo [Fri, 7 Aug 2015 21:43:10 +0000]
UE doesn't make 1x call if IMS not registered.

Root cause: App(telephony service) would check voice and data reg state to make MO call.
if both voice and data is out of service, Telephony service will block the call and pop
up a dialogfor user. FW only check voice reg state without data. When user make a MO
call while data in service, there is no failed notification at Telephony service layer
while the call is rejected by FW layer.

Bug: 23037591
Change-Id: I9762843326d71b801fa1a40b9832bcaea7fb7009

3 years agoMerge "Fixed the incorrect operator name displayed when roaming." into mnc-dev
Jack Yu [Wed, 12 Aug 2015 19:56:18 +0000]
Merge "Fixed the incorrect operator name displayed when roaming." into mnc-dev

3 years agoFixed the incorrect operator name displayed when roaming.
Jack Yu [Tue, 11 Aug 2015 20:50:20 +0000]
Fixed the incorrect operator name displayed when roaming.

The operator name was incorrectly overwritten when roaming
on partner's LTE network. In that case, ERI roaming indicator
is off, NID/SID is zero (because LTE does not support ERI/NID/SID).

The original requirement for using the name from CSIM EF_SPN
is for CDMA only (b/5008969), therefore we need to make sure the
logic is not applied in the LTE case.

bug: 22951507
Change-Id: I3595228e1a637f4bfd05e34cf9a702bb0e1bba59

3 years agoSave data registration roaming state
Chris Manton [Fri, 7 Aug 2015 23:40:54 +0000]
Save data registration roaming state

Some carriers require different APNs based upon
the roaming state returned in a previous registration
call.  The carrier config has the option to override
roaming state.  This change saves the proper roaming
state before the carrier config may override in order
to select the proper APN when setting up a data connection.

bug: 22990977
Change-Id: Id22a60efcbea9637018cc47e6d97f68eb053deb0

3 years agoMerge "Set ServiceState before flags are evaluated" into mnc-dev
Amit Mahajan [Mon, 10 Aug 2015 22:02:50 +0000]
Merge "Set ServiceState before flags are evaluated" into mnc-dev

3 years agoMerge "Adding EmergencyCall state to DcSwitch state machine." into mnc-dev
Amit Mahajan [Mon, 10 Aug 2015 22:01:25 +0000]
Merge "Adding EmergencyCall state to DcSwitch state machine." into mnc-dev

3 years agoSet ServiceState before flags are evaluated
Sukanya Rajkhowa [Sat, 9 May 2015 00:30:45 +0000]
Set ServiceState before flags are evaluated

If APM is turned on while service state is OUT_OF_SERVICE and right when
polling for VOICE_REGISTRATION_STATE is being handled, the service state
change to APM is not notified to the registrants. Fix this by setting
service state before flags for change in state are evaluated

Bug: 22960426
Change-Id: I781344afe13120bc0fb8e6889c46b80f8a672db1

3 years agoAdding EmergencyCall state to DcSwitch state machine.
Amit Mahajan [Tue, 4 Aug 2015 18:42:08 +0000]
Adding EmergencyCall state to DcSwitch state machine.

State will be entered on making emergency call, and ended either on
emergency call end or emergency callback mode end if that is supported.
This is only for CDMA.

Bug: 22777920
Change-Id: I9cac544966b1b6be5410a40273d20e52cab8b396

3 years agoMerge "READ_SMS allows getLine1Number() [3/3]" into mnc-dev
Makoto Onuki [Wed, 5 Aug 2015 16:55:36 +0000]
Merge "READ_SMS allows getLine1Number() [3/3]" into mnc-dev

3 years agoMerge "Fix NOT_RESTRICTED network capability and enforce it." into mnc-dev
Paul Jensen [Wed, 5 Aug 2015 10:04:11 +0000]
Merge "Fix NOT_RESTRICTED network capability and enforce it." into mnc-dev

3 years agoFix build break - typo
Etan Cohen [Tue, 4 Aug 2015 00:36:01 +0000]
Fix build break - typo

Change-Id: Ia9ecea8a2d0cae3bf122ab6a1c89779258b06cba

3 years agoMerge "Only use IMS for E911 if VoLTE is supported on device/carrier." into mnc-dev
Etan Cohen [Tue, 4 Aug 2015 00:30:34 +0000]
Merge "Only use IMS for E911 if VoLTE is supported on device/carrier." into mnc-dev

3 years agoOnly use IMS for E911 if VoLTE is supported on device/carrier.
Etan Cohen [Tue, 4 Aug 2015 00:25:20 +0000]
Only use IMS for E911 if VoLTE is supported on device/carrier.

Bug: 22777920
Change-Id: I5f79c36a7e9b89f70b69b0cab098d8b0a288b1b9

3 years agoREAD_SMS allows getLine1Number() [3/3]
Makoto Onuki [Mon, 3 Aug 2015 22:12:34 +0000]
READ_SMS allows getLine1Number() [3/3]

Bug 22862050

Change-Id: I0cb90152b64508a173f51dd2b6dbaa79f4df8849

3 years agoFix CDMA data call issue after emergency call failure.
Rakesh Pallerla [Wed, 13 Aug 2014 14:59:42 +0000]
Fix CDMA data call issue after emergency call failure.

When emergency call is dialled in CDMA mode, telephony disables
data internally. Data is re enabled after call is ended  if
not in ECBM. If emergency mo call is dropped by network/modem
before going to dialing state, the data is not re enabled.
Fix this scenario by explicitly re enabling data.

Bug: 22826595
Change-Id: I7a62d459dbd6ef6a833fe87e7d35e29311a515fe

3 years agoFix NOT_RESTRICTED network capability and enforce it.
Paul Jensen [Fri, 31 Jul 2015 15:00:26 +0000]
Fix NOT_RESTRICTED network capability and enforce it.

With this change:
1. NOT_RESTRICTED should be removed from NetworkRequests that bring up
   special restricted carrier networks (e.g. IMS, FOTA).
2. NetworkRequests without NOT_RESTRICTED require CONNECTIVITY_INTERNAL
   permission to register
3. Binding sockets to networks without NOT_RESTRICTED requires
   CONNECTIVITY_INTERNAL permission

Bug:21637535
Change-Id: I5991d39facaa6b690e969fe15dcbeec52e918321

3 years agoMerge "Revert "Removing OrSelf check when checking for PRIVILEGED_PHONE_STATE perm...
Ian Pedowitz [Thu, 30 Jul 2015 20:26:39 +0000]
Merge "Revert "Removing OrSelf check when checking for PRIVILEGED_PHONE_STATE perm."" into mnc-dev

3 years agoRevert "Removing OrSelf check when checking for PRIVILEGED_PHONE_STATE perm."
Svetoslav Ganov [Thu, 30 Jul 2015 20:04:37 +0000]
Revert "Removing OrSelf check when checking for PRIVILEGED_PHONE_STATE perm."

This reverts commit b872941b01c651df631b4b4700f3493b2f517f7b.

Change-Id: Idcc5c7817ab405cec136884528238b51ef762273

3 years agoMerge "Release DataConnection when a rety is interupted" into mnc-dev
Robert Greenwalt [Thu, 30 Jul 2015 17:11:51 +0000]
Merge "Release DataConnection when a rety is interupted" into mnc-dev

3 years agoMake canada use en-US by default if the LI is "en"
Narayan Kamath [Wed, 29 Jul 2015 10:50:05 +0000]
Make canada use en-US by default if the LI is "en"

Introduce the notion of a fallback mapping to choose a fallback
locale with the same language if an exact match is found. "en-CA"
will fall back to "en-US" under this arrangement. If no fallback
is specified, we continue to arbitrarily choose the first locale
in the list where the language matches.

Also, take the SIM records (EF-LI, EF-PL) into consideration when
matching locales. If we can't find a match based on the sim language,
we fall back to the "likely" language based on ICU data.

bug: 22684963

Change-Id: I8259fd16fc45bbaf2632256cd6f29b46317a5e23

3 years agoRelease DataConnection when a rety is interupted
Robert Greenwalt [Thu, 30 Jul 2015 00:57:12 +0000]
Release DataConnection when a rety is interupted

We had code that simply set the ApnContexts state to IDLE, but
there was still a connection between ApnContext and DataConnection,
so when looking for a DC, we'd skip this one (it's busy) and when
the rety alarm fires we end up with a second DC attempting to connect
to the same APN.

bug:22410092
Change-Id: Id4ab6a4f1f08588e552e846a1986f93192a72568

3 years agoMerge "Add API to let carrier app send SMS without auto persisting." into mnc-dev
Ji Yang [Wed, 29 Jul 2015 22:35:30 +0000]
Merge "Add API to let carrier app send SMS without auto persisting." into mnc-dev

3 years agoAdd API to let carrier app send SMS without auto persisting.
Ji Yang [Wed, 22 Jul 2015 22:27:12 +0000]
Add API to let carrier app send SMS without auto persisting.

Bug: 22773702
Change-Id: Ib126e79b0d1e2f9a9a44afe2b3f1895c150bd86b

3 years agoMerge "Revert "DO NOT MERGE Add logging to detect the start of a sync problem.""...
Robert Greenwalt [Wed, 29 Jul 2015 22:00:39 +0000]
Merge "Revert "DO NOT MERGE Add logging to detect the start of a sync problem."" into mnc-dev

3 years agoMerge "Use apn id which contains default type when merging apns" into mnc-dev
Thierry Strudel [Wed, 29 Jul 2015 21:41:55 +0000]
Merge "Use apn id which contains default type when merging apns" into mnc-dev

3 years agoUse apn id which contains default type when merging apns
Sungmin Choi [Tue, 21 Jul 2015 08:19:28 +0000]
Use apn id which contains default type when merging apns

In case of the following conditions, UI does not show preferred apn.
1. there are default and mms profile, respectively.
2. apns for default and mms are same.
3. mms profile is prior to default profile.

To fix it, use apn id which contains default type when merging apns.

Bug: 22641500
Change-Id: Ieec521f715f137aa7a827ee010390e3c47b35da1

3 years agoRevert "DO NOT MERGE Add logging to detect the start of a sync problem."
Robert Greenwalt [Wed, 29 Jul 2015 20:35:03 +0000]
Revert "DO NOT MERGE Add logging to detect the start of a sync problem."

This reverts commit f65485c99cf0fb0e844ae9e39c2c6cd6bae0fd2c.

bug:22632129
Change-Id: I531668bc0874c71c70773ceda071cf5a7f5c1121

3 years agoCatch nulls in the new logging code.
Robert Greenwalt [Tue, 28 Jul 2015 21:04:38 +0000]
Catch nulls in the new logging code.

bug:22723423
Change-Id: I2e019732944e4738698db828cd4620963a5791dc

3 years agoMerge "Change to not delete part of multipart SMS when waiting for other parts" into...
Amit Mahajan [Mon, 27 Jul 2015 18:58:10 +0000]
Merge "Change to not delete part of multipart SMS when waiting for other parts" into mnc-dev

3 years agoChange to not delete part of multipart SMS when waiting for other parts
Amit Mahajan [Mon, 27 Jul 2015 17:50:04 +0000]
Change to not delete part of multipart SMS when waiting for other parts

Bug: 22761826
Change-Id: I947a82c15f0df50350886daceca8fa592b8bf589

3 years agoMerge "Allow normal voice calls on CS phone only when in service." into mnc-dev
Etan Cohen [Mon, 27 Jul 2015 16:17:42 +0000]
Merge "Allow normal voice calls on CS phone only when in service." into mnc-dev

3 years agoMerge "Handle out-of-order request execution." into mnc-dev
Robert Greenwalt [Sat, 25 Jul 2015 00:04:29 +0000]
Merge "Handle out-of-order request execution." into mnc-dev

3 years agoHandle out-of-order request execution.
Robert Greenwalt [Fri, 24 Jul 2015 23:48:43 +0000]
Handle out-of-order request execution.

Don't process executeRequest if the request has been released.
A more comprehensive fix.

bug:22632129
Change-Id: Iadc78af0310091b962c6e803526811a243938095

3 years agoMerge "Change to make sure InboundSmsHandler stm gets out of DeliveringState" into...
Amit Mahajan [Fri, 24 Jul 2015 23:46:14 +0000]
Merge "Change to make sure InboundSmsHandler stm gets out of DeliveringState" into mnc-dev

3 years agoChange to make sure InboundSmsHandler stm gets out of DeliveringState
Amit Mahajan [Fri, 24 Jul 2015 21:59:17 +0000]
Change to make sure InboundSmsHandler stm gets out of DeliveringState

Bug: 22673185
Change-Id: Icdd972845660bab2b4b26e0c3fc3a174868dbb8b

3 years agoMerge "DO NOT MERGE Add logging to detect the start of a sync problem." into mnc-dev
Robert Greenwalt [Fri, 24 Jul 2015 19:15:20 +0000]
Merge "DO NOT MERGE Add logging to detect the start of a sync problem." into mnc-dev

3 years agoDO NOT MERGE Add logging to detect the start of a sync problem.
Robert Greenwalt [Thu, 23 Jul 2015 22:52:42 +0000]
DO NOT MERGE Add logging to detect the start of a sync problem.

This should be removed prior to shipment!

The DctController is getting out of sync with the ApnContexts.  Add a callback
mechanism so the ApnContexts can let DctController know when they apply a change
and then when all is quiet we can compare and verify everything is good.

Potentially can fix the problem detected too (if there should be no live requests, nuke
the ref counts) but currently turned off so people will notice problems (battery life) and
file bugreports with the data of how it started.

bug:22632129
Change-Id: I84a67687f0b6dc43b2e429943935f4045ffc51ed

3 years agoAllow normal voice calls on CS phone only when in service.
Anju Mathapati [Wed, 8 Jul 2015 21:54:25 +0000]
Allow normal voice calls on CS phone only when in service.

If there is no service in GSM/CDMA do not allow dial requests
for non emergency CS voice calls.

Bug: 22351845
Change-Id: I7f6f196ff7975442876cb734122defebaee9f7af

3 years agoMerge "Change to read carrier specific config only after reading IMSI." into mnc-dev
Amit Mahajan [Thu, 23 Jul 2015 23:59:39 +0000]
Merge "Change to read carrier specific config only after reading IMSI." into mnc-dev

3 years agoChange to read carrier specific config only after reading IMSI.
Amit Mahajan [Thu, 23 Jul 2015 22:30:21 +0000]
Change to read carrier specific config only after reading IMSI.

This is to make sure we decide to use language settings from SIM
(which is controlled by a carrier specific config) only after
the mcc-mnc is known.

Bug: 22255379
Change-Id: I1e0491e9ed01fa27bcb32d6f3708e091a0e25cb5

3 years agoMerge "Improve logging in ImsPhoneCallTracker.onFeatureCapabilityChanged()" into...
Nathan Harold [Thu, 23 Jul 2015 00:37:10 +0000]
Merge "Improve logging in ImsPhoneCallTracker.onFeatureCapabilityChanged()" into mnc-dev

3 years agoImprove logging in ImsPhoneCallTracker.onFeatureCapabilityChanged()
Nathan Harold [Tue, 21 Jul 2015 21:43:22 +0000]
Improve logging in ImsPhoneCallTracker.onFeatureCapabilityChanged()

Change-Id: I839316f14bc53d2c4ec5a39112c6bed5263173c2

3 years agoMerge "Add logs to PhoneFactory" into mnc-dev
Robert Greenwalt [Wed, 22 Jul 2015 23:39:41 +0000]
Merge "Add logs to PhoneFactory" into mnc-dev

3 years agoAdd logs to PhoneFactory
Robert Greenwalt [Wed, 22 Jul 2015 19:48:00 +0000]
Add logs to PhoneFactory

Allow entities in the phone process to easily add logs
to TelephonyDebugService.

First user, VVM.

Bug: 22607570

Change-Id: I65cfaf723db647a3747f72f404b690a5ab110811

3 years agoMerge "Fix issue #22612630: Ensure SMS/Call delivery during Doze" into mnc-dev
Dianne Hackborn [Wed, 22 Jul 2015 19:04:00 +0000]
Merge "Fix issue #22612630: Ensure SMS/Call delivery during Doze" into mnc-dev

3 years agoFix issue #22612630: Ensure SMS/Call delivery during Doze
Dianne Hackborn [Wed, 22 Jul 2015 00:40:17 +0000]
Fix issue #22612630: Ensure SMS/Call delivery during Doze

Place apps on whitelist when delivering SMS, like MMS.

Change-Id: Ied719152e84ba88cb2c224ed1669cb12c1412ee7

3 years agoMerge "Do not update RAF for invalid sub IDs." into mnc-dev
Etan Cohen [Tue, 21 Jul 2015 21:58:58 +0000]
Merge "Do not update RAF for invalid sub IDs." into mnc-dev

3 years agoLog any Orphaned NetworkRequests.
Robert Greenwalt [Tue, 21 Jul 2015 20:45:23 +0000]
Log any Orphaned NetworkRequests.

Try to figure out why the ApnContext isn't told the request is dead.

bug:22632129
Change-Id: I24a592e6a45c4476fabff50d8c640fb6ec6af6e1

3 years agoDo not update RAF for invalid sub IDs.
Etan Cohen [Tue, 21 Jul 2015 19:50:49 +0000]
Do not update RAF for invalid sub IDs.

Bug: 22076899
Change-Id: I44c6744d6464d13a0803a6480ee72f07bda7c087

4 years agoMerge "Prevent preciseCallStateChanged from firing for media capabilities change...
Tyler Gunn [Mon, 20 Jul 2015 21:38:21 +0000]
Merge "Prevent preciseCallStateChanged from firing for media capabilities change." into mnc-dev

4 years agoMerge "Support optional modem restart on certain errors." into mnc-dev
Robert Greenwalt [Mon, 20 Jul 2015 21:10:39 +0000]
Merge "Support optional modem restart on certain errors." into mnc-dev

4 years agoPrevent preciseCallStateChanged from firing for media capabilities change.
Tyler Gunn [Mon, 20 Jul 2015 20:49:53 +0000]
Prevent preciseCallStateChanged from firing for media capabilities change.

In processCallStateChanged, there was the potential for
"notifyPreciseCallStateChanged()" to be called, even if ignoreState was
true.  Moved the code for invoking the precise call state changed
callback into the "else" clause of the conditional.

Bug: 22564433
Change-Id: Ib2a05bd5f592005d57623812c6cd40c2bfcbf253

4 years agoam b563e820: am 5ebb8d7b: am 9497ef73: am f7abcb0d: am 455730f8: am 27bc967b: am...
Tom Taylor [Fri, 17 Jul 2015 18:31:39 +0000]
am b563e820: am 5ebb8d7b: am 9497ef73: am f7abcb0d: am 455730f8: am 27bc967b: am 193f193f: Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

* commit 'b563e820f028513a6f0ec301434f03141eeedba9':
  Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

4 years agoam 5ebb8d7b: am 9497ef73: am f7abcb0d: am 455730f8: am 27bc967b: am 193f193f: Externa...
Tom Taylor [Fri, 17 Jul 2015 18:18:14 +0000]
am 5ebb8d7b: am 9497ef73: am f7abcb0d: am 455730f8: am 27bc967b: am 193f193f: Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

* commit '5ebb8d7b45f9f8a43087ce2da3399fb617470935':
  Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

4 years agoam 9497ef73: am f7abcb0d: am 455730f8: am 27bc967b: am 193f193f: Externally-reported...
Tom Taylor [Fri, 17 Jul 2015 18:02:47 +0000]
am 9497ef73: am f7abcb0d: am 455730f8: am 27bc967b: am 193f193f: Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

* commit '9497ef73bcac42e27f98804b3d508fea8e55ebd4':
  Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

4 years agoam f7abcb0d: am 455730f8: am 27bc967b: am 193f193f: Externally-reported Moderate...
Tom Taylor [Fri, 17 Jul 2015 17:49:00 +0000]
am f7abcb0d: am 455730f8: am 27bc967b: am 193f193f: Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

* commit 'f7abcb0d75304e223288f74e5f224cae07bee3e0':
  Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

4 years agoam f7bd55ac: am 751a152c: am 32deeeea: am 92837b8a: am 21ac5f11: Externally-reported...
Tom Taylor [Fri, 17 Jul 2015 17:47:38 +0000]
am f7bd55ac: am 751a152c: am 32deeeea: am 92837b8a: am 21ac5f11: Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

* commit 'f7bd55ac36052e0e08c087a3dba98ab1b3a165db':
  Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

4 years agoam 751a152c: am 32deeeea: am 92837b8a: am 21ac5f11: Externally-reported Moderate...
Tom Taylor [Fri, 17 Jul 2015 17:33:55 +0000]
am 751a152c: am 32deeeea: am 92837b8a: am 21ac5f11: Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

* commit '751a152c72794cac87d4049b221ab9b765f39506':
  Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

4 years agoam 455730f8: am 27bc967b: am 193f193f: Externally-reported Moderate severity vulnerab...
Tom Taylor [Fri, 17 Jul 2015 17:33:25 +0000]
am 455730f8: am 27bc967b: am 193f193f: Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

* commit '455730f8e76ef539a9dcfdad2d38b7541a7654d4':
  Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

4 years agoMerge "Change max retry from 3 to 1." into mnc-dev
Junda Liu [Fri, 17 Jul 2015 17:24:10 +0000]
Merge "Change max retry from 3 to 1." into mnc-dev

4 years agoam 36b1a525: am 347352b5: am fb8ec484: Externally-reported Moderate severity vulnerab...
Tom Taylor [Fri, 17 Jul 2015 17:21:30 +0000]
am 36b1a525: am 347352b5: am fb8ec484: Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

* commit '36b1a5253b309930bb8225c909182b44d064b38c':
  Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

4 years agoam 27bc967b: am 193f193f: Externally-reported Moderate severity vulnerability in...
Tom Taylor [Fri, 17 Jul 2015 17:21:06 +0000]
am 27bc967b: am 193f193f: Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

* commit '27bc967ba840d2e2a8941d60aef89d0cb80b1626':
  Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

4 years agoam 32deeeea: am 92837b8a: am 21ac5f11: Externally-reported Moderate severity vulnerab...
Tom Taylor [Fri, 17 Jul 2015 17:19:18 +0000]
am 32deeeea: am 92837b8a: am 21ac5f11: Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

* commit '32deeeeab31cb25356686c5209318ec1c58ed359':
  Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

4 years agoChange max retry from 3 to 1.
Junda Liu [Fri, 17 Jul 2015 17:14:54 +0000]
Change max retry from 3 to 1.

Bug: b/22216437
Change-Id: Ib97d982fa918e79368ddd1d3b51a5427c10c7931

4 years agoam 92837b8a: am 21ac5f11: Externally-reported Moderate severity vulnerability in...
Tom Taylor [Fri, 17 Jul 2015 17:09:26 +0000]
am 92837b8a: am 21ac5f11: Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

* commit '92837b8a9c44f6192ea4d613efa2cfe53156a9df':
  Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

4 years agoam 193f193f: Externally-reported Moderate severity vulnerability in SMS: Apps can...
Tom Taylor [Fri, 17 Jul 2015 17:08:25 +0000]
am 193f193f: Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

* commit '193f193f79f06784fc1cb90328c4410c6b52820e':
  Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

4 years agoam 347352b5: am fb8ec484: Externally-reported Moderate severity vulnerability in...
Tom Taylor [Fri, 17 Jul 2015 17:05:54 +0000]
am 347352b5: am fb8ec484: Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

* commit '347352b548a1950b65e51bbba3ea616e52bd2eab':
  Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

4 years agoSupport optional modem restart on certain errors.
Robert Greenwalt [Fri, 17 Jul 2015 17:03:45 +0000]
Support optional modem restart on certain errors.

Error counts are shared between all APNs, but fresh connect attempt
resets the counts.

bug:22455853
Change-Id: Id398a223d33d42f979b5cdc4a2bc263e92eb73cc

4 years agoam 21ac5f11: Externally-reported Moderate severity vulnerability in SMS: Apps can...
Tom Taylor [Fri, 17 Jul 2015 16:53:38 +0000]
am 21ac5f11: Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

* commit '21ac5f1161b7554c564dd1213aef357fa4b4ca84':
  Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

4 years agoam fb8ec484: Externally-reported Moderate severity vulnerability in SMS: Apps can...
Tom Taylor [Fri, 17 Jul 2015 16:51:46 +0000]
am fb8ec484: Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

* commit 'fb8ec484cfca6bd4f295fea70e75dad278781912':
  Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

4 years agoMerge "Add new API for acessing DB associated with Subscription." into mnc-dev
Sanket Padawe [Thu, 16 Jul 2015 05:01:06 +0000]
Merge "Add new API for acessing DB associated with Subscription." into mnc-dev

4 years agoMerge "Enhance ImsPhoneCall/Tracker logging and fix swap on bad state change" into...
Tyler Gunn [Wed, 15 Jul 2015 22:31:43 +0000]
Merge "Enhance ImsPhoneCall/Tracker logging and fix swap on bad state change" into mnc-dev

4 years agoFix issue #21626564: MMS should be receivied while Dozing
Dianne Hackborn [Tue, 14 Jul 2015 01:02:47 +0000]
Fix issue #21626564: MMS should be receivied while Dozing

Uses new APIs to put apps on the whitelist as needed.

Change-Id: I24bf0c00f2a7dca64590e7fc0dd6ec036e9bd2bf

4 years agoMerge "Add unregistration method for post-dial listeners." into mnc-dev
Santos Cordon [Tue, 14 Jul 2015 22:01:40 +0000]
Merge "Add unregistration method for post-dial listeners." into mnc-dev

4 years agoMerge "Add logging for telephony network requests." into mnc-dev
Robert Greenwalt [Tue, 14 Jul 2015 21:19:26 +0000]
Merge "Add logging for telephony network requests." into mnc-dev

4 years agoAdd logging for telephony network requests.
Robert Greenwalt [Wed, 8 Jul 2015 23:26:07 +0000]
Add logging for telephony network requests.

Try to track and retain what happens to requests to get to the bottom of
20731384.

bug:20731384
bug:21641873
Change-Id: Iabb01b3866c6748323a967e26c008246b29bdb17

4 years agoEnhance ImsPhoneCall/Tracker logging and fix swap on bad state change
Tyler Gunn [Tue, 14 Jul 2015 18:20:12 +0000]
Enhance ImsPhoneCall/Tracker logging and fix swap on bad state change

ImsPhoneConnection:
- Added check in update() to ensure we skip the update if we are putting
the call into an ACTIVE state, but there is a pending request to
hold the ImsCall.  This is really a bug in the RIL; we are NOT getting
the callSessionHeld callback when putting a recently formed conference
call into the background.  Without this check, we end up detaching the
ImsPhoneConnection from the "background" ImsPhoneCall and attaching it
to the "foreground" ImsPhoneConnection, which causes a scenario where there
are multiple active calls at the same time.  I will file a bug against
the RIL to fix this missing state reporting.

ImsPhoneCallTracker:
- in switchWaitingOrHoldingAndActive check for the case where we are
holding a foreground call and reset the flag indicating we're expecting
to see a resume.  This wasn't causing the bug I was working on but I
can see how it might have undesirable effects.
- added some extra debug logging to help track down hold/resumes
- fixed some BAD logic in onCallMerged added in change ID
I94abbae37eb6773f1824c0e5c3a267d345610ada.  This code was swapping the
ImsPhoneCall references for foreground and background directly in order
to ensure that the right calls were passed in to ImsPhoneCall#merge.
The ImsPhoneCallTracker assumes the ImsPhoneCalls mForegroundCall and
mBackgroundCall will always stay the same; ImsPhoneConnections are attached
and detached from these ImsPhoneCalls, but the original references must
stay the same.  Fixed up that code to ensure it does what its supposed to
without messing up the original references.
- Added logState method which can be turned on via debug flag to periodically
dump verbose state of the calls tracked my ImsPhoneCallTracker.  I had
a hard time figuring out what was going on and this helped a lot.

ImsPhoneCall:
- Added enhanced logging when ImsPhoneConnections are moved between the
foreground, background, etc calls.  Also added knowledge of whether an
ImsPhoneCall is a foreground or background call so that logging can be made
more clear.

- After operations which change which calls are FG or BG, calling
ImsPhoneCallTracker.logState() which will log the full ImsPhoneCallTracker
state for even easier debugging (but only if the stop-ship flag is on).

Bug: 22173672
Change-Id: I704af9522a81ee036f290c7c723de4c3602229fd

4 years agoAdd new API for acessing DB associated with Subscription.
Sanket Padawe [Tue, 14 Jul 2015 18:16:56 +0000]
Add new API for acessing DB associated with Subscription.

Bug: 22360525
Change-Id: Ia51f38bab5327f77de4997cb4695959a5573048f

4 years agoAdd unregistration method for post-dial listeners.
Santos Cordon [Fri, 10 Jul 2015 23:05:59 +0000]
Add unregistration method for post-dial listeners.

Bug: 22410282
Change-Id: I6e24c83108f635542e81f05e53a4dd5a51b69141

4 years agoIMS: Do not update connection state for onCallUpdated callback.
Anju Mathapati [Mon, 8 Dec 2014 13:51:51 +0000]
IMS: Do not update connection state for onCallUpdated callback.

onCallUpdated callback is to inform updates on parameters of ImsCall
other than the call state. Updating the call state during onCallUpdated
is sometimes corrupting the connection state, especially during
hold/resume operation. Hence refactored code to not update state
of connection for call updated callback.

Change-Id: I55ed948fe3b5b03f8836b84d7952a39f97cd2a8a
Bug: 22170586

4 years agoMerge "Fix NPE in Ril when RIL_REQUEST_SIM_AUTHENTICATION returns NULL" into mnc-dev
Nathan Harold [Tue, 14 Jul 2015 00:32:27 +0000]
Merge "Fix NPE in Ril when RIL_REQUEST_SIM_AUTHENTICATION returns NULL" into mnc-dev

4 years agoFix NPE in Ril when RIL_REQUEST_SIM_AUTHENTICATION returns NULL
Nathan Harold [Mon, 13 Jul 2015 21:56:10 +0000]
Fix NPE in Ril when RIL_REQUEST_SIM_AUTHENTICATION returns NULL

bug: 22457261
Change-Id: I5aad5ffd41527652c560e934eb0e154f0e0bfdca

4 years agoMerge "Removing OrSelf check when checking for PRIVILEGED_PHONE_STATE perm." into...
Amit Mahajan [Mon, 13 Jul 2015 22:06:03 +0000]
Merge "Removing OrSelf check when checking for PRIVILEGED_PHONE_STATE perm." into mnc-dev

4 years agoMerge "Add localLog to UiccCard to record logical channel open/close." into mnc-dev
Junda Liu [Mon, 13 Jul 2015 18:06:33 +0000]
Merge "Add localLog to UiccCard to record logical channel open/close." into mnc-dev

4 years agoRemoving OrSelf check when checking for PRIVILEGED_PHONE_STATE perm.
Amit Mahajan [Sat, 11 Jul 2015 00:31:46 +0000]
Removing OrSelf check when checking for PRIVILEGED_PHONE_STATE perm.

Self check is done as part of READ_PHONE_STATE and AppOps checks.

Bug: 22376654
Change-Id: I437f9bf324950cb70bae5be76699824da5897a6f

4 years agoMerge "Fixed that phone service crashed during boot up issue." into mnc-dev
Jack Yu [Fri, 10 Jul 2015 20:49:42 +0000]
Merge "Fixed that phone service crashed during boot up issue." into mnc-dev

4 years agoExternally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS...
Tom Taylor [Fri, 10 Jul 2015 20:04:43 +0000]
Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

Bug 22314646

When android.permission.SEND_SMS_NO_CONFIRMATION was renamed to
android.permission.SEND_RESPOND_VIA_MESSAGE in JB-MR2, the necessary change
in SmsDispatcher was accidentally overlooked.

Change-Id: Ie2e3c5e365af3f6e0810e3792c9ae9c4aca0bcf7

4 years agoMerge "Enable EMERGENCY mobile connections." into mnc-dev
Robert Greenwalt [Fri, 10 Jul 2015 18:23:12 +0000]
Merge "Enable EMERGENCY mobile connections." into mnc-dev

4 years agoExternally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS...
Tom Taylor [Fri, 10 Jul 2015 18:21:34 +0000]
Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

Bug 22314646

DO NOT MERGE

When android.permission.SEND_SMS_NO_CONFIRMATION was renamed to
android.permission.SEND_RESPOND_VIA_MESSAGE in JB-MR2, the necessary change
in SmsDispatcher was accidentally overlooked.

Change-Id: I2c3aa79da8064e55cec5a786696de519c2bf0b07

4 years agoFixed that phone service crashed during boot up issue.
Jack Yu [Fri, 10 Jul 2015 18:04:11 +0000]
Fixed that phone service crashed during boot up issue.

bug: 22357173
Change-Id: I3b76a74c698e22c887b3482a3bdcbc34982ec658

4 years agoExternally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS...
Tom Taylor [Fri, 10 Jul 2015 18:00:44 +0000]
Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

Bug 22314646

When android.permission.SEND_SMS_NO_CONFIRMATION was renamed to
android.permission.SEND_RESPOND_VIA_MESSAGE in JB-MR2, the necessary change
in SmsDispatcher was accidentally overlooked.

Change-Id: I58aef2d044b8a48b1b42311a471cb112e3a258e4

4 years agoMerge "Externally-reported Moderate severity vulnerability in SMS: Apps can bypass...
Tom Taylor [Fri, 10 Jul 2015 16:06:47 +0000]
Merge "Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt" into mnc-dev

4 years agoMerge "Revert "Dont fail if modem ids are empty."" into mnc-dev
Nicholas Sauer [Fri, 10 Jul 2015 04:49:44 +0000]
Merge "Revert "Dont fail if modem ids are empty."" into mnc-dev

4 years agoEnable EMERGENCY mobile connections.
Robert Greenwalt [Thu, 9 Jul 2015 21:44:16 +0000]
Enable EMERGENCY mobile connections.

Hooks the ConnectivityManager.TYPE_MOBILE_EMERGENCY,
PhoneConstants.APN_TYPE_EMERGENCY, and NetworkCapabilities.NET_CAPABILITY_EIMS
together so carrier apps can request connections to this APN.

bug:21785357
Change-Id: Iafd477dbc7bda89de888a124602b21efbbaa6712

4 years agoMerge "Fix data call issue for null APN" into mnc-dev
Etan Cohen [Thu, 9 Jul 2015 21:43:52 +0000]
Merge "Fix data call issue for null APN" into mnc-dev