8 years agosctp: bail from sctp_endpoint_lookup_assoc() if not bound
Vlad Yasevich [Tue, 19 Apr 2011 21:29:23 +0000]
sctp: bail from sctp_endpoint_lookup_assoc() if not bound

The sctp_endpoint_lookup_assoc() function uses a port hash
to lookup the association and then checks to see if any of
them are on the current endpoint.  However, if the current
endpoint is not bound, there can't be any associations on
it, thus we can bail early.

Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agosctp: remove completely unsed EMPTY state
Vlad Yasevich [Tue, 19 Apr 2011 21:28:26 +0000]
sctp: remove completely unsed EMPTY state

SCTP does not SCTP_STATE_EMPTY and we can never be in
that state.  Remove useless code.

Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agosctp: remove redundant check when walking through a list of TLV parameters
Shan Wei [Tue, 19 Apr 2011 21:27:07 +0000]
sctp: remove redundant check when walking through a list of TLV parameters

When  pos.v <= (void *)chunk + end - ntohs(pos.p->length) and
ntohs(pos.p->length) >= sizeof(sctp_paramhdr_t) these two expressions are all true,
pos.v <= (void *)chunk + end - sizeof(sctp_paramhdr_t) *must* be true.

This patch removes this kind of redundant check.
It's same to  _sctp_walk_errors macro.

Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agosctp: check invalid value of length parameter in error cause
Shan Wei [Tue, 19 Apr 2011 21:26:26 +0000]
sctp: check invalid value of length parameter in error cause

RFC4960, section 3.3.7 said:
 If an endpoint receives an ABORT with a format error or no TCB is
 found, it MUST silently discard it.

When an endpoint receives ABORT that parameter value is invalid,
drop it.

Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agosctp: check parameter value of length in ERROR chunk
Shan Wei [Tue, 19 Apr 2011 21:25:40 +0000]
sctp: check parameter value of length in ERROR chunk

When an endpoint receives ERROR that parameter value is invalid,
send an ABORT to peer with a Protocol Violation error code.

Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: tun: convert to hw_features
Michał Mirosław [Tue, 19 Apr 2011 06:13:10 +0000]
net: tun: convert to hw_features

This changes offload setting behaviour to what I think is correct:
 - offloads set via ethtool mean what admin wants to use (by default
   he wants 'em all)
 - offloads set via ioctl() mean what userspace is expecting to get
   (this limits which admin wishes are granted)
 - TUN_NOCHECKSUM is ignored, as it might cause broken packets when
   forwarded (ip_summed == CHECKSUM_UNNECESSARY means that checksum
   was verified, not that it can be ignored)

If TUN_NOCHECKSUM is implemented, it should set skb->csum_* and
skb->ip_summed (= CHECKSUM_PARTIAL) for known protocols and let others
be verified by kernel when necessary.

TUN_NOCHECKSUM handling was introduced by commit
f43798c27684ab925adde7d8acc34c78c6e50df8:

    tun: Allow GSO using virtio_net_hdr

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: xen-netback: convert to hw_features
Michał Mirosław [Tue, 19 Apr 2011 03:35:06 +0000]
net: xen-netback: convert to hw_features

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: qlcnic: convert to hw_features
Michał Mirosław [Tue, 19 Apr 2011 03:03:57 +0000]
net: qlcnic: convert to hw_features

Bit more than minimal conversion. There might be some issues because
of qlcnic_set_netdev_features() if it's called after netdev init.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: ibmveth: convert to hw_features
Michał Mirosław [Tue, 19 Apr 2011 02:14:25 +0000]
net: ibmveth: convert to hw_features

A minimal conversion.

ibmveth_set_csum_offload() can be folded into ibmveth_set_features()
and adapter->rx_csum removed - left for later cleanup.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: pch_gbe: convert to hw_features
Michał Mirosław [Tue, 19 Apr 2011 01:56:12 +0000]
net: pch_gbe: convert to hw_features

This also fixes bug in xmit path, where TX checksum offload state was used
instead of skb->ip_summed to decide if the offload was needed.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: infiniband/ulp/ipoib: convert to hw_features
Michał Mirosław [Tue, 19 Apr 2011 00:43:20 +0000]
net: infiniband/ulp/ipoib: convert to hw_features

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: s390: convert to hw_features
Michał Mirosław [Tue, 19 Apr 2011 00:43:20 +0000]
net: s390: convert to hw_features

options.large_send was easy to get rid of. options.checksum_type has deeper
roots so is left for later cleanup.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: infiniband/hw/nes: convert to hw_features
Michał Mirosław [Tue, 19 Apr 2011 00:43:20 +0000]
net: infiniband/hw/nes: convert to hw_features

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoStaging: convert hv network driver to hw_features
Michał Mirosław [Tue, 19 Apr 2011 00:43:20 +0000]
Staging: convert hv network driver to hw_features

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: batman-adv: remove rx_csum ethtool_ops
Michał Mirosław [Tue, 19 Apr 2011 00:43:20 +0000]
net: batman-adv: remove rx_csum ethtool_ops

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: dsa: remove ethtool_ops->set_sg
Michał Mirosław [Tue, 19 Apr 2011 00:43:19 +0000]
net: dsa: remove ethtool_ops->set_sg

Remove set_sg from DSA slave ethtool_ops. Features inheritance looks
broken/not fully implemented anyway.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agosctp: Release all routes when processing acks ADD_IP or DEL_IP
Vlad Yasevich [Mon, 18 Apr 2011 19:15:22 +0000]
sctp: Release all routes when processing acks ADD_IP or DEL_IP

When processing an ACK for ADD_IP parameter, we only release
the routes on non-active transports.  This can cause a wrong
source address to be used.  We can release the routes and
cause new route lookups and source address selection so that
new addresses can be used as source.  Additionally, we don't need
to lookup routes for all transports at the same time.  We can let
the transmit code path update the cached route when the transport
actually sends something.

Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agosctp: Allow bindx_del to accept 0 port
Vlad Yasevich [Mon, 18 Apr 2011 19:14:47 +0000]
sctp: Allow bindx_del to accept 0 port

We allow 0 port when adding new addresses.  It only
makes sence to allow 0 port when removing addresses.
When removing the currently bound port will be used
when the port in the address is set to 0.

Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agosctp: teach CACC algorithm about removed transports
Vlad Yasevich [Mon, 18 Apr 2011 19:13:56 +0000]
sctp: teach CACC algorithm about removed transports

When we have have to remove a transport due to ASCONF, we move
the data to a new active path.  This can trigger CACC algorithm
to not mark that data as missing when SACKs arrive.  This is
because the transport passed to the CACC algorithm is the one
this data is sitting on, not the one it was sent on (that one
may be gone).  So, by sending the original transport (even if
it's NULL), we may start marking data as missing.

Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agosctp: use memdup_user to copy data from userspace
Shan Wei [Mon, 18 Apr 2011 19:13:18 +0000]
sctp: use memdup_user to copy data from userspace

Use common function to simply code.

Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agosctp: kill abandoned SCTP_CMD_TRANSMIT command
Shan Wei [Mon, 18 Apr 2011 19:12:40 +0000]
sctp: kill abandoned SCTP_CMD_TRANSMIT command

Remove SCTP_CMD_TRANSMIT command as it never be used.

Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agosctp: use common head of addr parameter to access member in addr-unrelated code
Shan Wei [Mon, 18 Apr 2011 19:11:47 +0000]
sctp: use common head of addr parameter to access member in addr-unrelated code

The 'p' member of struct sctp_paramhdr is common part for
IPv4 addr parameter and IPv6 addr parameter in union sctp_addr_param.

For addr-related code, use specified addr parameter.
Otherwise, use common header to access type/length member.

Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agosctp: fix the comment of sctp_sf_violation_paramlen()
Shan Wei [Mon, 18 Apr 2011 19:11:01 +0000]
sctp: fix the comment of sctp_sf_violation_paramlen()

Update the comment about sctp_sf_violation_paramlen() to be
more precise.

Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agosctp: delete unused macro definition of sctp_chunk_is_control
Shan Wei [Mon, 18 Apr 2011 19:19:29 +0000]
sctp: delete unused macro definition of sctp_chunk_is_control

The macro never be used.
And if needed, can use !sctp_chunk_is_data instead of.

Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agobe2net: add code to display default value of tx rate for VFs
Ajit Khaparde [Tue, 19 Apr 2011 12:11:55 +0000]
be2net: add code to display default value of tx rate for VFs

This change will allow the default value of tx rate to be displayed
when ip link show is called on a PF interface.

Signed-off-by: Ajit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agobe2net: pass domain id to be_cmd_link_status_query
Ajit Khaparde [Tue, 19 Apr 2011 12:11:46 +0000]
be2net: pass domain id to be_cmd_link_status_query

Signed-off-by: Ajit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agobe2net: fix be_mcc_compl_process to identify eth_get_stat command
Ajit Khaparde [Tue, 19 Apr 2011 12:11:02 +0000]
be2net: fix be_mcc_compl_process to identify eth_get_stat command

eth_get_statistics and vlan_config command have same opcode.
Use opcode subsystem id to differentiate one from other.

Signed-off-by: Ajit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agobe2net: Add code to display nic speeds other than 1Gbps/10Gbps
Ajit Khaparde [Tue, 19 Apr 2011 12:10:53 +0000]
be2net: Add code to display nic speeds other than 1Gbps/10Gbps

Signed-off-by: Ajit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agobe2net: allow register dump only for PFs
Ajit Khaparde [Tue, 19 Apr 2011 12:10:43 +0000]
be2net: allow register dump only for PFs

Signed-off-by: Ajit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet:bna: fix compile warning of ‘bfa_ioc_smem_pgoff’ defined but not used
Shan Wei [Tue, 19 Apr 2011 15:38:06 +0000]
net:bna: fix compile warning of ‘bfa_ioc_smem_pgoff’ defined but not used

Fix the below compile warning:

drivers/net/bna/bfa_ioc.c:1922: warning: ‘bfa_ioc_smem_pgoff’ defined but not used

Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: forcedeth: fix compile warning of not used nv_set_tso function
Shan Wei [Tue, 19 Apr 2011 15:31:20 +0000]
net: forcedeth: fix compile warning of not used nv_set_tso function

Fix the below compile warning:
drivers/net/forcedeth.c:4266: warning: ‘nv_set_tso’ defined but not used

commit 569e146 converts forcedeth driver to use hw_features.
So, implement function of .set_tso is abandoned.

Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoMerge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-next-2.6
David S. Miller [Tue, 19 Apr 2011 18:24:06 +0000]
Merge branch 'master' of git://git./linux/kernel/git/kaber/nf-next-2.6

8 years agoMerge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
David S. Miller [Tue, 19 Apr 2011 07:21:33 +0000]
Merge branch 'master' of /linux/kernel/git/davem/net-2.6

Conflicts:
drivers/net/bnx2x/bnx2x_ethtool.c

8 years agonet: qlge: convert to hw_features
Michał Mirosław [Mon, 18 Apr 2011 13:31:21 +0000]
net: qlge: convert to hw_features

Another simple conversion.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: vmxnet3: convert to hw_features
Michał Mirosław [Mon, 18 Apr 2011 13:31:21 +0000]
net: vmxnet3: convert to hw_features

This also removes private feature flags that were always set to true.

You may want to move vmxnet3_set_features() to vmxnet3_drv.c as a following
cleanup.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: vxge: convert to hw_features
Michał Mirosław [Mon, 18 Apr 2011 13:31:21 +0000]
net: vxge: convert to hw_features

Side effect: ->gro_enable is removed as napi_gro_receive() does the
fallback itself.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: chelsio: convert to hw_features
Michał Mirosław [Mon, 18 Apr 2011 13:31:20 +0000]
net: chelsio: convert to hw_features

Also remove flags that were not used or are now redundant to hw_features bits.
No device had UDP_CSUM_CAPABLE set.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: s2io: convert to hw_features
Michał Mirosław [Mon, 18 Apr 2011 13:31:20 +0000]
net: s2io: convert to hw_features

This removes advertising HW_CSUM as driver does not support it.

Note: driver advertises TSO6 but not IPV6_CSUM - bug maybe?

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: fix section mismatches
Michał Mirosław [Mon, 18 Apr 2011 13:31:20 +0000]
net: fix section mismatches

Fix build warnings like the following:

WARNING: drivers/net/built-in.o(.data+0x12434): Section mismatch in reference from the variable madgemc_driver to the variable .init.data:madgemc_adapter_ids

And add some consts to EISA device ID tables along the way.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agor8169: TSO fixes.
Francois Romieu [Tue, 19 Apr 2011 05:53:24 +0000]
r8169: TSO fixes.

- the MSS value is actually contained in a 11 bits wide (0x7ff) field.
  The extra bit in the former MSSMask did encompass the TSO command
  bit ("LargeSend") as well (0xfff). Oops.

- the Tx descriptor layout is not the same through the whole chipset
  family. The 8169 documentation, the 8168c documentation and Realtek's
  drivers (8.020.00, 1.019.00, 6.014.00) highlight two layouts:
  1. 8169, 8168 up to 8168b (included) and 8101
  2. {8102e, 8168c} and beyond

- notwithstanding the "first descriptor" and "last descriptor" bits, the
  same Tx descriptor content is enforced when a packet consists of several
  descriptors. The chipsets are documented to require it.

Credits go to David Dillow <dave@thedillows.org> for the original patch.

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Cc: Realtek <nic_swsd@realtek.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: myri10ge: convert to hw_features
Michał Mirosław [Fri, 15 Apr 2011 04:50:50 +0000]
net: myri10ge: convert to hw_features

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Acked-by: Jon Mason <jon.mason@myri.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: dm9000: Fix build
Mark Brown [Mon, 18 Apr 2011 01:04:37 +0000]
net: dm9000: Fix build

Commit c88fcb (net: dm9000: convert to hw_features) broke the build of
the dm9000 driver since it merged functions which use different names
for the board info structure used for I/O operations without updating
all the references to use the same name. Fix that.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agobonding, ipv4, ipv6, vlan: Handle NETDEV_BONDING_FAILOVER like NETDEV_NOTIFY_PEERS
Ben Hutchings [Fri, 15 Apr 2011 13:47:51 +0000]
bonding, ipv4, ipv6, vlan: Handle NETDEV_BONDING_FAILOVER like NETDEV_NOTIFY_PEERS

It is undesirable for the bonding driver to be poking into higher
level protocols, and notifiers provide a way to avoid that.  This does
mean removing the ability to configure reptitition of gratuitous ARPs
and unsolicited NAs.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agovlan: Propagate NETDEV_NOTIFY_PEERS notifier
Ben Hutchings [Fri, 15 Apr 2011 13:46:49 +0000]
vlan: Propagate NETDEV_NOTIFY_PEERS notifier

The NETDEV_NOTIFY_PEERS notifier indicates that a device moved to a

different physical link; this also applies to any VLAN devices on top
of it.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoipv6: Send unsolicited neighbour advertismements when notified
Ben Hutchings [Fri, 15 Apr 2011 13:46:02 +0000]
ipv6: Send unsolicited neighbour advertismements when notified

The NETDEV_NOTIFY_PEERS notifier is a request to send such
advertisements following migration to a different physical link,
e.g. virtual machine migration.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agobnx2x: cosmetics: Using ethtool_cmd_speed() API
David Decotigny [Thu, 14 Apr 2011 16:11:34 +0000]
bnx2x: cosmetics: Using ethtool_cmd_speed() API

This updates bnx2x to use the ethtool_cmd_speed() family of functions
(see b11f8d8c in 2.6.27-rc3 aka. "ethtool: Expand ethtool_cmd.speed to
32 bits") to get and set the link speed via ethtool. This allows to
avoid manually accessing ethtool_cmd's speed_hi field.

Signed-off-by: David Decotigny <decot@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoip6_pol_route panic: Do not allow VLAN on loopback
Krishna Kumar [Thu, 14 Apr 2011 06:07:04 +0000]
ip6_pol_route panic: Do not allow VLAN on loopback

Several tests in the ipv6 routing code check IFF_LOOPBACK, and
allowing stacking such as VLAN'ing on top of loopback results in a
netdevice which reports IFF_LOOPBACK but really isn't the loopback
device.

Instead of spamming the ipv6 routing code with even more special tests,
simply disallow VLAN over loopback.

The result of this patch is:

# modprobe 8021q
# vconfig add lo 43
ERROR: trying to add VLAN #43 to IF -:lo:-  error: Operation not supported

Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agodecnet: Don't leak entries when rebuilding zone.
David S. Miller [Mon, 18 Apr 2011 03:47:07 +0000]
decnet: Don't leak entries when rebuilding zone.

As noticed by Ben Hutchings, when we move entries from
one table to another we leak all except the first entry.

Put back the "next" variable removed by commit
9bf9055eb716f85372c41b3fbc51f90bc7653740 ("decnet: Fix set-but-unused
variable.") and use it properly.

Reported-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agovia-rhine: Assign random MAC address if necessary
Joe Perches [Sat, 16 Apr 2011 14:15:26 +0000]
via-rhine: Assign random MAC address if necessary

Roger Luethi has had several reports of Rhine NICs providing
an invalid MAC address.  If so, assign a random MAC address so
the hardware can still be used.

Tested as a standalone interface, as carrier for ppp, and as a
bonding slave.

Original-patch-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agovia_rhine: Use netdev_<level> and pr_<level>
Joe Perches [Sat, 16 Apr 2011 14:15:25 +0000]
via_rhine: Use netdev_<level> and pr_<level>

Use the more current logging styles.

Add #define DEBUG to make netdev_dbg always active.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agobridge: fix accidental creation of sysfs directory
Stephen Hemminger [Mon, 18 Apr 2011 00:52:51 +0000]
bridge: fix accidental creation of sysfs directory

Commit bb900b27a2f49b37bc38c08e656ea13048fee13b ("bridge: allow
creating bridge devices with netlink") introduced a bug in net-next
because of a typo in notifier. Every device would have the sysfs
bridge directory (and files).

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: cxgb4{,vf}: convert to hw_features
Michał Mirosław [Sat, 16 Apr 2011 13:05:08 +0000]
net: cxgb4{,vf}: convert to hw_features

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Acked-by: Dimitris Michailidis <dm@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agobnx2x: Fix port identification problem
Yaniv Rosner [Mon, 18 Apr 2011 00:50:01 +0000]
bnx2x: Fix port identification problem

This patch fixes port identification on optic devices when there's no link on the port.

Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agodrivers/net/usb/usbnet.c: Use FIELD_SIZEOF macro in usbnet_init() function.
Thiago Farina [Mon, 18 Apr 2011 00:49:21 +0000]
drivers/net/usb/usbnet.c: Use FIELD_SIZEOF macro in usbnet_init() function.

Signed-off-by: Thiago Farina <tfransosi@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: ibm_newemac: convert to hw_features
Michał Mirosław [Sun, 17 Apr 2011 00:15:47 +0000]
net: ibm_newemac: convert to hw_features

Side effect: allow toggling of TX offloads.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: greth: convert to hw_features
Michał Mirosław [Sun, 17 Apr 2011 00:15:47 +0000]
net: greth: convert to hw_features

Note: Driver modifies its struct net_device_ops. This will break if used for
multiple devices that are not all the same (if that HW config is possible).

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: niu: convert to hw_features
Michał Mirosław [Sun, 17 Apr 2011 00:15:47 +0000]
net: niu: convert to hw_features

Side effect: allow toggling of TX offloads.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: ehea: convert to hw_features
Michał Mirosław [Sun, 17 Apr 2011 00:15:47 +0000]
net: ehea: convert to hw_features

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: benet: convert to hw_features - fixup
Michał Mirosław [Sun, 17 Apr 2011 00:15:47 +0000]
net: benet: convert to hw_features - fixup

Remove be_set_flags() as it's already covered by hw_features.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Acked-by: Ajit Khaparde ajit.khaparde@emulex.com
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: typhoon: convert to hw_features
Michał Mirosław [Sun, 17 Apr 2011 00:15:47 +0000]
net: typhoon: convert to hw_features

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: mv643xx: convert to hw_features
Michał Mirosław [Sun, 17 Apr 2011 00:15:46 +0000]
net: mv643xx: convert to hw_features

Side effect: don't reenable RXCSUM on every ifdown/ifup.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: tehuti: convert to hw_features
Michał Mirosław [Sun, 17 Apr 2011 00:15:46 +0000]
net: tehuti: convert to hw_features

As a side effect, make TX offloads changeable.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agor8169: add Realtek as maintainer.
Francois Romieu [Mon, 18 Apr 2011 00:46:40 +0000]
r8169: add Realtek as maintainer.

Per Hayes's request.

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: cxgb3: convert to hw_features
Michał Mirosław [Sun, 17 Apr 2011 00:15:46 +0000]
net: cxgb3: convert to hw_features

This removes some of the remnants of LRO -> GRO conversion.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonet: macvlan: convert to hw_features
Michał Mirosław [Sun, 17 Apr 2011 00:15:46 +0000]
net: macvlan: convert to hw_features

Not much of a conversion anyway - macvlan has no way to change the offload
settings independently to its base device.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoMerge branch 'batman-adv/next' of git://git.open-mesh.org/ecsv/linux-merge
David S. Miller [Mon, 18 Apr 2011 00:37:29 +0000]
Merge branch 'batman-adv/next' of git://git.open-mesh.org/ecsv/linux-merge

8 years agobe2net: Fix unused-but-set variables.
David S. Miller [Mon, 18 Apr 2011 00:08:41 +0000]
be2net: Fix unused-but-set variables.

The variables 'tx_min' and 'tx_max' are set but not used in
be_set_coalesce().

Similarly for 'region' in be_do_flash().

Just kill them off.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoisdn: i4l: isdn_tty: Fix unused-but-set variables.
David S. Miller [Mon, 18 Apr 2011 00:07:57 +0000]
isdn: i4l: isdn_tty: Fix unused-but-set variables.

The variable 'fcr' is set but not used in isdn_tty_change_speed().

Just kill it off.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonetfilter: ip6table_mangle: Fix set-but-unused variables.
David S. Miller [Mon, 18 Apr 2011 00:06:15 +0000]
netfilter: ip6table_mangle: Fix set-but-unused variables.

The variable 'flowlabel' is set but unused in ip6t_mangle_out().

The intention here was to compare this key to the header value after
mangling, and trigger a route lookup on mismatch.

Make it so.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonetfilter: ip6_tables: Fix set-but-unused variables.
David S. Miller [Mon, 18 Apr 2011 00:04:48 +0000]
netfilter: ip6_tables: Fix set-but-unused variables.

The variable 'target' is set but unused in compat_copy_entry_from_user().

Just kill it off.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonetfilter: nf_conntrack_standalone: Fix set-but-unused variables.
David S. Miller [Mon, 18 Apr 2011 00:03:33 +0000]
netfilter: nf_conntrack_standalone: Fix set-but-unused variables.

The variable 'ret' is set but unused in ct_seq_show().

This was obviously meant to be used to propagate error codes
to the caller, so make it so.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonetfilter: nfnetlink_log: Fix set-but-unused variables.
David S. Miller [Mon, 18 Apr 2011 00:02:29 +0000]
netfilter: nfnetlink_log: Fix set-but-unused variables.

The variable 'tmp_uint' is set but unused in __build_packet_message().

Just kill it off.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agonetlabel: Fix set-but-unused variables.
David S. Miller [Mon, 18 Apr 2011 00:01:49 +0000]
netlabel: Fix set-but-unused variables.

The variable 'type_str' is set but unused in netlbl_cipsov4_add().

Just kill it off.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agol2tp: Fix set-but-unused variables.
David S. Miller [Mon, 18 Apr 2011 00:01:05 +0000]
l2tp: Fix set-but-unused variables.

The variable 'ret' is set but unused in l2tp_nl_register_ops().

This was obviously meant to maintain error codes which are
returned to the caller, make it so.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoirda: irproc: Fix set-but-unused variables.
David S. Miller [Sun, 17 Apr 2011 23:59:50 +0000]
irda: irproc: Fix set-but-unused variables.

The variable 'd' is set but unused in irda_proc_register().

Just kill it off.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoirda: irlap_event: Fix set-but-unused variables.
David S. Miller [Sun, 17 Apr 2011 23:59:09 +0000]
irda: irlap_event: Fix set-but-unused variables.

The variable 'ret' is set but unused in irlap_state_sclose().

Just kill it off.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agocaif: Fix set-but-unused variables.
David S. Miller [Sun, 17 Apr 2011 23:57:55 +0000]
caif: Fix set-but-unused variables.

The variable 'caifdef' is set but unused in modemcmd().

Similarly for 'net' in receive(), and 'res' in
caif_device_notify() and caif_exit_net().

Just kill them off.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agobnx2x: Fix set-but-unused variables.
David S. Miller [Sun, 17 Apr 2011 23:56:12 +0000]
bnx2x: Fix set-but-unused variables.

The variable 'rc' is set but unused in bnx2x_timer().

Similarly for 'hc_index_p' in bnx2x_init_sb(), and 'port' in
bnx2x_get_hwinfo().

Just kill them off.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agobna: Fix set-but-unused variables.
David S. Miller [Sun, 17 Apr 2011 23:51:36 +0000]
bna: Fix set-but-unused variables.

The variable 'pgoff' is set but unused in bfa_nw_ioc_fwver_get()
and bfa_ioc_download_fw().

Similarly for 'cmd_h' in bna_mbox_flush_q and the entirety of
bna_rit_mod_uninit() is unused since variables are purely set but no
action is made using them.

Same for 'bna' in bna_rit_create() and 'ret' in bna_rx_create().

Just kill them off.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoisdn: mISDN: socket: Fix set-but-unused variables.
David S. Miller [Sun, 17 Apr 2011 23:48:53 +0000]
isdn: mISDN: socket: Fix set-but-unused variables.

The variable 'len' is set but unused in data_sock_getsockopt().

The code should use 'len' to validate that the user's socket option is
indeed the right size.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoisdn: i4l: isdn_net: Fix set-but-unused variables.
David S. Miller [Sun, 17 Apr 2011 23:46:50 +0000]
isdn: i4l: isdn_net: Fix set-but-unused variables.

The variable 'unused' is set but unused in
isdn_net_ciscohdlck_slarp_in().  Just kill it off.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoisdn: i4l: isdn_common: Fix set-but-unused variables.
David S. Miller [Sun, 17 Apr 2011 23:45:51 +0000]
isdn: i4l: isdn_common: Fix set-but-unused variables.

The variable 'ch' is set but unused in isdn_capi_rec_hl_msg().  Just
kill it off.

Similarly for 'chidx' in isdn_ioctl() and 'di' in
isdn_capi_rec_hl_msg().

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoisdn: teles_cs: Fix set-but-unused variables.
David S. Miller [Sun, 17 Apr 2011 23:44:12 +0000]
isdn: teles_cs: Fix set-but-unused variables.

The variable 'dev' is set but unused in teles_cs_config().  Just
kill it off.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoisdn: l3ni1: Fix set-but-unused variables.
David S. Miller [Sun, 17 Apr 2011 23:43:20 +0000]
isdn: l3ni1: Fix set-but-unused variables.

The variable 'cause' is set but unused in ni1up().  Just
kill it off.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoisdn: l3dss1: Fix set-but-unused variables.
David S. Miller [Sun, 17 Apr 2011 23:42:15 +0000]
isdn: l3dss1: Fix set-but-unused variables.

The variable 'cause' is set but unused in dss1up().  Just
kill it off.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoisdn: jade: Fix set-but-unused variables.
David S. Miller [Sun, 17 Apr 2011 23:41:29 +0000]
isdn: jade: Fix set-but-unused variables.

The variable 'i' is set but unused in JadeVersion().  Just
kill it off.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoisdn: ipacx: Fix set-but-unused variables.
David S. Miller [Sun, 17 Apr 2011 23:40:30 +0000]
isdn: ipacx: Fix set-but-unused variables.

The variable 'cda2_cr' is set but unused in ctrl_complete().  Just
kill it off.

Keep the cs->readisac() call just in case the register read has side
effects.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoisdn: hfc_usb: Fix set-but-unused variables.
David S. Miller [Sun, 17 Apr 2011 23:39:18 +0000]
isdn: hfc_usb: Fix set-but-unused variables.

The variable 'buf' is set but unused in
ctrl_complete().  Just kill it off.

Similarly for 'err' in hfc_usb_init().

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoisdn: elsa_ser: Fix set-but-unused variables.
David S. Miller [Sun, 17 Apr 2011 23:38:33 +0000]
isdn: elsa_ser: Fix set-but-unused variables.

The variable 'bits' is set but unused in
change_speed().  Just kill it off.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoisdn: elsa_cs: Fix set-but-unused variables.
David S. Miller [Sun, 17 Apr 2011 23:37:11 +0000]
isdn: elsa_cs: Fix set-but-unused variables.

The variable 'dev' is set but unused in
elsa_cs_config().  Just kill it off.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoisdn: arcofi: Fix set-but-unused variables.
David S. Miller [Sun, 17 Apr 2011 23:36:28 +0000]
isdn: arcofi: Fix set-but-unused variables.

The variable 'val' is set but unused in
send_arcofi().  Just kill it off.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoisdn: hfcsusb: Fix set-but-unused variables.
David S. Miller [Sun, 17 Apr 2011 23:35:27 +0000]
isdn: hfcsusb: Fix set-but-unused variables.

The variable 'buf' is set but unused in
ctrl_complete().  Just kill it off.

Similarly for the variable 'err' in setup_hfcsusb().

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoisdn: hfcpci: Fix set-but-unused variables.
David S. Miller [Sun, 17 Apr 2011 23:34:50 +0000]
isdn: hfcpci: Fix set-but-unused variables.

The variable 'total' is set but unused in
hfcpci_empty_bfifo().  Just kill it off.

Similarly for the variable 'val' in ph_state_nt().

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoisdn: eicon: Fix set-but-unused variables.
David S. Miller [Sun, 17 Apr 2011 23:23:22 +0000]
isdn: eicon: Fix set-but-unused variables.

The variable 'best_id' is set but unused in
diva_mnt_add_xdi_adapter().  Just kill it off.

Similarly for the variable 'CIP' in connect_req(), 'Number' in
sig_ind(), 'Info' in dtmf_confirmation() mixer_command()
fax_connect_ack_command() fax_edata_ack_command()
rtp_connect_b3_res_command() and rtp_connect_b3_res_command(), and 'a'
in mixer_indication_coefs_set(),

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agoisdn: gigaset: Fix set-but-unused variable.
David S. Miller [Sun, 17 Apr 2011 23:22:33 +0000]
isdn: gigaset: Fix set-but-unused variable.

The variable 'offset' is set but unused in
write_iso_tasklet().  Just kill it off.

Signed-off-by: David S. Miller <davem@davemloft.net>

8 years agobatman-adv: Set the txqueuelen to zero when creating soft interface
Andrew Lunn [Sun, 17 Apr 2011 18:39:07 +0000]
batman-adv: Set the txqueuelen to zero when creating soft interface

Like other virtual interfaces, e.g. br0, we don't need a transmit
queue. Packets should only be queued on real interfaces which are
underneath. In practice this patch makes little difference since the
virtual interfaces can accept packets as fast as they come, but the
patch will avoid bufferbloat questions to the mailling lists in the
future.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Tested-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Sven Eckelmann <sven@narfation.org>

8 years agobatman-adv: protect softif_neigh by rcu
Simon Wunderlich [Sun, 17 Apr 2011 18:34:27 +0000]
batman-adv: protect softif_neigh by rcu

Add get/set wrapper functions for softif_neigh and
use rcu functions to manipulate the pointers.

Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Sven Eckelmann <sven@narfation.org>

8 years agobatman-adv: concentrate all curr_gw related rcu operations in select/deselect functions
Marek Lindner [Wed, 23 Mar 2011 10:24:34 +0000]
batman-adv: concentrate all curr_gw related rcu operations in select/deselect functions

Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Sven Eckelmann <sven@narfation.org>

8 years agobatman-adv: Protect global TQ window with a spinlock
Linus Lüssing [Mon, 14 Mar 2011 22:43:40 +0000]
batman-adv: Protect global TQ window with a spinlock

Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Sven Eckelmann <sven@narfation.org>

8 years agobatman-adv: Make orig_node->router an rcu protected pointer
Linus Lüssing [Mon, 14 Mar 2011 22:43:37 +0000]
batman-adv: Make orig_node->router an rcu protected pointer

The rcu protected macros rcu_dereference() and rcu_assign_pointer()
for the orig_node->router need to be used, as well as spin/rcu locking.
Otherwise we might end up using a router pointer pointing to already
freed memory.

Therefore this commit introduces the safe getter method
orig_node_get_router().

Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Sven Eckelmann <sven@narfation.org>