7 years agohwmon: (lm87) Reorganize the code
Jean Delvare [Thu, 26 Jan 2012 17:37:50 +0000]
hwmon: (lm87) Reorganize the code

Reorder functions and driver declaration to no longer need to
forward-declare functions. Also rename new_client to just client
everywhere for readability.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>

7 years agohwmon: (applesmc) Silence uninitialized warnings
Henrik Rydberg [Thu, 26 Jan 2012 11:08:41 +0000]
hwmon: (applesmc) Silence uninitialized warnings

Some error paths do not set a result, leading to the (false)
assumption that the value may be used uninitialized. Set results for
those paths as well.

Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>

7 years agohwmon: (lm70) Fix: do not use assignment in if condition
Guenter Roeck [Fri, 20 Jan 2012 05:05:07 +0000]
hwmon: (lm70) Fix: do not use assignment in if condition

Fix checkpatch issue:
ERROR: do not use assignment in if condition

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (lm70) Register hwmon device after creating attribute files, and remove it...
Guenter Roeck [Fri, 20 Jan 2012 04:58:13 +0000]
hwmon: (lm70) Register hwmon device after creating attribute files, and remove it first

Register hwmon device as last operation in the probe function to ensure that all
attribute files exist when accessed from user applications. Otherwise, there
is a short time frame where the device is registered as hwmon device but
sysfs attributes do not yet exist. This could result in applications erroneously
not detecting attributes.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (w83l786ng) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:28 +0000]
hwmon: (w83l786ng) Fix multi-line comments

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (w83l785ts) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:28 +0000]
hwmon: (w83l785ts) Fix multi-line comments

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (w83781d) Fix: do not use assignment in if condition
Guenter Roeck [Tue, 17 Jan 2012 04:45:16 +0000]
hwmon: (w83781d) Fix: do not use assignment in if condition

Fix checkpatch issue:
ERROR: do not use assignment in if condition

Replace repeated calls to device_create_file() with calls to sysfs_create_group.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (w83781d) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:27 +0000]
hwmon: (w83781d) Fix multi-line comments

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (smsc47b397) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:25 +0000]
hwmon: (smsc47b397) Fix multi-line comments

Cc: Mark M Hoffman <mhoffman@lightlink.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (pc87427) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:23 +0000]
hwmon: (pc87427) Fix multi-line comments

Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Jean Delvare <khali@linux-fr.org>

7 years agohwmon: (max1668) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:22 +0000]
hwmon: (max1668) Fix multi-line comments

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (lm80) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:20 +0000]
hwmon: (lm80) Fix multi-line comments

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Jean Delvare <khali@linux-fr.org>

7 years agohwmon: (emc2103) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:17 +0000]
hwmon: (emc2103) Fix multi-line comments

Cc: Steve Glendinning <steve.glendinning@smsc.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (adm1031) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:14 +0000]
hwmon: (adm1031) Fix multi-line comments

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (adm1029) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:14 +0000]
hwmon: (adm1029) Fix multi-line comments

Cc: Corentin Labbe <corentin.labbe@geomatys.fr>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (w83627hf) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 19:07:26 +0000]
hwmon: (w83627hf) Fix checkpatch issues

Fixed:
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead
ERROR: do not use assignment in if condition

Modify multi-line comments to follow Documentation/CodingStyle.

Other checkpatch issues not fixed to reduce number of conflicts with pending
rewrite as mfd driver.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (w83l786ng) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 19:03:08 +0000]
hwmon: (w83l786ng) Fix checkpatch issues

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: space required after that ',' (ctx:VxV)
WARNING: braces {} are not necessary for single statement blocks
WARNING: please, no space before tabs
WARNING: please, no spaces at the start of a line
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead
WARNING: space prohibited between function name and open parenthesis '('

Not fixed (false positive):
ERROR: Macros with complex values should be enclosed in parenthesis

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (w83793) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 18:48:48 +0000]
hwmon: (w83793) Fix checkpatch issues

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: space required after that ',' (ctx:VxV)
WARNING: braces {} are not necessary for any arm of this statement
WARNING: braces {} are not necessary for single statement blocks
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Modify multi-line comments to follow Documentation/CodingStyle.

Also replaced "<constant> == <variable>" with "<variable> == <constant>".
Translation was done with the following coccinelle script to limit risk.

@@
identifier i;
constant C;
@@

<...
- C == i
+ i == C
...>

Not fixed (false positive):
ERROR: Macros with complex values should be enclosed in parenthesis

Cc: Rudolf Marek <r.marek@assembler.cz>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (w83792d) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 18:13:12 +0000]
hwmon: (w83792d) Fix checkpatch issues

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: space prohibited after that open parenthesis '('
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that ',' (ctx:WxV)
ERROR: spaces required around that ':' (ctx:VxE)
ERROR: spaces required around that '<=' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: spaces required around that '||' (ctx:VxV)
ERROR: spaces required around that ':' (ctx:VxV)
ERROR: spaces required around that '?' (ctx:VxV)
WARNING: braces {} are not necessary for any arm of this statement
WARNING: braces {} are not necessary for single statement blocks
WARNING: line over 80 characters
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead
WARNING: space prohibited between function name and open parenthesis '('

Modify multi-line comments to follow Documentation/CodingStyle.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (vt1211) Fix: do not use assignment in if condition
Guenter Roeck [Fri, 20 Jan 2012 05:49:20 +0000]
hwmon: (vt1211) Fix: do not use assignment in if condition

Fix checkpatch issue:
ERROR: do not use assignment in if condition

Replace repeated calls to device_create_file() with calls to sysfs_create_group.

Cc: Juerg Haefliger <juergh@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (vt1211) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 14:52:33 +0000]
hwmon: (vt1211) Fix checkpatch issues

Fixed:
ERROR: do not use assignment in if condition
ERROR: switch and case should be at the same indent
ERROR: trailing statements should be on next line
WARNING: braces {} are not necessary for single statement blocks
WARNING: simple_strtol is obsolete, use kstrtol instead

Modify multi-line comments to follow Documentation/CodingStyle.

Not fixed (false positive):
ERROR: Macros with complex values should be enclosed in parenthesis

Not all fixed (code complexity):
ERROR: do not use assignment in if condition

Cc: Juerg Haefliger <juergh@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (via686a) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 14:38:23 +0000]
hwmon: (via686a) Fix checkpatch issues

Fixed:
ERROR: do not use assignment in if condition
ERROR: open brace '{' following function declarations go on the next line
ERROR: space prohibited before that close parenthesis ')'
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: spaces required around that ':' (ctx:VxV)
ERROR: spaces required around that '?' (ctx:VxV)
ERROR: that open brace { should be on the previous line
WARNING: line over 80 characters
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Modify multi-line comments to follow Documentation/CodingStyle.

Not fixed (false positive):
ERROR: Macros with multiple statements should be enclosed in a do - while loop

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (pc87360) Fix: do not use assignment in if condition
Guenter Roeck [Fri, 20 Jan 2012 04:50:57 +0000]
hwmon: (pc87360) Fix: do not use assignment in if condition

Fix checkpatch issue:
ERROR: do not use assignment in if condition

Replace repeated calls to device_create_file() with calls to sysfs_create_group.

Cc: Jean Delvare <khali@linux-fr.org>
Cc: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (pc87360) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 05:49:53 +0000]
hwmon: (pc87360) Fix checkpatch issues

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: "foo * bar" should be "foo *bar"
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that ':' (ctx:VxE)
ERROR: spaces required around that '==' (ctx:VxV)
WARNING: braces {} are not necessary for single statement blocks
WARNING: line over 80 characters
WARNING: please, no space before tabs
WARNING: please, no spaces at the start of a line
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Not or not all fixed (code complexity):
ERROR: Macros with complex values should be enclosed in parenthesis
ERROR: do not use assignment in if condition

Cc: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (max1619): Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 05:29:27 +0000]
hwmon: (max1619): Fix checkpatch issues

Fixed:
ERROR: do not use assignment in if condition
ERROR: trailing whitespace
WARNING: line over 80 characters
WARNING: please, no spaces at the start of a line
WARNING: simple_strtol is obsolete, use kstrtol instead

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (lm85) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 04:47:36 +0000]
hwmon: (lm85) Fix checkpatch issues

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Modify multi-line comments to follow Documentation/CodingStyle.

Also: s/#define^I/#define /

Not fixed (false positive):
ERROR: Macros with multiple statements should be enclosed in a do - while loop

Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (lm78) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 04:39:24 +0000]
hwmon: (lm78) Fix checkpatch issues

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: space prohibited before that close parenthesis ')'
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: trailing statements should be on next line
ERROR: trailing whitespace
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Modify multi-line comments to follow Documentation/CodingStyle.

Not fixed (false positive):
ERROR: Macros with multiple statements should be enclosed in a do - while loop

Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Jean Delvare <khali@linux-fr.org>

7 years agohwmon: (lm77) Fix checkpatch issues
Guenter Roeck [Sat, 14 Jan 2012 21:42:20 +0000]
hwmon: (lm77) Fix checkpatch issues

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: trailing whitespace
WARNING: line over 80 characters
WARNING: please, no space before tabs
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Modify multi-line comments to follow Documentation/CodingStyle.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (gl520sm) Fix: do not use assignment in if condition
Guenter Roeck [Tue, 17 Jan 2012 00:56:23 +0000]
hwmon: (gl520sm) Fix: do not use assignment in if condition

Fix checkpatch issue:
ERROR: do not use assignment in if condition

Replace repeated calls to device_create_file() with calls to sysfs_create_group.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (gl520sm) Fix checkpatch issues
Guenter Roeck [Sat, 14 Jan 2012 21:34:52 +0000]
hwmon: (gl520sm) Fix checkpatch issues

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '<=' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: spaces required around that ':' (ctx:VxV)
ERROR: spaces required around that '?' (ctx:VxV)
ERROR: trailing statements should be on next line
WARNING: line over 80 characters
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Modify multi-line comments to follow Documentation/CodingStyle.

Not always fixed (complexity):
ERROR: do not use assignment in if condition

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (gl518sm) Fix checkpatch issues
Guenter Roeck [Sat, 14 Jan 2012 21:32:55 +0000]
hwmon: (gl518sm) Fix checkpatch issues

Fixed:
ERROR: do not use assignment in if condition
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '?' (ctx:VxE)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: spaces required around that ':' (ctx:VxV)
ERROR: spaces required around that '?' (ctx:VxV)
ERROR: trailing statements should be on next line
WARNING: line over 80 characters
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Modify multi-line comments to follow Documentation/CodingStyle.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (dme1737) Fix checkpatch issues
Guenter Roeck [Sat, 14 Jan 2012 21:25:01 +0000]
hwmon: (dme1737) Fix checkpatch issues

Fixed:
WARNING: braces {} are not necessary for any arm of this statement
WARNING: braces {} are not necessary for single statement blocks
WARNING: simple_strtol is obsolete, use kstrtol instead

Modify multi-line comments to follow Documentation/CodingStyle.

Also: s/#define^I/#define /

Not fixed (false positive):
ERROR: Macros with multiple statements should be enclosed in a do - while loop

Cc: Juerg Haefliger <juergh@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (asb100): Fix checkpatch issues
Guenter Roeck [Sat, 14 Jan 2012 21:20:00 +0000]
hwmon: (asb100): Fix checkpatch issues

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: space prohibited after that open parenthesis '('
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
WARNING: please, no spaces at the start of a line
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Modify multi-line comments to follow Documentation/CodingStyle.

Not fixed (false positive):
ERROR: Macros with multiple statements should be enclosed in a do - while loop

Cc: Mark M. Hoffman <mhoffman@lightlink.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (adm9240) Fix checkpatch issues
Guenter Roeck [Sat, 14 Jan 2012 21:12:38 +0000]
hwmon: (adm9240) Fix checkpatch issues

Fixed:
ERROR: do not use assignment in if condition
ERROR: that open brace { should be on the previous line
WARNING: please, no space before tabs
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Modify multi-line comments to follow Documentation/CodingStyle.

Not fixed (false positive):
ERROR: Macros with multiple statements should be enclosed in a do - while loop

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (adm1026) Fix checkpatch issues
Guenter Roeck [Sat, 14 Jan 2012 20:51:15 +0000]
hwmon: (adm1026) Fix checkpatch issues

Fixed:
ERROR: do not use assignment in if condition
ERROR: space prohibited after that '~' (ctx:WxW)
ERROR: space required after that ';' (ctx:VxO)
ERROR: space required after that ';' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: spaces required around that ':' (ctx:VxV)
WARNING: braces {} are not necessary for any arm of this statement
WARNING: braces {} are not necessary for single statement blocks
WARNING: line over 80 characters
WARNING: simple_strtol is obsolete, use kstrtol instead

Modify multi-line comments to follow Documentation/CodingStyle.

Not fixed:
ERROR: Macros with multiple statements should be enclosed in a do - while loop

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (adm1021) Fix checkpatch issues
Guenter Roeck [Sat, 14 Jan 2012 20:45:47 +0000]
hwmon: (adm1021) Fix checkpatch issues

Fixed:
ERROR: do not use assignment in if condition
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: space prohibited between function name and open parenthesis '('

Modify multi-line comments to follow Documentation/CodingStyle.

Cc: Michael Abbott <michael.abbott@diamond.ac.uk>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (abituguru) Fix checkpatch issues
Guenter Roeck [Sat, 14 Jan 2012 20:30:52 +0000]
hwmon: (abituguru) Fix checkpatch issues

Fixed:
ERROR: do not use assignment in if condition
ERROR: else should follow close brace '}'
ERROR: switch and case should be at the same indent
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Modify multi-line comments to follow Documentation/CodingStyle.

Not fixed:
WARNING: msleep < 20ms can sleep for up to 20ms

Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (w83627ehf) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:27 +0000]
hwmon: (w83627ehf) Fix multi-line comments

Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (max1111) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:22 +0000]
hwmon: (max1111) Fix multi-line comments

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (ltc4151) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:21 +0000]
hwmon: (ltc4151) Fix multi-line comments

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Cc: Per Dalen <per.dalen@appeartv.com>

7 years agohwmon: (g760a) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:18 +0000]
hwmon: (g760a) Fix multi-line comments

Cc: Herbert Valerio Riedel <hvr@gnu.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (f71882fg) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:17 +0000]
hwmon: (f71882fg) Fix multi-line comments

Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (emc1403) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:17 +0000]
hwmon: (emc1403) Fix multi-line comments

Cc: Kalhan Trisal <kalhan.trisal@intel.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (amc6821) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:15 +0000]
hwmon: (amc6821) Fix multi-line comments

Cc: T. Mertelj <tomaz.mertelj@guest.arnes.si>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (ads7871) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:15 +0000]
hwmon: (ads7871) Fix multi-line comments

Cc: Paul Thomas <pthomas8589@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (ads7828) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:14 +0000]
hwmon: (ads7828) Fix multi-line comments

Cc: Steve Hardy <shardy@redhat.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (abituguru3) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:13 +0000]
hwmon: (abituguru3) Fix multi-line comments

Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Alistair John Strachan <alistair@devzero.co.uk>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (w83791d) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 17:29:36 +0000]
hwmon: (w83791d) Fix checkpatch issues

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: space prohibited after that open parenthesis '('
ERROR: space required after that ',' (ctx:VxV)
WARNING: braces {} are not necessary for single statement blocks
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Modify multi-line comments to follow Documentation/CodingStyle.

Not fixed (false positive):
ERROR: Macros with complex values should be enclosed in parenthesis

Cc: Charles Spirakis <bezaur@gmail.com>
Cc: Marc Hulsman <m.hulsman@tudelft.nl>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (ultra45_env) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 06:42:41 +0000]
hwmon: (ultra45_env) Fix checkpatch issues

Fixed:
WARNING: line over 80 characters
WARNING: simple_strtol is obsolete, use kstrtol instead

Modify multi-line comments to follow Documentation/CodingStyle.

Not fixed (false positive):
ERROR: Macros with multiple statements should be enclosed in a do - while loop

Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (thmc50) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 06:33:01 +0000]
hwmon: (thmc50) Fix checkpatch issues

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Modify multi-line comments to follow Documentation/CodingStyle.

Not fixed (false positive):
ERROR: Macros with multiple statements should be enclosed in a do - while loop

Cc: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (smsc47m1) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 06:27:00 +0000]
hwmon: (smsc47m1) Fix checkpatch issues

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '<=' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: spaces required around that '>=' (ctx:VxV)
ERROR: trailing statements should be on next line
ERROR: trailing whitespace
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: static const char * array should probably be static const char * const

Modify multi-line comments to follow Documentation/CodingStyle.

Also: s/#define^I/#define /

Not fixed (false positive):
ERROR: Macros with multiple statements should be enclosed in a do - while loop

Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (smsc47m1) Fix: do not use assignment in if condition
Guenter Roeck [Tue, 17 Jan 2012 01:15:02 +0000]
hwmon: (smsc47m1) Fix: do not use assignment in if condition

Fix checkpatch issue:
ERROR: do not use assignment in if condition

Replace repeated calls to device_create_file() with calls to sysfs_create_group.

Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (smsc47m192) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 06:31:08 +0000]
hwmon: (smsc47m192) Fix checkpatch issues

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: spaces required around that '>' (ctx:VxV)
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
WARNING: please, no space before tabs
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Modify multi-line comments to follow Documentation/CodingStyle.

Not fixed (false positive):
ERROR: Macros with multiple statements should be enclosed in a do - while loop

Cc: Hartmut Rick <linux@rick.claranet.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (sis5595) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 06:21:41 +0000]
hwmon: (sis5595) Fix checkpatch issues

Fixed:
ERROR: do not use assignment in if condition
ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: trailing statements should be on next line
ERROR: trailing whitespace
ERROR: Macros with multiple statements should be enclosed in a do - while loop
WARNING: line over 80 characters
WARNING: please, no space before tabs
WARNING: please, no spaces at the start of a line
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Modify multi-line comments to follow Documentation/CodingStyle.

Cc: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (pcf8591) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 05:57:29 +0000]
hwmon: (pcf8591) Fix checkpatch issues

Fixed:
ERROR: do not use assignment in if condition
ERROR: spaces required around that ':' (ctx:VxV)
ERROR: spaces required around that '?' (ctx:VxV)
WARNING: line over 80 characters
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Modify multi-line comments to follow Documentation/CodingStyle.

Cc: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (lm93) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 05:25:54 +0000]
hwmon: (lm93) Fix checkpatch issues

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: else should follow close brace '}'
ERROR: space prohibited after that open parenthesis '('
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '<=' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: spaces required around that ':' (ctx:VxW)
ERROR: trailing statements should be on next line
WARNING: braces {} are not necessary for any arm of this statement
WARNING: do not add new typedefs
WARNING: please, no space before tabs
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Modify multi-line comments to follow Documentation/CodingStyle.

Not fixed (unknown impact):
WARNING: msleep < 20ms can sleep for up to 20ms

Cc: Mark M. Hoffman <mhoffman@lightlink.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (lm92) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 05:04:18 +0000]
hwmon: (lm92) Fix checkpatch issues

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: spaces required around that '*=' (ctx:VxV)
ERROR: trailing whitespace
WARNING: line over 80 characters
WARNING: please, no space before tabs
WARNING: please, no spaces at the start of a line
WARNING: simple_strtol is obsolete, use kstrtol instead

Modify multi-line comments to follow Documentation/CodingStyle.

Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (lm87) Fix: do not use assignment in if condition
Guenter Roeck [Mon, 16 Jan 2012 23:11:57 +0000]
hwmon: (lm87) Fix: do not use assignment in if condition

Fix checkpatch issue:
ERROR: do not use assignment in if condition

Replace repeated calls to device_create_file() with calls to sysfs_create_group.

Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Jean Delvare <khali@linux-fr.org>

7 years agohwmon: (lm87) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 04:58:08 +0000]
hwmon: (lm87) Fix checkpatch issues

Fixed:
ERROR: do not use assignment in if condition
ERROR: space required after that close brace '}'
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: trailing statements should be on next line
WARNING: line over 80 characters
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Modify multi-line comments to follow Documentation/CodingStyle.

Not fixed everywhere (code complexity):
ERROR: do not use assignment in if condition

As a side effect of the changes made, attribute set functions now return an
error if an attempt is made to write non-numeric values. Previously, such
writes were interpreted as writing 0.

Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Jean Delvare <khali@linux-fr.org>

7 years agohwmon: (fschmd) Fix checkpatch issues
Guenter Roeck [Sat, 14 Jan 2012 21:30:47 +0000]
hwmon: (fschmd) Fix checkpatch issues

Fixed:
ERROR: that open brace { should be on the previous line
ERROR: trailing statements should be on next line
WARNING: line over 80 characters
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Modify multi-line comments to follow Documentation/CodingStyle.

Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (atxp1) Fix checkpatch issues
Guenter Roeck [Sat, 14 Jan 2012 21:21:59 +0000]
hwmon: (atxp1) Fix checkpatch issues

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: else should follow close brace '}'
ERROR: "foo * bar" should be "foo *bar"
WARNING: braces {} are not necessary for single statement blocks
WARNING: line over 80 characters
WARNING: please, no space before tabs
WARNING: please, no spaces at the start of a line
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Modify multi-line comments to follow Documentation/CodingStyle.

Cc: Sebastian Witt <se.witt@gmx.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (adt7462) Fix checkpatch issues
Guenter Roeck [Sat, 14 Jan 2012 21:16:53 +0000]
hwmon: (adt7462) Fix checkpatch issues

Fixed:
ERROR: that open brace { should be on the previous line
WARNING: please, no space before tabs

Cc: Darrick J. Wong <djwong@us.ibm.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (ltc4215) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:21 +0000]
hwmon: (ltc4215) Fix multi-line comments

Cc: Ira W. Snyder <iws@ovro.caltech.edu>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Ira W. Snyder <iws@ovro.caltech.edu>

7 years agohwmon: (ltc4245) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:22 +0000]
hwmon: (ltc4245) Fix multi-line comments

Cc: Ira W. Snyder <iws@ovro.caltech.edu>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Ira W. Snyder <iws@ovro.caltech.edu>

7 years agohwmon: (wm8350-hwmon) Constify fixed string array
Guenter Roeck [Fri, 20 Jan 2012 17:43:54 +0000]
hwmon: (wm8350-hwmon) Constify fixed string array

Constify fixed string array and make checkpatch happy.

Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

7 years agohwmon: (applesmc) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:15 +0000]
hwmon: (applesmc) Fix multi-line comments

Cc: Henrik Rydberg <rydberg@euromail.se>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Henrik Rydberg <rydberg@euromail.se>

7 years agohwmon: (asus_atk0110) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:16 +0000]
hwmon: (asus_atk0110) Fix multi-line comments

Cc: Luca Tettamanti <kronos.it@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Luca Tettamanti <kronos.it@gmail.com>

7 years agohwmon: (it87) Constify fixed string arrays
Guenter Roeck [Fri, 20 Jan 2012 17:29:44 +0000]
hwmon: (it87) Constify fixed string arrays

Make checkpatch happy by constifying fixed string arrays.

Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Jean Delvare <khali@linux-fr.org>

7 years agohwmon: (ad7414) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:13 +0000]
hwmon: (ad7414) Fix multi-line comments

Cc: Stefan Roese <sr@denx.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Stefan Roese <sr@denx.de>

7 years agohwmon: (jc42) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:19 +0000]
hwmon: (jc42) Fix multi-line comments

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (coretemp) Fix checkpatch error
Guenter Roeck [Fri, 20 Jan 2012 17:31:17 +0000]
hwmon: (coretemp) Fix checkpatch error

Fix:
ERROR: Macros with complex values should be enclosed in parenthesis

Cc: Fenghua Yu <fenghua.yu@intel.com>
Acked-By: Durgadoss R <durgadoss.r@intel.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (pc87360) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:22 +0000]
hwmon: (pc87360) Fix multi-line comments

Cc: Jim Cromie <jim.cromie@gmail.com>
Acked-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (wm831x-hwmon) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:28 +0000]
hwmon: (wm831x-hwmon) Fix multi-line comments

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (smm665) Fix checkpatch error
Guenter Roeck [Fri, 20 Jan 2012 17:34:50 +0000]
hwmon: (smm665) Fix checkpatch error

Fix:
ERROR: Macros with complex values should be enclosed in parenthesis

Also updated multi-line comments to follow Documentation/CodingStyle.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (asc7621) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:16 +0000]
hwmon: (asc7621) Fix multi-line comments

Cc: George Joseph <george.joseph@fairview5.com>
Acked-by: George Joseph <george.joseph@fairview5.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (it87) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:18 +0000]
hwmon: (it87) Fix multi-line comments

Fix multi-line comments, and clean up some of the affected comments.

Cc: Jean Delvare <khali@linux-fr.org>
Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (hwmon-vid) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:18 +0000]
hwmon: (hwmon-vid) Fix multi-line comments

Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (hwmon) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:18 +0000]
hwmon: (hwmon) Fix multi-line comments

Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (ds1621) Fix checkpatch issues
Guenter Roeck [Sat, 14 Jan 2012 21:26:08 +0000]
hwmon: (ds1621) Fix checkpatch issues

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: trailing whitespace
WARNING: labels should not be indented
WARNING: please, no spaces at the start of a line
WARNING: simple_strtol is obsolete, use kstrtol instead

Also modified multi-line comments to follow Documentation/CodingStyle.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Jean Delvare <khali@linux-fr.org>

7 years agohwmon: convert drivers/hwmon/* to use module_spi_driver()
Axel Lin [Fri, 20 Jan 2012 07:53:47 +0000]
hwmon: convert drivers/hwmon/* to use module_spi_driver()

This patch converts the drivers in drivers/hwmon/* to use the
module_spi_driver() macro which makes the code smaller and a bit simpler.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Cc: Sonic Zhang <sonic.zhang@analog.com>
Cc: Marc Pignat <marc.pignat@hevs.ch>
Cc: Paul Thomas <pthomas8589@gmail.com>
Cc: Eric Miao <eric.y.miao@gmail.com>
Acked-by: Sonic Zhang <sonic.zhang@analog.com>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>

7 years agohwmon: convert drivers/hwmon/* to use module_i2c_driver()
Axel Lin [Fri, 20 Jan 2012 07:38:18 +0000]
hwmon: convert drivers/hwmon/* to use module_i2c_driver()

This patch converts the drivers in drivers/hwmon/* to use the
module_i2c_driver() macro which makes the code smaller and a bit simpler.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Cc: Corentin Labbe <corentin.labbe@geomatys.fr>
Cc: Dirk Eibach <eibach@gdsys.de>
Cc: "Mark M. Hoffman" <mhoffman@lightlink.com>
Cc: Steve Glendinning <steve.glendinning@smsc.com>
Cc: Riku Voipio <riku.voipio@iki.fi>
Cc: Guillaume Ligneul <guillaume.ligneul@gmail.com>
Cc: David George <david.george@ska.ac.za>
Cc: "Hans J. Koch" <hjk@hansjkoch.de>
Cc: Marc Hulsman <m.hulsman@tudelft.nl>
Cc: Rudolf Marek <r.marek@assembler.cz>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>

7 years agohwmon: (vt8231) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:27 +0000]
hwmon: (vt8231) Fix multi-line comments

Cc: Roger Lucas <vt8231@hiddenengine.co.uk>
Acked-by: Roger Lucas <vt8231@hiddenengine.co.uk>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (adt7475) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:15 +0000]
hwmon: (adt7475) Fix multi-line comments

Cc: Jean Delvare <khali@linux-fr.org>
Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (f71805f) Fix checkpatch issues
Guenter Roeck [Thu, 19 Jan 2012 19:02:17 +0000]
hwmon: (f71805f) Fix checkpatch issues

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: "foo* bar" should be "foo *bar"
ERROR: need consistent spacing around '|' (ctx:VxW)
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead
WARNING: static const char * array should probably be static const char * const

Also modified multi-line comments to follow Documents/Codingstyle.

Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Jean Delvare <khali@linux-fr.org>

7 years agohwmon: (max6650) Fix multi-line comments
Guenter Roeck [Thu, 19 Jan 2012 19:02:22 +0000]
hwmon: (max6650) Fix multi-line comments

Cc: Hans J. Koch <hjk@hansjkoch.de>
Acked-by: Hans J. Koch <hjk@hansjkoch.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (w83781d) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 17:19:16 +0000]
hwmon: (w83781d) Fix checkpatch issues

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: "foo* bar" should be "foo *bar"
ERROR: space prohibited after that open parenthesis '('
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
WARNING: line over 80 characters
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead
WARNING: space prohibited between function name and open parenthesis '('

Not fixed (false positive):
ERROR: Macros with multiple statements should be enclosed in a do - while loop
ERROR: Macros with complex values should be enclosed in parenthesis

Not all fixed (code complexity):
ERROR: do not use assignment in if condition

Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (adm1025) Fix checkpatch issues
Guenter Roeck [Sat, 14 Jan 2012 20:49:22 +0000]
hwmon: (adm1025) Fix checkpatch issues

Fixed:
ERROR: do not use assignment in if condition
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: trailing whitespace
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Not fixed:
ERROR: Macros with multiple statements should be enclosed in a do - while loop

Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (abituguru3) Fix checkpatch issues
Guenter Roeck [Sat, 14 Jan 2012 20:40:05 +0000]
hwmon: (abituguru3) Fix checkpatch issues

Fixed:
ERROR: do not use assignment in if condition
ERROR: "foo* bar" should be "foo *bar"
WARNING: line over 80 characters

Not fixed:
WARNING: msleep < 20ms can sleep for up to 20ms

Cc: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Robert Coulson <robert.coulson@ericsson.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (vt8231) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 15:03:38 +0000]
hwmon: (vt8231) Fix checkpatch issues

Fixed:
ERROR: code indent should use tabs where possible
ERROR: do not use assignment in if condition
ERROR: trailing statements should be on next line
WARNING: braces {} are not necessary for any arm of this statement
WARNING: line over 80 characters
WARNING: please, no space before tabs
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Not fixed (false positive):
ERROR: Macros with multiple statements should be enclosed in a do - while loop

Cc: Roger Lucas <vt8231@hiddenengine.co.uk>
Acked-by: Roger Lucas <vt8231@hiddenengine.co.uk>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (max6650) Fix checkpatch issues
Guenter Roeck [Sun, 15 Jan 2012 05:32:21 +0000]
hwmon: (max6650) Fix checkpatch issues

Fixed:
ERROR: do not use assignment in if condition
ERROR: open brace '{' following struct go on the same line
ERROR: spaces required around that '||' (ctx:VxV)
ERROR: switch and case should be at the same indent
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Cc: Hans J. Koch <hjk@hansjkoch.de>
Acked-by: Hans J. Koch <hjk@hansjkoch.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (pmbus) Replace strict_strtol with kstrtol
Guenter Roeck [Mon, 16 Jan 2012 18:14:54 +0000]
hwmon: (pmbus) Replace strict_strtol with kstrtol

strict_strtol is deprecated and results in a checkpatch warning.
Replace it with kstrtol.

Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

7 years agohwmon: (lm83) fix checkpatch issues
Frans Meulenbroeks [Tue, 10 Jan 2012 22:01:40 +0000]
hwmon: (lm83) fix checkpatch issues

resolved:
ERROR: trailing whitespace
WARNING: please, no spaces at the start of a line
WARNING: simple_strtol is obsolete, use kstrtol instead
ERROR: do not use assignment in if condition

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>

7 years agohwmon: (k8temp) fix checkpatch issues
Frans Meulenbroeks [Tue, 10 Jan 2012 22:01:39 +0000]
hwmon: (k8temp) fix checkpatch issues

resolved:
WARNING: line over 80 characters
ERROR: do not use assignment in if condition

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>

7 years agohwmon: (lm80) reset device if error occurred
Frans Meulenbroeks [Tue, 10 Jan 2012 14:49:36 +0000]
hwmon: (lm80) reset device if error occurred

If an error occurs while updating (e.g. because the chip was
disconnected) the device needs to be reinitialized in order
to get back to 11 bit temperature and set the fan divider.

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>

7 years agohwmon: (lm80) fix checkpatch warnings
Frans Meulenbroeks [Tue, 10 Jan 2012 14:49:35 +0000]
hwmon: (lm80) fix checkpatch warnings

fix:
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
[guenter.roeck@ericsson.com: kstrtol->kstrtoul where appropriate]
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>

7 years agohwmon: (adt7470) fix checkpatch issues
Frans Meulenbroeks [Sun, 8 Jan 2012 18:34:13 +0000]
hwmon: (adt7470) fix checkpatch issues

fixed:
ERROR: that open brace { should be on the previous line
#1135: FILE: adt7470.c:1135:
+static struct attribute *adt7470_attr[] =
+{

ERROR: do not use assignment in if condition
#1279: FILE: adt7470.c:1279:
+ if ((err = sysfs_create_group(&client->dev.kobj, &data->attrs)))

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>

7 years agohwmon: (adt7411) fix checkpatch issues
Frans Meulenbroeks [Sun, 8 Jan 2012 18:34:12 +0000]
hwmon: (adt7411) fix checkpatch issues

fixed:
WARNING: please, no space before tabs
#11: FILE: adt7411.c:11:
+ * ^I  use power-down mode for suspend?, interrupt handling?$

not fixed as all other macros around it are the same structure and this one is only 2 chars longer:
WARNING: line over 80 characters
#229: FILE: adt7411.c:229:
+static ADT7411_BIT_ATTR(fast_sampling, ADT7411_REG_CFG3, ADT7411_CFG3_ADC_CLK_225);

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>

7 years agohwmon: (lm70) fix checkpatch issues
Frans Meulenbroeks [Sun, 8 Jan 2012 18:34:11 +0000]
hwmon: (lm70) fix checkpatch issues

fixed:
ERROR: spaces required around that '=' (ctx:VxV)
#60: FILE: lm70.c:60:
+ s16 raw=0;
         ^

ERROR: do not use assignment in if condition
#168: FILE: lm70.c:168:
+ if ((status = device_create_file(&spi->dev, &dev_attr_temp1_input))

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>

7 years agohwmon: (f71882fg) fix checkpatch issues
Frans Meulenbroeks [Sun, 8 Jan 2012 18:34:10 +0000]
hwmon: (f71882fg) fix checkpatch issues

fixed:
WARNING: static const char * array should probably be static const char * const
+static const char *f71882fg_names[] = {

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>

7 years agohwmon: (asus_atk0110) fix checkpatch issues
Frans Meulenbroeks [Sun, 8 Jan 2012 18:34:09 +0000]
hwmon: (asus_atk0110) fix checkpatch issues

fixed:
WARNING: line over 80 characters
#1321: FILE: asus_atk0110.c:1321:
+ if (data->rtmp_handle && data->rvlt_handle && data->rfan_handle && !new_if)

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>