crypto, xor: Sanitize checksumming function selection output
Borislav Petkov [Wed, 4 Apr 2012 13:06:10 +0000 (15:06 +0200)]
Currently, it says

[    1.015541] xor: automatically using best checksumming function: generic_sse
[    1.040769]    generic_sse:  6679.000 MB/sec
[    1.045377] xor: using function: generic_sse (6679.000 MB/sec)

and repeats the function name three times unnecessarily. Change it into

[    1.015115] xor: automatically using best checksumming function:
[    1.040794]    generic_sse:  6680.000 MB/sec

and save us a line in dmesg.

No functional change.

Cc: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

crypto/xor.c

index b75182d..664b6df 100644 (file)
@@ -129,9 +129,9 @@ calibrate_xor_blocks(void)
 
        if (fastest) {
                printk(KERN_INFO "xor: automatically using best "
-                       "checksumming function: %s\n",
-                       fastest->name);
+                                "checksumming function:\n");
                xor_speed(fastest);
+               goto out;
        } else {
                printk(KERN_INFO "xor: measuring software checksum speed\n");
                XOR_TRY_TEMPLATES;
@@ -146,6 +146,7 @@ calibrate_xor_blocks(void)
 
 #undef xor_speed
 
+ out:
        free_pages((unsigned long)b1, 2);
 
        active_template = fastest;