f2fs: fix to put root inode in error path of fill_super
Chao Yu [Fri, 25 Jul 2014 04:55:09 +0000 (12:55 +0800)]
We should put root inode correctly in error path of fill_super, otherwise we
may encounter a leak case of inode resource.

Signed-off-by: Chao Yu <chao2.yu@samsung.com>
Reviewed-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

fs/f2fs/super.c

index 1969200..3d10034 100644 (file)
@@ -1120,8 +1120,9 @@ get_cp:
                goto free_node_inode;
        }
        if (!S_ISDIR(root->i_mode) || !root->i_blocks || !root->i_size) {
+               iput(root);
                err = -EINVAL;
-               goto free_root_inode;
+               goto free_node_inode;
        }
 
        sb->s_root = d_make_root(root); /* allocate root dentry */