[media] em28xx: save isoc endpoint number for DVB only if endpoint has alt settings...
Frank Schaefer [Mon, 8 Apr 2013 16:06:59 +0000 (13:06 -0300)]
X-Patchwork-Delegate: mchehab@redhat.com
In addition to commit 72cc9ba3 "em28xx: ignore isoc DVB USB endpoints with
wMaxPacketSize = 0 bytes for all alt settings" we should not save the endpoint
number of the isoc DVB endpoint before it has been validated.
While the current code works fine, dev->dvb_ep_isoc != 0 could be interpreted
as indicator that the device provides DVB support.

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

drivers/media/usb/em28xx/em28xx-cards.c

index d2ed678..83bfbe4 100644 (file)
@@ -3220,9 +3220,9 @@ static int em28xx_usb_probe(struct usb_interface *interface,
                                                            e->bEndpointAddress;
                                        } else {
                                                if (usb_endpoint_xfer_isoc(e)) {
-                                                       dev->dvb_ep_isoc = e->bEndpointAddress;
                                                        if (size > dev->dvb_max_pkt_size_isoc) {
                                                                has_dvb = true; /* see NOTE (~) */
+                                                               dev->dvb_ep_isoc = e->bEndpointAddress;
                                                                dev->dvb_max_pkt_size_isoc = size;
                                                                dev->dvb_alt_isoc = i;
                                                        }